extra sanity checks for claiming an abandoned tree

src/engine/db/handlers/dbBuildingLocationHandler.java

@@ -32,10 +32,14 @@ public class dbBuildingLocationHandler extends dbHandlerBase {
         ArrayList<BuildingLocation> buildingLocations = new ArrayList<>();
 
         try (Connection connection = DbManager.getConnection();
-             PreparedStatement preparedStatement = connection.prepareStatement("select `ID`, `BuildingID`, `type`, `slot`, `unknown`, `locX`, `locY`, `locZ`, `w`,  `rotX`, `rotY`, `rotZ` from static_building_location " +
+             PreparedStatement preparedStatement = connection.prepareStatement(
-                     "where type = 6 or type = 8 " +
+                     "SELECT MIN(ID), BuildingID, slot, MIN(type), MIN(unknown), MIN(locX), MIN(locY), MIN(locZ), " +
-                     "GROUP BY buildingID, slot " +
+                             "MIN(w), MIN(rotX), MIN(rotY), MIN(rotZ) " +
-                     "ORDER BY buildingID, slot ASC;")) {
+                             "FROM static_building_location " +
+                             "WHERE type IN (6, 8) " +
+                             "GROUP BY BuildingID, slot " +
+                             "ORDER BY BuildingID, slot ASC;"
+             )) {
 
             ResultSet rs = preparedStatement.executeQuery();
             buildingLocations = getObjectsFromRs(rs, 20);

src/engine/db/handlers/dbCityHandler.java

@@ -210,7 +210,7 @@ public class dbCityHandler extends dbHandlerBase {
     public boolean updateSiegesWithstood(City city, int value) {
 
         try (Connection connection = DbManager.getConnection();
-             PreparedStatement preparedStatement = connection.prepareStatement("UPDATE `obj_city` SET `name`=?"
+             PreparedStatement preparedStatement = connection.prepareStatement("UPDATE `obj_city` SET `siegesWithstood`=?"
                      + " WHERE `UID` = ?")) {
 
             preparedStatement.setInt(1, value);

src/engine/db/handlers/dbHandlerBase.java

@@ -58,6 +58,9 @@ public abstract class dbHandlerBase {
 
                 int id = rs.getInt(1);
 
+                if (id == 883640)
+                    Logger.info("hit");
+
                 if (DbManager.inCache(localObjectType, id)) {
                     objectList.add((T) DbManager.getFromCache(localObjectType, id));
                 } else {

src/engine/gameManager/BuildingManager.java

@@ -777,7 +777,7 @@ public enum BuildingManager {
         int newMeshUUID;
         boolean success;
 
-        // If this building has no blueprint then set rank and exit immediately.
+        // If this building has no blueprint then set rank and exit immediatly.
 
         if (building.blueprintUUID == 0 || building.getBlueprint() != null && building.getBlueprint().getBuildingGroup().equals(BuildingGroup.MINE)) {
             building.rank = rank;

src/engine/net/client/handlers/ClaimAssetMsgHandler.java

@@ -17,9 +17,8 @@ import engine.mbEnums.BuildingGroup;
 import engine.net.client.ClientConnection;
 import engine.net.client.msg.ClaimAssetMsg;
 import engine.net.client.msg.ClientNetMsg;
-import engine.objects.Blueprint;
+import engine.net.client.msg.ErrorPopupMsg;
-import engine.objects.Building;
+import engine.objects.*;
-import engine.objects.PlayerCharacter;
 import org.pmw.tinylog.Logger;
 
 import java.util.concurrent.locks.ReentrantReadWriteLock;
@@ -111,9 +110,9 @@ public class ClaimAssetMsgHandler extends AbstractClientMsgHandler {
             // Can't claim a tree if your guild already owns one
             // *** Refactor : Send error to player here
 
-            if ((sourcePlayer.getGuild().isNation()) &&
+            if(blueprint.getBuildingGroup() == BuildingGroup.TOL && !validateTreeClaim(sourcePlayer)){
-                    (blueprint.getBuildingGroup() == BuildingGroup.TOL))
                 return true;
+            }
 
             // Process the transfer of the building(s)
 
@@ -135,4 +134,24 @@ public class ClaimAssetMsgHandler extends AbstractClientMsgHandler {
         return true;
     }
 
+    private boolean validateTreeClaim(PlayerCharacter sourcePlayer) {
+
+        if(sourcePlayer.guild.equals(Guild.getErrantGuild())) {
+            ErrorPopupMsg.sendErrorMsg(sourcePlayer, "Errant Players Cannot Claim Cities!");
+            return false;
+        }
+
+        if(sourcePlayer.guild.getOwnedCity() != null) {
+            ErrorPopupMsg.sendErrorMsg(sourcePlayer, "Your Guild Already Owns A City!");
+            return false;
+        }
+
+        if(!GuildStatusController.isGuildLeader(sourcePlayer.getGuildStatus())) {
+            ErrorPopupMsg.sendErrorMsg(sourcePlayer, "Only A Guild Leader Can Claim A Tree Of Life!");
+            return false;
+        }
+
+        return true;
+    }
+
 }

src/engine/net/client/handlers/PlaceAssetMsgHandler.java

@@ -528,8 +528,15 @@ public class PlaceAssetMsgHandler extends AbstractClientMsgHandler {
             return false;
 
         if (cityObject.warehouse != null) {
-            PlaceAssetMsg.sendPlaceAssetError(origin, 50, "");  //"You can only have one warehouse"
+            if(cityObject.warehouse.building != null) {
-            return false;
+                //warehosue has a building already, warehouse still should exist
+                PlaceAssetMsg.sendPlaceAssetError(origin, 50, "");  //"You can only have one warehouse"
+                return false;
+            }else{
+                //warehouse has no building and needs a cleanup
+                DbManager.WarehouseQueries.DELETE_WAREHOUSE(cityObject.warehouse);
+                cityObject.warehouse = null;
+            }
         }
 
         // Create the warehouse object and it's entry in the database

src/engine/objects/Building.java

@@ -505,11 +505,6 @@ public class Building extends AbstractWorldObject {
             return;
         }
 
-        if (city.destroyed.get() == true) {
-            Logger.error(city.getName() + "derankk called on destroyed city");
-            return;
-        }
-
         bane = city.getBane();
 
         // We need to collect the spires and shrines on the citygrid in case
@@ -597,13 +592,6 @@ public class Building extends AbstractWorldObject {
             return;
         }
 
-        if (city.destroyed.get() == true) {
-            Logger.error(city.getName() + "attempt to destroy a destroyed city");
-            return;
-        }
-
-        city.destroyed.set(true);
-
         // Must remove a bane before considering destruction of a TOL
 
         if (bane != null) {

src/engine/objects/City.java

@@ -41,7 +41,6 @@ import java.util.HashSet;
 import java.util.Iterator;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ThreadLocalRandom;
-import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.locks.ReentrantReadWriteLock;
 
 public class City extends AbstractWorldObject {
@@ -81,7 +80,6 @@ public class City extends AbstractWorldObject {
     private String hash;
     public Warehouse warehouse;
     public Realm realm;
-    public AtomicBoolean destroyed = new AtomicBoolean(false);
 
     /**
      * ResultSet Constructor
@@ -1106,7 +1104,7 @@ public class City extends AbstractWorldObject {
 
         Thread destroyCityThread = new Thread(new DestroyCityThread(this));
 
-        destroyCityThread.setName("destroyCity: " + this.getName());
+        destroyCityThread.setName("destroyCity:" + this.getName());
         destroyCityThread.start();
     }
 
@@ -1114,7 +1112,7 @@ public class City extends AbstractWorldObject {
 
         Thread transferCityThread = new Thread(new TransferCityThread(this, newOwner));
 
-        transferCityThread.setName("TransferCity: " + this.getName());
+        transferCityThread.setName("TransferCity:" + this.getName());
         transferCityThread.start();
     }
 

src/engine/workthreads/DestroyCityThread.java

@@ -83,6 +83,8 @@ public class DestroyCityThread implements Runnable {
             }
         }
 
+        Building tol = null;
+
         // Build list of buildings within this parent zone
 
         for (Building cityBuilding : cityZone.zoneBuildingSet) {
@@ -98,6 +100,13 @@ public class DestroyCityThread implements Runnable {
             if (cityBuilding.getBlueprint().getBuildingGroup().equals(mbEnums.BuildingGroup.BANESTONE))
                 continue;
 
+            // TOL is processed after all other structures in the city zone
+
+            if (cityBuilding.getBlueprint().getBuildingGroup().equals(mbEnums.BuildingGroup.TOL)) {
+                tol = cityBuilding;
+                continue;
+            }
+
             // All buildings are moved to a location relative
             // to their new parent zone
 
@@ -137,6 +146,11 @@ public class DestroyCityThread implements Runnable {
             }
         }
 
+        // Destroy the tol
+
+        if (tol != null)
+            BuildingManager.setRank(tol, -1);
+
         if (city.realm != null)
             city.realm.removeCity(city.getObjectUUID());