From ff6e63942b4ecc694cfb869db6c5e723b7e3654c Mon Sep 17 00:00:00 2001 From: MagicBot Date: Mon, 2 May 2022 11:49:17 +0000 Subject: [PATCH] Update 'Submitting Pull Requests' --- Submitting-Pull-Requests.md | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/Submitting-Pull-Requests.md b/Submitting-Pull-Requests.md index 71aebbe..9dbf271 100644 --- a/Submitting-Pull-Requests.md +++ b/Submitting-Pull-Requests.md @@ -22,4 +22,14 @@ Now we can commit and push our changes to the repository. This new branch with our bugfix can now be found on the Magicbane repo. Click to create a new Pull Request. -![branchlist](https://cdn.discordapp.com/attachments/534260038039109632/970650197971587072/unknown.png) \ No newline at end of file +![branchlist](https://cdn.discordapp.com/attachments/534260038039109632/970650197971587072/unknown.png) + +We can now give out Pull Request as much information as we can; including assigning a label. + +![pullenter](https://cdn.discordapp.com/attachments/534260038039109632/970651925597028432/unknown.png) + +The Pull Request has now been made. It is time for anyone to chime in and comment on the request. Time for the MagicBane test team to validate the fix on the development server. Perhaps even run your fix live for a week to kick the tires. + +Once enough people are in agreement that the change should be made it will be merged into the master branch. + +![pulledit](https://cdn.discordapp.com/attachments/534260038039109632/970652154018820126/unknown.png)