quick targeting check cleanup

src/engine/net/client/ClientMessagePump.java

@@ -1863,8 +1863,6 @@ public class ClientMessagePump implements NetMsgHandler {
             return false;
         }
 
-        KeyCloneAudit.auditNetMsg(msg);
-
         ClientConnection origin;
         Protocol protocolMsg = Protocol.NONE;
         Session s;
@@ -1888,6 +1886,7 @@ public class ClientMessagePump implements NetMsgHandler {
 
             switch (protocolMsg) {
                 case SETSELECTEDOBECT:
+                    KeyCloneAudit.auditTargetMsg(msg);
                     ClientMessagePump.targetObject((TargetObjectMsg) msg, origin);
                     break;
 

src/engine/util/KeyCloneAudit.java

@@ -1,7 +1,5 @@
 package engine.util;
 
-import engine.InterestManagement.WorldGrid;
-import engine.gameManager.ChatManager;
 import engine.gameManager.ConfigManager;
 import engine.gameManager.DbManager;
 import engine.gameManager.SessionManager;
@@ -14,8 +12,6 @@ import engine.objects.PlayerCharacter;
 import engine.server.MBServerStatics;
 import org.pmw.tinylog.Logger;
 
-import java.awt.image.ImageObserver;
-
 public enum KeyCloneAudit {
     KEYCLONEAUDIT;
 
@@ -38,19 +34,13 @@ public enum KeyCloneAudit {
 
     }
 
-    public static void auditNetMsg(ClientNetMsg msg) {
+    public static void auditTargetMsg(ClientNetMsg msg) {
-        boolean valid = true;
         try {
-            if (msg.getProtocolMsg().equals(Protocol.KEEPALIVESERVERCLIENT))
+            TargetObjectMsg tarMsg = (TargetObjectMsg) msg;
-                return;
-
             ClientConnection origin = (ClientConnection) msg.getOrigin();
             long now = System.currentTimeMillis();
-            PlayerCharacter pc = SessionManager.getSession(origin).getPlayerCharacter();
-            if (msg.getProtocolMsg().equals(Protocol.SETSELECTEDOBECT)) {
 
-                TargetObjectMsg tarMsg = (TargetObjectMsg)msg;
+            if (tarMsg.getTargetType() != MBServerStatics.MASK_PLAYER)
-                if(tarMsg.getTargetType() != MBServerStatics.MASK_PLAYER)
                 return;
 
             if (System.currentTimeMillis() > origin.finalStrikeRefresh) {
@@ -68,13 +58,10 @@ public enum KeyCloneAudit {
             }
             if (origin.strikes > 20) {
                 origin.finalStrikes++;
-                    //ChatManager.chatSystemInfo(pc, "Strike Received: " + origin.finalStrikes);
             }
-                if (origin.finalStrikes > 3) {
+            if (origin.finalStrikes > 3) {origin.forceDisconnect();
-                    origin.forceDisconnect();
                 DbManager.AccountQueries.SET_TRASH(origin.machineID);
             }
-            }
         } catch (Exception e) {
 
         }