MagicBane
/
Server
92
0
Fork 2
Code Issues 7 Pull Requests Projects Releases Wiki Activity

Update 'Submitting Pull Requests'

master
MagicBot 3 years ago
parent
1abb32a37c
commit
ff6e63942b
1 changed files with 11 additions and 1 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 12
      Submitting-Pull-Requests.md

12
Submitting-Pull-Requests.md
Unescape

@ -22,4 +22,14 @@ Now we can commit and push our changes to the repository.
This new branch with our bugfix can now be found on the Magicbane repo. Click to create a new Pull Request. This new branch with our bugfix can now be found on the Magicbane repo. Click to create a new Pull Request.
![branchlist](https://cdn.discordapp.com/attachments/534260038039109632/970650197971587072/unknown.png) ![branchlist](https://cdn.discordapp.com/attachments/534260038039109632/970650197971587072/unknown.png)
We can now give out Pull Request as much information as we can; including assigning a label.
![pullenter](https://cdn.discordapp.com/attachments/534260038039109632/970651925597028432/unknown.png)
The Pull Request has now been made. It is time for anyone to chime in and comment on the request. Time for the MagicBane test team to validate the fix on the development server. Perhaps even run your fix live for a week to kick the tires.
Once enough people are in agreement that the change should be made it will be merged into the master branch.
![pulledit](https://cdn.discordapp.com/attachments/534260038039109632/970652154018820126/unknown.png)

Write Preview
Loading…
Cancel
Save