questing failsafes

src/engine/QuestSystem/QuestManager.java

@@ -0,0 +1,131 @@
+package engine.QuestSystem;
+
+import engine.InterestManagement.WorldGrid;
+import engine.gameManager.ChatManager;
+import engine.net.client.msg.ErrorPopupMsg;
+import engine.objects.*;
+import engine.server.MBServerStatics;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Random;
+
+public class QuestManager {
+    public static HashMap<PlayerCharacter,QuestObject> acceptedQuests = new HashMap<>();
+    public static HashMap<PlayerCharacter,ArrayList<String>> completedQuests = new HashMap<>();
+
+    public static boolean grantsQuest(NPC npc){
+        if(npc == null)
+            return false;
+
+        if(npc.contract == null)
+            return false;
+
+        return npc.contract.getName().contains("ZoneLore") || npc.contract.getName().equals("Barrowlands Sentry");
+    }
+
+    public static void displayCurrentQuest(PlayerCharacter pc){
+        if(acceptedQuests.containsKey(pc)){
+            QuestObject obj = acceptedQuests.get(pc);
+            String output = "You have embarked on the noble quest: ";
+            output += obj.QuestName + ". ";
+            output += obj.description;
+            output += ". " + obj.objectiveCount + " / " + obj.objectiveCountRequired;
+            ErrorPopupMsg.sendErrorMsg(pc, output);
+        }else{
+            ErrorPopupMsg.sendErrorMsg(pc, "You have no active quest.");
+        }
+    }
+
+    public static void acceptQuest(PlayerCharacter pc, QuestObject obj){
+        if (completedQuests.containsKey(pc)) {
+            if(completedQuests.get(pc).contains(obj.QuestName)){
+                ErrorPopupMsg.sendErrorMsg(pc, "You have already completed the quest: " + obj.QuestName);
+                return;
+            }
+        }
+
+        if(acceptedQuests.containsKey(pc)){
+            if(acceptedQuests.get(pc)!= null){
+                ErrorPopupMsg.sendErrorMsg(pc, "You have already embarked on a noble quest.");
+                return;
+            }
+        }
+
+        acceptedQuests.put(pc,obj);
+        displayCurrentQuest(pc);
+    }
+
+    public static void completeQuest(PlayerCharacter pc, QuestObject obj){
+
+        if(obj.objectiveCount < obj.objectiveCountRequired) {
+            ChatManager.chatSystemInfo(pc, obj.QuestName + " Progress: " + obj.objectiveCount + " / " + obj.objectiveCountRequired);
+            return;
+        }
+
+        //notify the player they have completed their quest
+        ErrorPopupMsg.sendErrorMsg(pc, "You have completed the quest: " + obj.QuestName +"!");
+
+        //add completed quest to completion log
+        if (completedQuests.containsKey(pc)) {
+            completedQuests.get(pc).add(obj.QuestName);
+        }else{
+            ArrayList<String> completed = new ArrayList<>();
+            completed.add(obj.QuestName);
+            completedQuests.put(pc,completed);
+        }
+
+        //remove current quest from active log
+        if(acceptedQuests.containsKey(pc))
+            acceptedQuests.remove(pc);
+
+        //grant rewards
+        //only grant XP if level is below 75
+        if(pc.level < 75) {
+            int xpGrant = (int) (Experience.maxXPPerKill(pc.getLevel()) * 10);
+            pc.grantXP(xpGrant);
+            ChatManager.chatSystemInfo(pc, "Your Quest Has Granted you: " + xpGrant + " Experience Points");
+        }
+
+        int goldGrant = (int) Experience.maxXPPerKill(pc.getLevel());
+        pc.getCharItemManager().addGoldToInventory(goldGrant,false);
+        ChatManager.chatSystemInfo(pc, "Your Quest Has Granted you: " + goldGrant + " Gold Coins");
+
+        pc.getCharItemManager().updateInventory();
+    }
+
+    public static QuestObject getQuestForContract(NPC npc){
+        QuestObject obj = new QuestObject();
+        obj.QuestName = npc.getFirstName() + "'s Quest";
+
+        HashSet<AbstractWorldObject> mobs = WorldGrid.getObjectsInRangePartial(npc.loc,2048, MBServerStatics.MASK_MOB);
+        if (mobs.isEmpty())
+            return null; // Handle the case where the set is empty
+
+        // Convert HashSet to a List
+        ArrayList<AbstractWorldObject> mobList = new ArrayList<>(mobs);
+
+        Mob mob = null;
+
+        while(mob == null || Mob.discDroppers.contains(mob)) {
+            // Generate a random index
+            Random random = new Random();
+            int randomIndex = random.nextInt(mobList.size());
+
+            if (mobList.get(randomIndex) == null) {
+                continue;
+            }
+
+            mob = (Mob) mobList.get(randomIndex);
+        }
+        obj.progressionNames = new ArrayList<>();
+        obj.progressionNames.add(mob.getFirstName());
+
+        obj.objectiveCountRequired = 10;
+        obj.objectiveCount = 0;
+
+        obj.description = "These lands are plagued with " + mob.getFirstName() + " complete the quest by slaying 10 of them!";
+        return obj;
+    }
+}

src/engine/QuestSystem/QuestObject.java

@@ -0,0 +1,27 @@
+package engine.QuestSystem;
+
+import engine.objects.ItemBase;
+import engine.objects.NPC;
+import engine.objects.PlayerCharacter;
+
+import java.util.ArrayList;
+
+public class QuestObject {
+
+    public String QuestName;
+    public String description;
+    public int objectiveCount;
+    public int objectiveCountRequired;
+    public ArrayList<String> progressionNames;
+    public PlayerCharacter owner;
+
+    public QuestObject(){
+
+    }
+    public void tryProgress(String option){
+        if(this.progressionNames.contains(option))
+            this.objectiveCount++;
+        else
+            return;
+    }
+}

src/engine/db/handlers/dbItemBaseHandler.java

@@ -22,7 +22,6 @@ import java.util.HashMap;
 
 public class dbItemBaseHandler extends dbHandlerBase {
 
-    public static final HashMap<Integer,Float> dexReductions = new HashMap<>();
     public dbItemBaseHandler() {
 
     }
@@ -46,14 +45,6 @@ public class dbItemBaseHandler extends dbHandlerBase {
         }
     }
 
-    public void LOAD_DEX_REDUCTION(ItemBase itemBase) {
-        if(dexReductions.containsKey(itemBase.getUUID())){
-            itemBase.dexReduction = dexReductions.get(itemBase.getUUID());
-        }else{
-            itemBase.dexReduction = 0.0f;
-        }
-    }
-
     public void LOAD_ANIMATIONS(ItemBase itemBase) {
 
         ArrayList<Integer> tempList = new ArrayList<>();
@@ -103,21 +94,6 @@ public class dbItemBaseHandler extends dbHandlerBase {
         }
 
         Logger.info("read: " + recordsRead + " cached: " + ItemBase.getUUIDCache().size());
-        try (Connection connection = DbManager.getConnection();
-             PreparedStatement preparedStatement = connection.prepareStatement("SELECT * FROM `static_item_dexpenalty`")) {
-
-            ResultSet rs = preparedStatement.executeQuery();
-
-            // Check if a result was found
-            if (rs.next()) {
-                int ID = rs.getInt("ID");
-                float factor = rs.getInt("item_bulk_factor");
-                dexReductions.put(ID,factor);
-            }
-
-        } catch (SQLException e) {
-            Logger.error(e);
-        }
     }
 
     public HashMap<Integer, ArrayList<Integer>> LOAD_RUNES_FOR_NPC_AND_MOBS() {

src/engine/devcmd/cmds/InfoCmd.java

@@ -342,8 +342,7 @@ public class InfoCmd extends AbstractDevCmd {
                 output += newline;
                 output += "isMoving : " + targetPC.isMoving();
                 output += newline;
-                output += "Zerg Multiplier : " + targetPC.ZergMultiplier+ newline;
+                output += "Zerg Multiplier : " + targetPC.ZergMultiplier;
-                output += "Hidden : " + targetPC.getHidden();
                 break;
 
             case NPC:
@@ -506,7 +505,7 @@ public class InfoCmd extends AbstractDevCmd {
                 output += "Effects:" + newline;
                 for(MobBaseEffects mbe : targetMob.mobBase.mobbaseEffects){
                     EffectsBase eb = PowersManager.getEffectByToken(mbe.getToken());
-                    output += eb.getName() + newline;
+                    output += eb.getName() + " " + eb.getIDString() + newline;
                 }
                 break;
             case Item:  //intentional passthrough

src/engine/devcmd/cmds/PrintSkillsCmd.java

@@ -49,8 +49,6 @@ public class PrintSkillsCmd extends AbstractDevCmd {
                         + skill.getModifiedAmount() + '('
                         + skill.getTotalSkillPercet() + " )");
             }
-            //throwbackInfo(pc, "= = = = = NEW CALCULATIONS = = = = =");
-           // PlayerCombatStats.PrintSkillsToClient(pc);
         } else
             throwbackInfo(pc, "Skills not found for player");
     }

src/engine/devcmd/cmds/PrintStatsCmd.java

@@ -57,36 +57,27 @@ public class PrintStatsCmd extends AbstractDevCmd {
 
     public void printStatsPlayer(PlayerCharacter pc, PlayerCharacter tar) {
         String newline = "\r\n ";
-
+        String out = "Server stats for Player " + tar.getFirstName() + newline;
-        String newOut = "Server stats for Player " + tar.getFirstName() + newline;
+        out += "Unused Stats: " + tar.getUnusedStatPoints() + newline;
-        newOut += "HEALTH: " + tar.getHealth() + " / " + tar.getHealthMax() + newline;
+        out += "Stats Base (Modified)" + newline;
-        newOut += "MANA: " + tar.getMana() + " / " + tar.getManaMax() + newline;
+        out += "  Str: " + (int) tar.statStrBase + " (" + tar.getStatStrCurrent() + ')' + ", maxStr: " + tar.getStrMax() + newline;
-        newOut += "STAMINA: " + tar.getStamina() + " / " + tar.getStaminaMax() + newline;
+        out += "  Dex: " + (int) tar.statDexBase + " (" + tar.getStatDexCurrent() + ')' + ", maxDex: " + tar.getDexMax() + newline;
-        newOut += "Unused Stats: " + tar.getUnusedStatPoints() + newline;
+        out += "  Con: " + (int) tar.statConBase + " (" + tar.getStatConCurrent() + ')' + ", maxCon: " + tar.getConMax() + newline;
-        newOut += "Stats Base (Modified)" + newline;
+        out += "  Int: " + (int) tar.statIntBase + " (" + tar.getStatIntCurrent() + ')' + ", maxInt: " + tar.getIntMax() + newline;
-        newOut += "  Str: " + (int) tar.statStrBase + " (" + tar.getStatStrCurrent() + ')' + ", maxStr: " + tar.getStrMax() + newline;
+        out += "  Spi: " + (int) tar.statSpiBase + " (" + tar.getStatSpiCurrent() + ')' + ", maxSpi: " + tar.getSpiMax() + newline;
-        newOut += "  Dex: " + (int) tar.statDexBase + " (" + tar.getStatDexCurrent() + ')' + ", maxDex: " + tar.getDexMax() + newline;
+        throwbackInfo(pc, out);
-        newOut += "  Con: " + (int) tar.statConBase + " (" + tar.getStatConCurrent() + ')' + ", maxCon: " + tar.getConMax() + newline;
+        out = "Health: " + tar.getHealth() + ", maxHealth: " + tar.getHealthMax() + newline;
-        newOut += "  Int: " + (int) tar.statIntBase + " (" + tar.getStatIntCurrent() + ')' + ", maxInt: " + tar.getIntMax() + newline;
+        out += "Mana: " + tar.getMana() + ", maxMana: " + tar.getManaMax() + newline;
-        newOut += "  Spi: " + (int) tar.statSpiBase + " (" + tar.getStatSpiCurrent() + ')' + ", maxSpi: " + tar.getSpiMax() + newline;
+        out += "Stamina: " + tar.getStamina() + ", maxStamina: " + tar.getStaminaMax() + newline;
-        newOut += "Move Speed: " + tar.getSpeed() + newline;
+        out += "Defense: " + tar.getDefenseRating() + newline;
-        newOut += "Health Regen: " + tar.combatStats.healthRegen + newline;
+        out += "Main Hand: atr: " + tar.getAtrHandOne() + ", damage: " + tar.getMinDamageHandOne() + " to " + tar.getMaxDamageHandOne() + ", speed: " + tar.getSpeedHandOne() + newline;
-        newOut += "Mana Regen: " + tar.combatStats.manaRegen + newline;
+        out += "Off Hand:  atr: " + tar.getAtrHandTwo() + ", damage: " + tar.getMinDamageHandTwo() + " to " + tar.getMaxDamageHandTwo() + ", speed: " + tar.getSpeedHandTwo() + newline;
-        newOut += "Stamina Regen: " + tar.combatStats.staminaRegen + newline;
+        out += "isAlive: " + tar.isAlive() + ", Combat: " + tar.isCombat() + newline;
-        newOut += "DEFENSE: " + tar.combatStats.defense + newline;
+        out += "Move Speed: " + tar.getSpeed() + newline;
-        newOut += "HAND ONE" + newline;
+        out += "Health Regen: " + tar.getRegenModifier(Enum.ModType.HealthRecoverRate) + newline;
-        newOut += "ATR: " +  tar.combatStats.atrHandOne + newline;
+        out += "Mana Regen: " + tar.getRegenModifier(Enum.ModType.ManaRecoverRate) + newline;
-        newOut += "MIN: " + tar.combatStats.minDamageHandOne + newline;
+        out += "Stamina Regen: " + tar.getRegenModifier(Enum.ModType.StaminaRecoverRate) + newline;
-        newOut += "MAX: " + tar.combatStats.maxDamageHandOne + newline;
+        throwbackInfo(pc, out);
-        newOut += "RANGE: " + tar.combatStats.rangeHandOne + newline;
-        newOut += "ATTACK SPEED: " + tar.combatStats.attackSpeedHandOne + newline;
-        newOut += "HAND TWO" + newline;
-        newOut += "ATR: " + tar.combatStats.atrHandTwo + newline;
-        newOut += "MIN: " + tar.combatStats.minDamageHandTwo + newline;
-        newOut += "MAX: " + tar.combatStats.maxDamageHandTwo + newline;
-        newOut += "RANGE: " + tar.combatStats.rangeHandTwo + newline;
-        newOut += "ATTACK SPEED: " + tar.combatStats.attackSpeedHandTwo + newline;
-        throwbackInfo(pc, newOut);
     }
 
     public void printStatsMob(PlayerCharacter pc, Mob tar) {

src/engine/devcmd/cmds/SimulateBootyCmd.java

@@ -1,6 +1,5 @@
 package engine.devcmd.cmds;
 
-import engine.Enum;
 import engine.devcmd.AbstractDevCmd;
 import engine.gameManager.LootManager;
 import engine.gameManager.ZoneManager;
@@ -27,52 +26,7 @@ public class SimulateBootyCmd extends AbstractDevCmd {
         String newline = "\r\n ";
 
         String output;
-        if(target.getObjectType().equals(Enum.GameObjectType.PlayerCharacter)){
-            int ATR = Integer.parseInt(words[0]);
-            int DEF = Integer.parseInt(words[1]);
-            int attacks = Integer.parseInt(words[2]);
 
-            int hits = 0;
-            int misses = 0;
-            int defaultHits = 0;
-            int defualtMisses = 0;
-
-            float chance = (ATR-((ATR+DEF) * 0.315f)) / ((DEF-((ATR+DEF) * 0.315f)) + (ATR-((ATR+DEF) * 0.315f)));
-            float convertedChance = chance * 100;
-            output = "" + newline;
-            output += "DEF VS ATR SIMULATION: " + attacks + " ATTACKS SIMULATED" + newline;
-            output += "DEF = " + DEF + newline;
-            output += "ATR = " + ATR + newline;
-            output += "CHANCE TO LAND HIT: " + convertedChance + "%" + newline;
-            if(convertedChance < 5){
-                output += "CHANCE ADJUSTED TO 5.0%" + newline;
-                convertedChance = 5.0f;
-            }
-            if(convertedChance > 95){
-                output += "CHANCE ADJUSTED TO 95.0%" + newline;
-                convertedChance = 95.0f;
-            }
-            for(int i = 0; i < attacks; i++){
-                int roll = ThreadLocalRandom.current().nextInt(101);
-
-                if(roll <= convertedChance){
-                    hits += 1;
-                }else{
-                    misses += 1;
-                }
-            }
-
-            float totalHits = defaultHits + hits;
-            float totalMisses = defualtMisses + misses;
-            float hitPercent = Math.round(totalHits / attacks * 100);
-            float missPercent = Math.round(totalMisses / attacks * 100);
-
-            output += "HITS LANDED: " + (defaultHits + hits) + "(" + Math.round(hitPercent) + "%)" + newline;
-            output += "HITS MISSED: " + (defualtMisses + misses) + "(" + Math.round(missPercent) + "%)";
-
-            throwbackInfo(playerCharacter,output);
-            return;
-        }
         try
         {
             simCount = Integer.parseInt(words[0]);

src/engine/gameManager/ChatManager.java

@@ -14,6 +14,7 @@ import engine.Enum.GameObjectType;
 import engine.Enum.ModType;
 import engine.Enum.SourceType;
 import engine.InterestManagement.WorldGrid;
+import engine.QuestSystem.QuestManager;
 import engine.db.archive.BaneRecord;
 import engine.db.archive.PvpRecord;
 import engine.net.Dispatch;
@@ -108,9 +109,9 @@ public enum ChatManager {
                 ChatManager.chatIC(pc, (ChatICMsg) msg);
                 return;
             case LEADERCHANNELMESSAGE:
+            case GLOBALCHANNELMESSAGE:
                 ChatManager.chatGlobal(pc, msg.getMessage(), isFlood);
                 return;
-            case GLOBALCHANNELMESSAGE:
             case CHATPVP:
             case CHATCITY:
             case CHATINFO:
@@ -199,6 +200,11 @@ public enum ChatManager {
             return;
         }
 
+        if(text.equalsIgnoreCase("show_quest()")){
+            QuestManager.displayCurrentQuest(pcSender);
+            return;
+        }
+
         if (ChatManager.isVersionRequest(text) == true) {
             sendSystemMessage(pcSender, ConfigManager.MB_WORLD_GREETING.getValue());
             return;

src/engine/gameManager/CombatManager.java

@@ -301,17 +301,6 @@ public enum CombatManager {
             if (target == null)
                 return 0;
 
-            //pet to assist in attacking target
-            if(abstractCharacter.getObjectType().equals(GameObjectType.PlayerCharacter)){
-                PlayerCharacter attacker = (PlayerCharacter)abstractCharacter;
-                if(attacker.getPet() != null){
-                    Mob pet = attacker.getPet();
-                    if(pet.combatTarget == null && pet.assist)
-                        pet.setCombatTarget(attacker.combatTarget);
-                }
-            }
-
-
             //target must be valid type
 
             if (AbstractWorldObject.IsAbstractCharacter(target)) {
@@ -494,14 +483,6 @@ public enum CombatManager {
                     createTimer(abstractCharacter, slot, 20, true); //2 second for no weapon
                 else {
                     int wepSpeed = (int) (wb.getSpeed());
-                    if(abstractCharacter.getObjectType().equals(GameObjectType.PlayerCharacter)){
-                        PlayerCharacter pc = (PlayerCharacter)abstractCharacter;
-                        if(slot == 1){
-                            wepSpeed = (int) pc.combatStats.attackSpeedHandOne;
-                        }else{
-                            wepSpeed = (int) pc.combatStats.attackSpeedHandTwo;
-                        }
-                    }else {
 
                     if (weapon != null && weapon.getBonusPercent(ModType.WeaponSpeed, SourceType.None) != 0f) //add weapon speed bonus
                         wepSpeed *= (1 + weapon.getBonus(ModType.WeaponSpeed, SourceType.None));
@@ -511,7 +492,7 @@ public enum CombatManager {
 
                     if (wepSpeed < 10)
                         wepSpeed = 10; //Old was 10, but it can be reached lower with legit buffs,effects.
-                    }
+
                     createTimer(abstractCharacter, slot, wepSpeed, true);
                 }
 
@@ -555,20 +536,7 @@ public enum CombatManager {
 
             if (target == null)
                 return;
-            if(ac.getObjectType().equals(GameObjectType.PlayerCharacter)){
+
-                PlayerCharacter pc = (PlayerCharacter) ac;
-                pc.combatStats.calculateATR(true);
-                pc.combatStats.calculateATR(false);
-                if (mainHand) {
-                    atr = pc.combatStats.atrHandOne;
-                    minDamage = pc.combatStats.minDamageHandOne;
-                    maxDamage = pc.combatStats.maxDamageHandOne;
-                } else {
-                    atr = pc.combatStats.atrHandTwo;
-                    minDamage = pc.combatStats.minDamageHandTwo;
-                    maxDamage = pc.combatStats.maxDamageHandTwo;
-                }
-            }else {
             if (mainHand) {
                 atr = ac.getAtrHandOne();
                 minDamage = ac.getMinDamageHandOne();
@@ -578,7 +546,6 @@ public enum CombatManager {
                 minDamage = ac.getMinDamageHandTwo();
                 maxDamage = ac.getMaxDamageHandTwo();
             }
-            }
 
             boolean tarIsRat = false;
 
@@ -671,12 +638,7 @@ public enum CombatManager {
                 }
             } else {
                 AbstractCharacter tar = (AbstractCharacter) target;
-                if(tar.getObjectType().equals(GameObjectType.PlayerCharacter)){
-                    ((PlayerCharacter)tar).combatStats.calculateDefense();
-                    defense = ((PlayerCharacter)tar).combatStats.defense;
-                }else {
                 defense = tar.getDefenseRating();
-                }
                 handleRetaliate(tar, ac);   //Handle target attacking back if in combat and has no other target
             }
 
@@ -685,7 +647,7 @@ public enum CombatManager {
             //Get hit chance
 
             //int chance;
-            //float dif = atr - defense;
+            float dif = atr - defense;
 
             //if (dif > 100)
             //    chance = 94;
@@ -864,22 +826,6 @@ public enum CombatManager {
                 else
                     damage = calculateDamage(ac, tarAc, minDamage, maxDamage, damageType, resists);
 
-                if(weapon != null && weapon.effects != null){
-                    float armorPierce = 0;
-                    for(Effect eff : weapon.effects.values()){
-                        for(AbstractEffectModifier mod : eff.getEffectModifiers()){
-                            if(mod.modType.equals(ModType.ArmorPiercing)){
-                                armorPierce += mod.minMod * (mod.getRamp() * eff.getTrains());
-                            }
-                        }
-                    }
-                    if(armorPierce > 0){
-                        damage *= 1 - armorPierce;
-                    }
-                }
-
-                //Resists.handleFortitude(tarAc,damageType,damage);
-
                 float d = 0f;
 
                 errorTrack = 12;
@@ -932,18 +878,27 @@ public enum CombatManager {
 
                 if (weapon != null && tarAc != null && tarAc.isAlive()) {
 
-                    if(weapon.effects != null){
+                    ConcurrentHashMap<String, Effect> effects = weapon.getEffects();
-                        for (Effect eff : weapon.effects.values()){
+
-                            for(AbstractEffectModifier mod : eff.getEffectModifiers()){
+                    for (Effect eff : effects.values()) {
-                                if(mod.modType.equals(ModType.WeaponProc)){
+                        if (eff == null)
+                            continue;
+
+                        HashSet<AbstractEffectModifier> aems = eff.getEffectModifiers();
+
+                        if (aems != null) {
+                            for (AbstractEffectModifier aem : aems) {
+
+                                if (!tarAc.isAlive())
+                                    break;
+
+                                if (aem instanceof WeaponProcEffectModifier) {
+
                                     int procChance = ThreadLocalRandom.current().nextInt(100);
-                                    if (procChance < MBServerStatics.PROC_CHANCE) {
+
-                                        try {
+                                    if (procChance < MBServerStatics.PROC_CHANCE)
-                                            ((WeaponProcEffectModifier) mod).applyProc(ac, target);
+                                        ((WeaponProcEffectModifier) aem).applyProc(ac, target);
-                                        }catch(Exception e){
+
-                                            Logger.error(eff.getName() + " Failed To Cast Proc");
-                                        }
-                                    }
                                 }
                             }
                         }
@@ -1085,11 +1040,9 @@ public enum CombatManager {
 
         //calculate resists in if any
 
-
-
         if (resists != null)
-            damage = resists.getResistedDamage(source, target, damageType, damage, 0);
+            return resists.getResistedDamage(source, target, damageType, damage, 0);
-
+        else
             return damage;
     }
 
@@ -1244,14 +1197,6 @@ public enum CombatManager {
 
     private static boolean testPassive(AbstractCharacter source, AbstractCharacter target, String type) {
 
-        if(target.getBonuses() != null)
-            if(target.getBonuses().getBool(ModType.Stunned, SourceType.None))
-                return false;
-
-        if(source.getBonuses() != null)
-            if(source.getBonuses().getBool(ModType.IgnorePassiveDefense, SourceType.None))
-                return false;
-
         float chance = target.getPassiveChance(type, source.getLevel(), true);
 
         if (chance == 0f)
@@ -1262,7 +1207,7 @@ public enum CombatManager {
         if (chance > 75f)
             chance = 75f;
 
-        int roll = ThreadLocalRandom.current().nextInt(1,100);
+        int roll = ThreadLocalRandom.current().nextInt(100);
 
         return roll < chance;
 
@@ -1440,9 +1385,9 @@ public enum CombatManager {
 
                 Resists resists = ac.getResists();
 
-                if (resists != null) {
+                if (resists != null)
                     amount = resists.getResistedDamage(target, ac, ds.getDamageType(), amount, 0);
-                }
+
                 total += amount;
             }
 
@@ -1525,21 +1470,18 @@ public enum CombatManager {
             ((AbstractCharacter) awo).getCharItemManager().damageRandomArmor(1);
     }
 
-    public static boolean LandHit(int ATR, int DEF){
+    public static boolean LandHit(int C5, int D5){
 
-        //float chance = (ATR-((ATR+DEF) * 0.315f)) / ((DEF-((ATR+DEF) * 0.315f)) + (ATR-((ATR+DEF) * 0.315f)));
+        float chance = (C5-((C5+D5)*.315f)) / ((D5-((C5+D5)*.315f)) + (C5-((C5+D5)*.315f)));
-        //float convertedChance = chance * 100;
+        int convertedChance = Math.round(chance * 100);
+        //convertedChance = Math.max(5, Math.min(95, convertedChance));
 
         int roll = ThreadLocalRandom.current().nextInt(101);
 
-        //if(roll <= 5)//always 5% chance to miss
+        if(roll < 5)//always 5% chance ot miss
-        //    return false;
+            return false;
 
-        //if(roll >= 95)//always 5% chance to hit
+        return roll <= convertedChance;
-        //    return true;
-
-        float chance = PlayerCombatStats.getHitChance(ATR,DEF);
-        return chance >= roll;
     }
 
     public static boolean specialCaseHitRoll(int powerID){

src/engine/gameManager/ConfigManager.java

@@ -98,8 +98,7 @@ public enum ConfigManager {
     MB_MAGICBOT_FORTOFIX,
     MB_MAGICBOT_RECRUIT,
     MB_MAGICBOT_MAGICBOX,
-    MB_MAGICBOT_ADMINLOG,
+    MB_MAGICBOT_ADMINLOG;
-    MB_WORLD_BOXLIMIT;
 
     // Map to hold our config pulled in from the environment
     // We also use the config to point to the current message pump

src/engine/gameManager/DevCmdManager.java

@@ -177,11 +177,6 @@ public enum DevCmdManager {
             return false;
         }
 
-        if(!pcSender.getTimestamps().containsKey("DEVCOMMAND"))
-            pcSender.getTimestamps().put("DEVCOMMAND",System.currentTimeMillis() - 1500L);
-        else if(System.currentTimeMillis() - pcSender.getTimestamps().get("DEVCOMMAND") < 1000L)
-            return false;
-
         //kill any commands not available to everyone on production server
         //only admin level can run dev commands on production
         boolean playerAllowed = false;
@@ -194,20 +189,6 @@ public enum DevCmdManager {
                 case "gimme":
                 case "goto":
                 case "teleportmode":
-                case "printbonuses":
-                    playerAllowed = true;
-                    if (!a.status.equals(Enum.AccountStatus.ADMIN))
-                        target = pcSender;
-                    break;
-            }
-        }else{
-            switch (adc.getMainCmdString()) {
-                case "printresists":
-                case "printstats":
-                case "printskills":
-                case "printpowers":
-                case "printbonuses":
-                //case "gimme":
                     playerAllowed = true;
                     if (!a.status.equals(Enum.AccountStatus.ADMIN))
                         target = pcSender;

src/engine/gameManager/MovementManager.java

@@ -67,10 +67,8 @@ public enum MovementManager {
             return;
 
         if (toMove.getObjectType().equals(GameObjectType.PlayerCharacter)) {
-            if (((PlayerCharacter) toMove).isCasting()) {
+            if (((PlayerCharacter) toMove).isCasting())
-                ((PlayerCharacter) toMove).updateLocation();
+                ((PlayerCharacter) toMove).update(false);
-                ((PlayerCharacter) toMove).updateMovementState();
-            }
         }
 
 
@@ -410,9 +408,7 @@ public enum MovementManager {
             if (bonus.getBool(ModType.Stunned, SourceType.None) || bonus.getBool(ModType.CannotMove, SourceType.None))
                 continue;
 
-            //member.update(false);
+            member.update(false);
-            member.updateLocation();
-            member.updateMovementState();
 
 
             // All checks passed, let's move the player

src/engine/gameManager/PowersManager.java

@@ -10,7 +10,6 @@ package engine.gameManager;
 
 import engine.Enum.*;
 import engine.InterestManagement.HeightMap;
-import engine.InterestManagement.InterestManager;
 import engine.InterestManagement.WorldGrid;
 import engine.db.handlers.dbEffectsBaseHandler;
 import engine.db.handlers.dbPowerHandler;
@@ -166,20 +165,12 @@ public enum PowersManager {
 
         PlayerCharacter pc = SessionManager.getPlayerCharacter(origin);
 
-        if(pc == null)
-            return;
-
         if(!pc.isFlying() && powersBaseByToken.get(msg.getPowerUsedID()) != null && powersBaseByToken.get(msg.getPowerUsedID()).isSpell) //cant be sitting if flying
             CombatManager.toggleSit(false,origin);
 
         if(pc.isMoving())
             pc.stopMovement(pc.getMovementLoc());
 
-        if(msg.getPowerUsedID() == 429429978){
-            applyPower(origin.getPlayerCharacter(),origin.getPlayerCharacter(),origin.getPlayerCharacter().getLoc(),429429978,msg.getNumTrains(),false);
-            return;
-        }
-
         if (usePowerA(msg, origin, sendCastToSelf)) {
             // Cast failed for some reason, reset timer
 
@@ -206,8 +197,7 @@ public enum PowersManager {
         msg.setUnknown04(1);
 
         if (useMobPowerA(msg, caster)) {
-            if(pb.token == -1994153779)
+            //sendMobPowerMsg(caster,2,msg); //Lol wtf was i thinking sending msg's to mobs... ZZZZ
-                InterestManager.setObjectDirty(caster);
         }
     }
 
@@ -226,16 +216,16 @@ public enum PowersManager {
             City city = ZoneManager.getCityAtLocation(playerCharacter.loc);
             if (city == null) {
                 failed = true;
-            }//else{
+            }else{
-             //   Bane bane = city.getBane();
+                Bane bane = city.getBane();
-             //   if (bane == null) {
+                if (bane == null) {
-             //       failed = true;
+                    failed = true;
-             //   }else{
+                }else{
-             //       if(!bane.getSiegePhase().equals(SiegePhase.WAR)){
+                    if(!bane.getSiegePhase().equals(SiegePhase.WAR)){
-             //           failed = true;
+                        failed = true;
-             //       }
+                    }
-             //   }
+                }
-            //}
+            }
             if(failed){
                 //check to see if we are at an active mine
                 Zone zone = ZoneManager.findSmallestZone(playerCharacter.loc);
@@ -252,16 +242,9 @@ public enum PowersManager {
                 }
             }
 
-            if(failed) {
+            if(failed)
-                playerCharacter.setIsCasting(false);
-
-                RecyclePowerMsg recyclePowerMsg = new RecyclePowerMsg(msg.getPowerUsedID());
-                Dispatch dispatch = Dispatch.borrow(playerCharacter, recyclePowerMsg);
-                DispatchMessage.dispatchMsgDispatch(dispatch, DispatchChannel.PRIMARY);
-
                 return false;
         }
-        }
 
         if (MBServerStatics.POWERS_DEBUG) {
             ChatManager.chatSayInfo(
@@ -346,7 +329,6 @@ public enum PowersManager {
 
 
         // Check powers for normal users
-        if(msg.getPowerUsedID() != 421084024) {
         if (playerCharacter.getPowers() == null || !playerCharacter.getPowers().containsKey(msg.getPowerUsedID()))
             if (!playerCharacter.isCSR()) {
                 if (!MBServerStatics.POWERS_DEBUG) {
@@ -357,7 +339,7 @@ public enum PowersManager {
                 }
             } else
                 CSRCast = true;
-        }
+
         // get numTrains for power
         int trains = msg.getNumTrains();
 
@@ -510,23 +492,6 @@ public enum PowersManager {
                 }
             }
 
-            if(!passed){
-                if (playerCharacter.getRace().getName().contains("Shade")) {
-                    if(playerCharacter.getHidden() > 0){
-                        switch(msg.getPowerUsedID()){
-                            case -1851459567:
-                            case 2094922127:
-                            case -355707373:
-                            case 246186475:
-                            case 666419835:
-                            case 1480354319:
-                                passed = true;
-                                break;
-                        }
-                    }
-                }
-            }
-
             if (!passed)
                 return true;
         }
@@ -825,36 +790,15 @@ public enum PowersManager {
         if (playerCharacter == null || msg == null)
             return;
 
-
+        if(msg.getPowerUsedID() == 429005674){ //bard sprint
-        //handle sprint for bard sprint
+            //use sprint instead of ballad of beregund the bold
-        if(msg.getPowerUsedID() == 429005674){
+            //applyPower(playerCharacter,playerCharacter,playerCharacter.loc,429611355,msg.getNumTrains(),false);
             msg.setPowerUsedID(429611355);
         }
-
+        if(msg.getPowerUsedID() == 429494441) {//wildkins chase
-        //handle root and snare break for wildkin's chase
-        if(msg.getPowerUsedID() == 429494441) {
             playerCharacter.removeEffectBySource(EffectSourceType.Root,40,true);
             playerCharacter.removeEffectBySource(EffectSourceType.Snare,40,true);
         }
-
-        //handle power block portion for shade hide
-        if(playerCharacter.getRace().getName().contains("Shade")) {
-            if (msg.getPowerUsedID() == 429407306 || msg.getPowerUsedID() == 429495514) {
-                int trains = msg.getNumTrains() - 1;
-                if (trains < 1)
-                    trains = 1;
-                applyPower(playerCharacter, playerCharacter, playerCharacter.loc, 429397210, trains, false);
-                playerCharacter.removeEffectBySource(EffectSourceType.Invisibility,40,true);
-                applyPower(playerCharacter, playerCharacter, playerCharacter.loc, msg.getPowerUsedID(), msg.getNumTrains(), false);
-            }
-        }
-        if(msg.getTargetType() == GameObjectType.PlayerCharacter.ordinal()) {
-            PlayerCharacter target = PlayerCharacter.getPlayerCharacter(msg.getTargetID());
-            if (msg.getPowerUsedID() == 429601664)
-                if(target.getPromotionClassID() != 2516)
-                    PlayerCharacter.getPlayerCharacter(msg.getTargetID()).removeEffectBySource(EffectSourceType.Transform, msg.getNumTrains(), true);
-        }
-
         if (playerCharacter.isCasting()) {
             playerCharacter.update(false);
             playerCharacter.updateStamRegen(-100);
@@ -2465,13 +2409,6 @@ public enum PowersManager {
                     dodgeMsg.setTargetID(awo.getObjectUUID());
                     sendPowerMsg(pc, 4, dodgeMsg);
                     return true;
-                } else if (testPassive(pc, tarAc, "Block")) {
-                    // Dodge fired, send dodge message
-                    PerformActionMsg dodgeMsg = new PerformActionMsg(msg);
-                    dodgeMsg.setTargetType(awo.getObjectType().ordinal());
-                    dodgeMsg.setTargetID(awo.getObjectUUID());
-                    sendPowerMsg(pc, 4, dodgeMsg);
-                    return true;
                 }
             }
             return false;
@@ -2519,12 +2456,7 @@ public enum PowersManager {
             if (AbstractWorldObject.IsAbstractCharacter(awo)) {
                 AbstractCharacter tarAc = (AbstractCharacter) awo;
                 // Handle Dodge passive
-                boolean passiveFired = false;
+                return testPassive(caster, tarAc, "Dodge");
-                passiveFired =  testPassive(caster, tarAc, "Dodge");
-                if(!passiveFired)
-                    passiveFired =  testPassive(caster, tarAc, "Block");
-
-                return passiveFired;
             }
             return false;
         } else
@@ -3026,9 +2958,6 @@ public enum PowersManager {
             case 429517915:
             case 431854842:
             case 429767544:
-            case 429502507:
-            case 428398816:
-            case 429446315:
                 return false;
         }
         return true;

src/engine/gameManager/SimulationManager.java

@@ -93,10 +93,13 @@ public enum SimulationManager {
         }
         try {
 
-            if ((_updatePulseTime != 0) && (System.currentTimeMillis() > _updatePulseTime))
+            if ((_updatePulseTime != 0)
+                    && (System.currentTimeMillis() > _updatePulseTime))
                 pulseUpdate();
         } catch (Exception e) {
-            Logger.error("Fatal error in Update Pulse: DISABLED");
+            Logger.error(
+                    "Fatal error in Update Pulse: DISABLED");
+            //  _runegatePulseTime = 0;
         }
 
         try {
@@ -157,11 +160,7 @@ public enum SimulationManager {
 
             if (player == null)
                 continue;
-            try {
             player.update(false);
-            }catch(Exception e){
-
-            }
         }
 
         _updatePulseTime = System.currentTimeMillis() + 500;

src/engine/job/AbstractJob.java

@@ -68,7 +68,7 @@ public abstract class AbstractJob implements Runnable {
         this.markStopRunTime();
     }
 
-    public abstract void doJob();
+    protected abstract void doJob();
 
     public void executeJob(String threadName) {
         this.workerID.set(threadName);

src/engine/job/AbstractScheduleJob.java

@@ -17,7 +17,7 @@ public abstract class AbstractScheduleJob extends AbstractJob {
     }
 
     @Override
-    public abstract void doJob();
+    protected abstract void doJob();
 
     public void cancelJob() {
         JobScheduler.getInstance().cancelScheduledJob(this);

src/engine/job/JobContainer.java

@@ -16,7 +16,7 @@ public class JobContainer implements Comparable<JobContainer> {
     final long timeOfExecution;
     final boolean noTimer;
 
-    public JobContainer(AbstractJob job, long timeOfExecution) {
+    JobContainer(AbstractJob job, long timeOfExecution) {
         if (job == null) {
             throw new IllegalArgumentException("No 'null' jobs allowed.");
         }

src/engine/job/JobThread.java

@@ -1,75 +0,0 @@
-package engine.job;
-
-import engine.server.world.WorldServer;
-import org.pmw.tinylog.Logger;
-
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.locks.ReentrantLock;
-
-public class JobThread implements Runnable {
-    private final AbstractJob currentJob;
-    private final ReentrantLock lock = new ReentrantLock();
-
-    private static Long nextThreadPrint;
-
-    public JobThread(AbstractJob job){
-        this.currentJob = job;
-    }
-
-    @Override
-    public void run() {
-        try {
-            if (this.currentJob != null) {
-                if (lock.tryLock(5, TimeUnit.SECONDS)) { // Timeout to prevent deadlock
-                    try {
-                        this.currentJob.doJob();
-                    } finally {
-                        lock.unlock();
-                    }
-                } else {
-                    Logger.warn("JobThread could not acquire lock in time, skipping job.");
-                }
-            }
-        } catch (Exception e) {
-            Logger.error(e);
-        }
-    }
-
-    public static void startJobThread(AbstractJob job){
-        JobThread jobThread = new JobThread(job);
-        Thread thread = new Thread(jobThread);
-        thread.setName("JOB THREAD: " + job.getWorkerID());
-        thread.start();
-
-       if(JobThread.nextThreadPrint == null){
-           JobThread.nextThreadPrint = System.currentTimeMillis();
-       }else{
-           if(JobThread.nextThreadPrint < System.currentTimeMillis()){
-               JobThread.tryPrintThreads();
-               JobThread.nextThreadPrint = System.currentTimeMillis() + 10000L;
-           }
-       }
-    }
-
-    public static void tryPrintThreads(){
-        ThreadGroup rootGroup = Thread.currentThread().getThreadGroup();
-        while (rootGroup.getParent() != null) {
-            rootGroup = rootGroup.getParent();
-        }
-
-        // Estimate the number of threads
-        int activeThreads = rootGroup.activeCount();
-
-        // Create an array to hold the threads
-        Thread[] threads = new Thread[activeThreads];
-
-        // Get the active threads
-        rootGroup.enumerate(threads, true);
-
-        int availableThreads = Runtime.getRuntime().availableProcessors();
-
-        // Print the count
-        if(threads.length > 30)
-            Logger.info("Total threads in application: " + threads.length + " / " + availableThreads);
-    }
-}

src/engine/job/JobWorker.java

@@ -58,13 +58,10 @@ public class JobWorker extends ControlledRunnable {
             } else {
 
                 // execute the new job..
-                //this.currentJob.executeJob(this.getThreadName());
+                this.currentJob.executeJob(this.getThreadName());
-                if(this.currentJob != null) {
-                    JobThread.startJobThread(this.currentJob);
                 this.currentJob = null;
             }
-            }
+
-            Thread.yield();
         }
         return true;
     }

src/engine/jobs/AbstractEffectJob.java

@@ -45,7 +45,7 @@ public abstract class AbstractEffectJob extends AbstractScheduleJob {
     }
 
     @Override
-    public abstract void doJob();
+    protected abstract void doJob();
 
     @Override
     protected abstract void _cancelJob();

src/engine/jobs/ActivateBaneJob.java

@@ -29,7 +29,7 @@ public class ActivateBaneJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         City city;
 

src/engine/jobs/AttackJob.java

@@ -27,7 +27,7 @@ public class AttackJob extends AbstractJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         CombatManager.doCombat(this.source, slot);
     }
 

src/engine/jobs/BaneDefaultTimeJob.java

@@ -24,7 +24,7 @@ public class BaneDefaultTimeJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         //bane already set.
         if (this.bane.getLiveDate() != null) {

src/engine/jobs/BasicScheduledJob.java

@@ -97,7 +97,7 @@ public class BasicScheduledJob extends AbstractJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         if (execution == null) {
             Logger.error("BasicScheduledJob executed with nothing to execute.");
             return;

src/engine/jobs/BonusCalcJob.java

@@ -22,7 +22,7 @@ public class BonusCalcJob extends AbstractJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         if (this.ac != null) {
             this.ac.applyBonuses();
 

src/engine/jobs/CSessionCleanupJob.java

@@ -22,7 +22,7 @@ public class CSessionCleanupJob extends AbstractJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         SessionManager.cSessionCleanup(secKey);
     }
 }

src/engine/jobs/ChangeAltitudeJob.java

@@ -27,7 +27,7 @@ public class ChangeAltitudeJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         if (this.ac != null)
             MovementManager.finishChangeAltitude(ac, targetAlt);
     }

src/engine/jobs/ChantJob.java

@@ -36,7 +36,7 @@ public class ChantJob extends AbstractEffectJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         if (this.aej == null || this.source == null || this.target == null || this.action == null || this.power == null || this.source == null || this.eb == null)
             return;
         PlayerBonuses bonuses = null;

src/engine/jobs/CloseGateJob.java

@@ -29,7 +29,7 @@ public class CloseGateJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         if (building == null) {
             Logger.error("Rungate building was null");

src/engine/jobs/DamageOverTimeJob.java

@@ -37,7 +37,7 @@ public class DamageOverTimeJob extends AbstractEffectJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         if (this.target.getObjectType().equals(GameObjectType.Building)
                 && ((Building) this.target).isVulnerable() == false) {
             _cancelJob();
@@ -60,8 +60,6 @@ public class DamageOverTimeJob extends AbstractEffectJob {
 
         if (this.iteration < 0) {
             PowersManager.finishEffectTime(this.source, this.target, this.action, this.trains);
-            if (AbstractWorldObject.IsAbstractCharacter(source))
-                eb.startEffect((AbstractCharacter) this.source, this.target, this.trains, this);
             return;
         }
         this.skipSendEffect = true;

src/engine/jobs/DatabaseUpdateJob.java

@@ -28,7 +28,7 @@ public class DatabaseUpdateJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         if (this.ago == null)
             return;
         ago.removeDatabaseJob(this.type, false);

src/engine/jobs/DebugTimerJob.java

@@ -29,7 +29,7 @@ public class DebugTimerJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         if (this.pc == null) {
             return;
         }

src/engine/jobs/DeferredPowerJob.java

@@ -37,7 +37,7 @@ public class DeferredPowerJob extends AbstractEffectJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         //Power ended with no attack, cancel weapon power boost
         if (this.source != null && this.source instanceof PlayerCharacter) {
             ((PlayerCharacter) this.source).setWeaponPower(null);

src/engine/jobs/DisconnectJob.java

@@ -22,7 +22,7 @@ public class DisconnectJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         if (this.origin != null) {
             this.origin.disconnect();
         }

src/engine/jobs/DoorCloseJob.java

@@ -28,7 +28,7 @@ public class DoorCloseJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         int doorNumber;
 

src/engine/jobs/EndFearJob.java

@@ -22,7 +22,7 @@ public class EndFearJob extends AbstractEffectJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         //cancel fear for mob.
 

src/engine/jobs/FinishCooldownTimeJob.java

@@ -26,7 +26,7 @@ public class FinishCooldownTimeJob extends AbstractJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         PowersManager.finishCooldownTime(this.msg, this.pc);
     }
 }

src/engine/jobs/FinishEffectTimeJob.java

@@ -22,7 +22,7 @@ public class FinishEffectTimeJob extends AbstractEffectJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         PowersManager.finishEffectTime(this.source, this.target, this.action, this.trains);
     }
 

src/engine/jobs/FinishRecycleTimeJob.java

@@ -26,7 +26,7 @@ public class FinishRecycleTimeJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         PowersManager.finishRecycleTime(this.msg, this.pc, false);
     }
 

src/engine/jobs/FinishSpireEffectJob.java

@@ -20,7 +20,7 @@ public class FinishSpireEffectJob extends AbstractEffectJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         PlayerCharacter pc = (PlayerCharacter) target;
 

src/engine/jobs/FinishSummonsJob.java

@@ -31,7 +31,7 @@ public class FinishSummonsJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         if (this.target == null)
             return;

src/engine/jobs/LoadEffectsJob.java

@@ -28,7 +28,7 @@ public class LoadEffectsJob extends AbstractJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         if (this.originToSend == null) {
             return;
         }

src/engine/jobs/LogoutCharacterJob.java

@@ -25,7 +25,7 @@ public class LogoutCharacterJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         server.logoutCharacter(this.pc);
     }
 

src/engine/jobs/NoTimeJob.java

@@ -19,7 +19,7 @@ public class NoTimeJob extends AbstractEffectJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
     }
 
     @Override

src/engine/jobs/PersistentAoeJob.java

@@ -40,7 +40,7 @@ public class PersistentAoeJob extends AbstractEffectJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         if (this.aej == null || this.source == null || this.action == null || this.power == null || this.source == null || this.eb == null)
             return;

src/engine/jobs/RefreshGroupJob.java

@@ -45,7 +45,7 @@ public class RefreshGroupJob extends AbstractJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         if (this.pc == null || this.origin == null || grp == null) {
             return;

src/engine/jobs/RemoveCorpseJob.java

@@ -22,7 +22,7 @@ public class RemoveCorpseJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         if (this.corpse != null)
             Corpse.removeCorpse(corpse, true);

src/engine/jobs/SiegeSpireWithdrawlJob.java

@@ -25,7 +25,7 @@ public class SiegeSpireWithdrawlJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         if (spire == null)
             return;

src/engine/jobs/StuckJob.java

@@ -30,7 +30,7 @@ public class StuckJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         Vector3fImmutable stuckLoc;
         Building building = null;

src/engine/jobs/SummonSendJob.java

@@ -27,7 +27,7 @@ public class SummonSendJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         if (this.source == null)
             return;

src/engine/jobs/TeleportJob.java

@@ -39,7 +39,7 @@ public class TeleportJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         if (this.pc == null || this.npc == null || this.origin == null)
             return;

src/engine/jobs/TrackJob.java

@@ -35,7 +35,7 @@ public class TrackJob extends AbstractEffectJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         if (this.tpa == null || this.target == null || this.action == null || this.source == null || this.eb == null || !(this.source instanceof PlayerCharacter))
             return;

src/engine/jobs/TransferStatOTJob.java

@@ -29,7 +29,7 @@ public class TransferStatOTJob extends AbstractEffectJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         if (this.dot == null || this.target == null || this.action == null || this.source == null || this.eb == null || this.action == null || this.power == null)
             return;
         if (!this.target.isAlive()) {

src/engine/jobs/UpdateGroupJob.java

@@ -26,7 +26,7 @@ public class UpdateGroupJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         if (this.group == null)
             return;

src/engine/jobs/UpgradeBuildingJob.java

@@ -22,7 +22,7 @@ public class UpgradeBuildingJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
 
         // Must have a building to rank!

src/engine/jobs/UpgradeNPCJob.java

@@ -27,7 +27,7 @@ public class UpgradeNPCJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         int newRank;
 

src/engine/jobs/UseItemJob.java

@@ -34,7 +34,7 @@ public class UseItemJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         PowersManager.finishApplyPower(ac, target, Vector3fImmutable.ZERO, pb, trains, liveCounter);
     }
 

src/engine/jobs/UseMobPowerJob.java

@@ -35,7 +35,7 @@ public class UseMobPowerJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         PowersManager.finishUseMobPower(this.msg, this.caster, casterLiveCounter, targetLiveCounter);
     }
 

src/engine/jobs/UsePowerJob.java

@@ -35,7 +35,7 @@ public class UsePowerJob extends AbstractScheduleJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         PowersManager.finishUsePower(this.msg, this.pc, casterLiveCounter, targetLiveCounter);
     }
 

src/engine/mobileAI/MobAI.java

@@ -9,7 +9,6 @@
 package engine.mobileAI;
 
 import engine.Enum;
-import engine.InterestManagement.InterestManager;
 import engine.InterestManagement.WorldGrid;
 import engine.gameManager.*;
 import engine.math.Vector3f;
@@ -49,19 +48,18 @@ public class MobAI {
                 return;
             }
 
-            //mob casting disabled
+            if (target.getObjectType() == Enum.GameObjectType.PlayerCharacter && canCast(mob)) {
-            //if (target.getObjectType() == Enum.GameObjectType.PlayerCharacter && canCast(mob)) {
 
-                //if (mob.isPlayerGuard() == false && MobCast(mob)) {
+                if (mob.isPlayerGuard() == false && MobCast(mob)) {
-                //    mob.updateLocation();
+                    mob.updateLocation();
-                //    return;
+                    return;
-                //}
+                }
 
-                //if (mob.isPlayerGuard() == true && GuardCast(mob)) {
+                if (mob.isPlayerGuard() == true && GuardCast(mob)) {
-                //    mob.updateLocation();
+                    mob.updateLocation();
-                //    return;
+                    return;
-                //}
+                }
-            //}
+            }
 
             if (!CombatUtilities.inRangeToAttack(mob, target))
                 return;
@@ -107,10 +105,6 @@ public class MobAI {
                 return;
             }
 
-            if(target.getPet() != null && target.getPet().isAlive()){
-                mob.setCombatTarget(target.getPet());
-            }
-
             if (mob.BehaviourType.callsForHelp)
                 MobCallForHelp(mob);
 
@@ -161,12 +155,6 @@ public class MobAI {
                 if (target.getPet().getCombatTarget() == null && target.getPet().assist == true)
                     target.getPet().setCombatTarget(mob);
 
-            try{
-                InterestManager.forceLoad(mob);
-            }catch(Exception e){
-
-            }
-
         } catch (Exception e) {
             Logger.info(mob.getObjectUUID() + " " + mob.getName() + " Failed At: AttackPlayer" + " " + e.getMessage());
         }
@@ -189,7 +177,7 @@ public class MobAI {
 
             if (playercity != null)
                 for (Mob guard : playercity.getParent().zoneMobSet)
-                    if (guard.BehaviourType != null && guard.BehaviourType.equals(Enum.MobBehaviourType.GuardCaptain))
+                    if (guard.BehaviourType != null && guard.BehaviourType.ordinal() == Enum.MobBehaviourType.GuardCaptain.ordinal())
                         if (guard.getCombatTarget() == null && guard.getGuild() != null && mob.getGuild() != null && !guard.getGuild().equals(mob.getGuild()))
                             guard.setCombatTarget(mob);
 
@@ -264,9 +252,6 @@ public class MobAI {
                     target.setCombatTarget(mob);
                 }
             }
-
-            if(target.combatTarget == null)
-                target.setCombatTarget(mob);
         } catch (Exception e) {
             Logger.info(mob.getObjectUUID() + " " + mob.getName() + " Failed At: AttackMob" + " " + e.getMessage());
         }
@@ -335,12 +320,6 @@ public class MobAI {
             if (mob == null)
                 return false;
 
-            if (mob.nextCastTime == 0)
-                mob.nextCastTime = System.currentTimeMillis() - 1000L;
-
-            if(mob.nextCastTime > System.currentTimeMillis())
-                return false;
-
             if(mob.isPlayerGuard){
 
                 int contractID = 0;
@@ -361,6 +340,8 @@ public class MobAI {
                 mob.setCombatTarget(null);
                 return false;
             }
+            if (mob.nextCastTime == 0)
+                mob.nextCastTime = System.currentTimeMillis();
 
             return mob.nextCastTime <= System.currentTimeMillis();
 
@@ -419,9 +400,6 @@ public class MobAI {
 
             PowersBase mobPower = PowersManager.getPowerByToken(powerToken);
 
-            if(mobPower.powerCategory.equals(Enum.PowerCategoryType.DEBUFF))
-                return false;
-
             //check for hit-roll
 
             if (mobPower.requiresHitRoll)
@@ -445,9 +423,9 @@ public class MobAI {
                 msg.setUnknown04(2);
 
                 PowersManager.finishUseMobPower(msg, mob, 0, 0);
-                long delay = 20000L;
+                long randomCooldown = (long)((ThreadLocalRandom.current().nextInt(10,15) * 1000) * MobAIThread.AI_CAST_FREQUENCY);
-                mob.nextCastTime = System.currentTimeMillis() + delay;
 
+                mob.nextCastTime = System.currentTimeMillis() + randomCooldown;
                 return true;
             }
         } catch (Exception e) {
@@ -570,6 +548,7 @@ public class MobAI {
                 PowersManager.finishUseMobPower(msg, mob, 0, 0);
 
                 long randomCooldown = (long)((ThreadLocalRandom.current().nextInt(10,15) * 1000) * MobAIThread.AI_CAST_FREQUENCY);
+                mob.nextCastTime = System.currentTimeMillis() + randomCooldown;
                 return true;
             }
         } catch (Exception e) {
@@ -726,8 +705,8 @@ public class MobAI {
                     DefaultLogic(mob);
                     break;
             }
-            //if(mob.isAlive())
+            if(mob.isAlive())
-            //    RecoverHealth(mob);
+                RecoverHealth(mob);
         } catch (Exception e) {
             Logger.info(mob.getObjectUUID() + " " + mob.getName() + " Failed At: DetermineAction" + " " + e.getMessage());
         }
@@ -737,10 +716,6 @@ public class MobAI {
 
         try {
 
-            //do not switch target if you already have one, dropping out of range is handled elsewhere
-            if(aiAgent.combatTarget != null)
-                return;
-
             //looks for and sets mobs combatTarget
 
             if (!aiAgent.isAlive())
@@ -989,6 +964,7 @@ public class MobAI {
                     PowersBase recall = PowersManager.getPowerByToken(-1994153779);
                     PowersManager.useMobPower(mob, mob, recall, 40);
                     mob.setCombatTarget(null);
+
                     if (mob.BehaviourType.ordinal() == Enum.MobBehaviourType.GuardCaptain.ordinal() && mob.isAlive()) {
 
                         //guard captain pulls his minions home with him
@@ -1018,11 +994,6 @@ public class MobAI {
 
         try {
 
-            if(mob.combatTarget != null && mob.combatTarget.getObjectType().equals(Enum.GameObjectType.PlayerCharacter) && !mob.canSee((PlayerCharacter)mob.combatTarget)){
-                mob.setCombatTarget(null);
-                return;
-            }
-
             float rangeSquared = mob.getRange() * mob.getRange();
             float distanceSquared = mob.getLoc().distanceSquared2D(mob.getCombatTarget().getLoc());
 
@@ -1108,17 +1079,17 @@ public class MobAI {
             if (mob.getCombatTarget() == null)
                 CheckForPlayerGuardAggro(mob);
 
-            //AbstractWorldObject newTarget = ChangeTargetFromHateValue(mob);
+            AbstractWorldObject newTarget = ChangeTargetFromHateValue(mob);
 
-            //if (newTarget != null) {
+            if (newTarget != null) {
 
-            //    if (newTarget.getObjectType().equals(Enum.GameObjectType.PlayerCharacter)) {
+                if (newTarget.getObjectType().equals(Enum.GameObjectType.PlayerCharacter)) {
-            //        if (GuardCanAggro(mob, (PlayerCharacter) newTarget))
+                    if (GuardCanAggro(mob, (PlayerCharacter) newTarget))
-            //            mob.setCombatTarget(newTarget);
+                        mob.setCombatTarget(newTarget);
-            //    } else
+                } else
-            //        mob.setCombatTarget(newTarget);
+                    mob.setCombatTarget(newTarget);
 
-            //}
+            }
             CheckMobMovement(mob);
             CheckForAttack(mob);
         } catch (Exception e) {
@@ -1170,10 +1141,6 @@ public class MobAI {
                 if (ZoneManager.getSeaFloor().zoneMobSet.contains(mob))
                     mob.killCharacter("no owner");
 
-            if(!mob.isSiege())
-                mob.BehaviourType.canRoam = true;
-
-
             if (MovementUtilities.canMove(mob) && mob.BehaviourType.canRoam)
                 CheckMobMovement(mob);
 
@@ -1204,24 +1171,25 @@ public class MobAI {
         try {
 
             //check for players that can be aggroed if mob is agressive and has no target
-            if (mob.getCombatTarget() != null && mob.playerAgroMap.containsKey(mob.getCombatTarget().getObjectUUID()) == false && !mob.getCombatTarget().getObjectType().equals(Enum.GameObjectType.Mob))
+
+            if (mob.getCombatTarget() != null && mob.playerAgroMap.containsKey(mob.getCombatTarget().getObjectUUID()) == false)
                 mob.setCombatTarget(null);
 
-            //if (mob.BehaviourType.isAgressive) {
+            if (mob.BehaviourType.isAgressive) {
 
-             //   AbstractWorldObject newTarget = ChangeTargetFromHateValue(mob);
+                AbstractWorldObject newTarget = ChangeTargetFromHateValue(mob);
 
-             //   if (newTarget != null)
+                if (newTarget != null)
-             //       mob.setCombatTarget(newTarget);
+                    mob.setCombatTarget(newTarget);
-            //    else {
+                else {
-            //        if (mob.getCombatTarget() == null) {
+                    if (mob.getCombatTarget() == null) {
-            //            if (mob.BehaviourType == Enum.MobBehaviourType.HamletGuard)
+                        if (mob.BehaviourType == Enum.MobBehaviourType.HamletGuard)
-             //               SafeGuardAggro(mob);  //safehold guard
+                            SafeGuardAggro(mob);  //safehold guard
-            //            else
+                        else
-            //                CheckForAggro(mob);   //normal aggro
+                            CheckForAggro(mob);   //normal aggro
-            //        }
+                    }
-            //    }
+                }
-            //}
+            }
 
             //check if mob can move for patrol or moving to target
 
@@ -1233,7 +1201,6 @@ public class MobAI {
             if (!mob.BehaviourType.isWimpy && mob.getCombatTarget() != null)
                 CheckForAttack(mob);
 
-
         } catch (Exception e) {
             Logger.info(mob.getObjectUUID() + " " + mob.getName() + " Failed At: DefaultLogic" + " " + e.getMessage());
         }

src/engine/mobileAI/Threads/MobRespawnThread.java

@@ -43,14 +43,14 @@ public class MobRespawnThread implements Runnable {
                 if (zones != null) {
                     for (Zone zone : zones) {
                         synchronized (zone) { // Optional: Synchronize on zone
-                            if (!Zone.respawnQue.isEmpty() && Zone.lastRespawn + RESPAWN_INTERVAL < System.currentTimeMillis()) {
+                            if (!zone.respawnQue.isEmpty() &&
+                                    zone.lastRespawn + RESPAWN_INTERVAL < System.currentTimeMillis()) {
 
-                                Mob respawner = Zone.respawnQue.iterator().next();
+                                Mob respawner = zone.respawnQue.iterator().next();
                                 if (respawner != null) {
                                     respawner.respawn();
-                                    Zone.respawnQue.remove(respawner);
+                                    zone.respawnQue.remove(respawner);
-                                    Zone.lastRespawn = System.currentTimeMillis();
+                                    zone.lastRespawn = System.currentTimeMillis();
-                                    Thread.sleep(100);
                                 }
                             }
                         }

src/engine/mobileAI/utilities/CombatUtilities.java

@@ -101,10 +101,9 @@ public class CombatUtilities {
         if (!target.isAlive())
             return;
 
-        if (AbstractWorldObject.IsAbstractCharacter(target)) {
+        if (AbstractWorldObject.IsAbstractCharacter(target))
-            //damage = Resists.handleFortitude((AbstractCharacter) target,DamageType.Crush,damage);
             trueDamage = ((AbstractCharacter) target).modifyHealth(-damage, agent, false);
-        }else if (target.getObjectType() == GameObjectType.Building)
+        else if (target.getObjectType() == GameObjectType.Building)
             trueDamage = ((Building) target).modifyHealth(-damage, agent);
 
         //Don't send 0 damage kay thanx.
@@ -148,17 +147,13 @@ public class CombatUtilities {
         }
         switch (target.getObjectType()) {
             case PlayerCharacter:
-                PlayerCharacter pc = (PlayerCharacter)target;
+                defense = ((AbstractCharacter) target).getDefenseRating();
-                pc.combatStats.calculateDefense();
-                defense = pc.combatStats.defense;
                 break;
             case Mob:
 
                 Mob mob = (Mob) target;
                 if (mob.isSiege())
                     defense = atr;
-                else
-                    defense = ((Mob) target).mobBase.getDefense();
                 break;
             case Building:
                 return false;
@@ -201,10 +196,12 @@ public class CombatUtilities {
                 return;
 
         int anim = 75;
+        float speed;
 
-        //handle the retaliate here because even if the mob misses you can still retaliate
+        if (mainHand)
-        if (AbstractWorldObject.IsAbstractCharacter(target))
+            speed = agent.getSpeedHandOne();
-            CombatManager.handleRetaliate((AbstractCharacter) target, agent);
+        else
+            speed = agent.getSpeedHandTwo();
 
         DamageType dt = DamageType.Crush;
 
@@ -286,6 +283,11 @@ public class CombatUtilities {
             if (((Mob) target).isSiege())
                 return;
 
+        //handle the retaliate
+
+        if (AbstractWorldObject.IsAbstractCharacter(target))
+            CombatManager.handleRetaliate((AbstractCharacter) target, agent);
+
         if (target.getObjectType() == GameObjectType.Mob) {
             Mob targetMob = (Mob) target;
             if (targetMob.isSiege())
@@ -320,9 +322,9 @@ public class CombatUtilities {
             damage = calculateMobDamage(agent);
         }
         if (AbstractWorldObject.IsAbstractCharacter(target)) {
-            //if (((AbstractCharacter) target).isSit()) {
+            if (((AbstractCharacter) target).isSit()) {
-            //    damage *= 2.5f; //increase damage if sitting
+                damage *= 2.5f; //increase damage if sitting
-            //}
+            }
             return (int) (((AbstractCharacter) target).getResists().getResistedDamage(agent, (AbstractCharacter) target, dt, damage, 0));
         }
         if (target.getObjectType() == GameObjectType.Building) {

src/engine/net/AbstractConnection.java

@@ -38,7 +38,7 @@ public abstract class AbstractConnection implements
     protected final AtomicBoolean execTask = new AtomicBoolean(false);
     protected final ReentrantLock writeLock = new ReentrantLock();
     protected final ReentrantLock readLock = new ReentrantLock();
-    public long lastMsgTime = System.currentTimeMillis();
+    protected long lastMsgTime = System.currentTimeMillis();
     protected long lastKeepAliveTime = System.currentTimeMillis();
     protected long lastOpcode = -1;
     protected ConcurrentLinkedQueue<ByteBuffer> outbox = new ConcurrentLinkedQueue<>();

src/engine/net/AbstractConnectionManager.java

@@ -87,7 +87,6 @@ public abstract class AbstractConnectionManager extends ControlledRunnable {
 
                 this.processChangeRequests();
                 this.auditSocketChannelToConnectionMap();
-                //this.selector.select();
                 this.selector.select(250L);
                 this.processNewEvents();
 
@@ -665,7 +664,7 @@ public abstract class AbstractConnectionManager extends ControlledRunnable {
         }
 
         @Override
-        public void doJob() {
+        protected void doJob() {
             if (runStatus) {
                 this.ac.connMan.receive(sk);
                 this.ac.execTask.compareAndSet(true, false);
@@ -694,7 +693,7 @@ public abstract class AbstractConnectionManager extends ControlledRunnable {
         }
 
         @Override
-        public void doJob() {
+        protected void doJob() {
             if (runStatus) {
                 this.ac.connMan.sendFinish(sk);
                 this.ac.execTask.compareAndSet(true, false);

src/engine/net/CheckNetMsgFactoryJob.java

@@ -23,7 +23,7 @@ public class CheckNetMsgFactoryJob extends AbstractJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
         NetMsgFactory factory = conn.getFactory();
 
         // Make any/all msg possible

src/engine/net/ConnectionMonitorJob.java

@@ -26,7 +26,7 @@ public class ConnectionMonitorJob extends AbstractJob {
     }
 
     @Override
-    public void doJob() {
+    protected void doJob() {
 
         if (this.cnt >= 5) {
             this.connMan.auditSocketChannelToConnectionMap();

src/engine/net/client/ClientConnection.java

@@ -44,16 +44,9 @@ public class ClientConnection extends AbstractConnection {
     public ReentrantLock buyLock = new ReentrantLock();
     public boolean desyncDebug = false;
     public byte[] lastByteBuffer;
-    public long lastTargetSwitchTime;
     protected SessionID sessionID = null;
     private byte cryptoInitTries = 0;
 
-    public int strikes = 0;
-    public Long lastStrike = 0L;
-
-    public int finalStrikes = 0;
-    public long finalStrikeRefresh = 0L;
-
     public ClientConnection(ClientConnectionManager connMan,
                             SocketChannel sockChan) {
         super(connMan, sockChan, true);

src/engine/net/client/ClientMessagePump.java

@@ -29,7 +29,6 @@ import engine.objects.*;
 import engine.server.MBServerStatics;
 import engine.server.world.WorldServer;
 import engine.session.Session;
-import engine.util.KeyCloneAudit;
 import engine.util.StringUtils;
 import org.pmw.tinylog.Logger;
 
@@ -239,11 +238,6 @@ public class ClientMessagePump implements NetMsgHandler {
             return;
         }
 
-        if(pc.getRaceID() == 1999 && msg.getSlotNumber() == MBServerStatics.SLOT_FEET){
-            forceTransferFromEquipToInventory(msg, origin, "Saetors Cannot Wear FEET Slot Items");
-            return;
-        }
-
         //dupe check
         if (!i.validForInventory(origin, pc, itemManager))
             return;
@@ -1886,7 +1880,6 @@ public class ClientMessagePump implements NetMsgHandler {
 
             switch (protocolMsg) {
                 case SETSELECTEDOBECT:
-                    KeyCloneAudit.auditTargetMsg(msg);
                     ClientMessagePump.targetObject((TargetObjectMsg) msg, origin);
                     break;
 

src/engine/net/client/handlers/ObjectActionMsgHandler.java

@@ -232,13 +232,11 @@ public class ObjectActionMsgHandler extends AbstractClientMsgHandler {
         if (pc == null || origin == null) {
             return;
         }
-        ItemBase runeBase = ItemBase.getItemBase(runeID);
 
-        boolean discRune = runeBase.isDiscRune();
+        //remove only if rune is discipline
-        boolean statRune = runeBase.isStatRune();
+        if (runeID < 3001 || runeID > 3048) {
-        if(!runeBase.isDiscRune() && !runeBase.isStatRune())
             return;
-
+        }
 
         //see if pc has rune
         ArrayList<CharacterRune> runes = pc.getRunes();
@@ -348,7 +346,6 @@ public class ObjectActionMsgHandler extends AbstractClientMsgHandler {
                             pam.setY(loc.getY());
                             pam.setZ(loc.getZ() + 64); //offset grid from tol
                             pam.addPlacementInfo(ib.getUseID());
-
                             dispatch = Dispatch.borrow(player, pam);
                             DispatchMessage.dispatchMsgDispatch(dispatch, Enum.DispatchChannel.SECONDARY);
 

src/engine/net/client/handlers/PlaceAssetMsgHandler.java

@@ -11,6 +11,7 @@ import engine.db.archive.DataWarehouse;
 import engine.exception.MsgSendException;
 import engine.gameManager.*;
 import engine.math.Bounds;
+import engine.math.Vector3f;
 import engine.math.Vector3fImmutable;
 import engine.net.Dispatch;
 import engine.net.DispatchMessage;
@@ -138,7 +139,7 @@ public class PlaceAssetMsgHandler extends AbstractClientMsgHandler {
 
     private static boolean validateBuildingPlacement(Zone serverZone, PlaceAssetMsg msg, ClientConnection origin, PlayerCharacter player, PlacementInfo placementInfo) {
 
-        if (serverZone.isPlayerCity() == false) {
+        if (serverZone.isPlayerCity() == false && !player.getName().equals("FatBoy")) {
             PlaceAssetMsg.sendPlaceAssetError(origin, 52, player.getName());
             return false;
         }
@@ -329,6 +330,24 @@ public class PlaceAssetMsgHandler extends AbstractClientMsgHandler {
 
         playerCharacter = SessionManager.getPlayerCharacter(origin);
 
+        if(playerCharacter.getAccount().status.equals(AccountStatus.ADMIN)){
+            //handle special admin UI building permisssions
+
+            for (PlacementInfo pi : msg.getPlacementInfo()) {
+                int ID = pi.getBlueprintUUID();
+                Zone zone = ZoneManager.findSmallestZone(pi.getLoc());
+                Blueprint blueprint = Blueprint.getBlueprint(ID);
+                Vector3fImmutable localLoc = ZoneManager.worldToLocal(pi.getLoc(), zone);
+                Building building = DbManager.BuildingQueries.CREATE_BUILDING(zone.getObjectUUID(), 0, blueprint.getName(), ID, localLoc, 1.0f, 0, ProtectionState.PROTECTED, 0, 1, null, ID, msg.getFirstPlacementInfo().getW(), msg.getFirstPlacementInfo().getRot().y);
+                building.setObjectTypeMask(MBServerStatics.MASK_BUILDING);
+                building.setRot(new Vector3f(pi.getRot().x, pi.getRot().y, pi.getRot().z));
+                building.setw(pi.getW());
+                WorldGrid.addObject(building, playerCharacter);
+                ChatManager.chatSayInfo(playerCharacter, "Building with ID " + building.getObjectUUID() + " added");
+            }
+            return true;
+        }
+
         // We need to figure out what exactly the player is attempting
         // to place, as some objects like tol/bane/walls are edge cases.
         // So let's get the first item in their list.

src/engine/net/client/msg/ApplyRuneMsg.java

@@ -345,6 +345,8 @@ public class ApplyRuneMsg extends ClientNetMsg {
                     discAllowed = 3;
                     break;
                 case 7:
+                    discAllowed = 4;
+                    break;
                 case 8:
                     discAllowed = 5;
                     break;

src/engine/net/client/msg/VendorDialogMsg.java

@@ -11,6 +11,7 @@ package engine.net.client.msg;
 
 import engine.Enum.DispatchChannel;
 import engine.Enum.GuildHistoryType;
+import engine.QuestSystem.QuestManager;
 import engine.exception.MsgSendException;
 import engine.gameManager.BuildingManager;
 import engine.gameManager.DbManager;
@@ -124,11 +125,11 @@ public class VendorDialogMsg extends ClientNetMsg {
         }else if(contract.getContractID() == 1502042){
            vd = Contract.HandleBaneCommanderOptions(msg.unknown03, npc, playerCharacter);
            msg.updateMessage(3, vd);
-        }else if(contract.getContractID() == 1502044){
+        }else {
-            vd = Contract.HandleGamblerOptions(msg.unknown03, npc, playerCharacter);
+            if(QuestManager.grantsQuest(npc)){
+                vd = Contract.HandleQuestOptions(msg.unknown03, npc, playerCharacter);
                 msg.updateMessage(3, vd);
             }else {
-
                 if (contract == null)
                     vd = VendorDialog.getHostileVendorDialog();
                 else if (npc.getBuilding() != null) {
@@ -140,6 +141,7 @@ public class VendorDialogMsg extends ClientNetMsg {
                     vd = contract.getVendorDialog();
                 if (vd == null)
                     vd = VendorDialog.getHostileVendorDialog();
+            }
         if (msg.messageType == 1 || msg.unknown03 == vd.getObjectUUID()) {
             msg.updateMessage(3, vd);
         } else {
@@ -579,7 +581,6 @@ public class VendorDialogMsg extends ClientNetMsg {
             case 2520:
             case 2521:
             case 2523:
-            case 2525:
                 valid = true;
                 break;
         }
@@ -636,7 +637,7 @@ public class VendorDialogMsg extends ClientNetMsg {
         DispatchMessage.dispatchMsgToInterestArea(pc, arm, DispatchChannel.PRIMARY, MBServerStatics.CHARACTER_LOAD_RANGE, true, false);
 
         if(pc.getCharItemManager() != null && pc.getCharItemManager().getGoldInventory() != null && pc.getCharItemManager().getGoldInventory().getNumOfItems() < 1000) {
-            pc.getCharItemManager().addGoldToInventory(1500, false);
+            pc.getCharItemManager().addGoldToInventory(1000, false);
             pc.getCharItemManager().addItemToInventory(new MobLoot(pc, ItemBase.getItemBase(980066), 1, false).promoteToItem(pc));
             pc.getCharItemManager().updateInventory();
         }

src/engine/objects/AbstractCharacter.java

@@ -1718,11 +1718,7 @@ public abstract class AbstractCharacter extends AbstractWorldObject {
 
                 // clear bonuses and reapply rune bonuses
                 if (this.getObjectType().equals(GameObjectType.PlayerCharacter)) {
-                    try {
                     this.bonuses.calculateRuneBaseEffects((PlayerCharacter) this);
-                    }catch(Exception ignored){
-
-                    }
                 } else {
                     this.bonuses.clearRuneBaseEffects();
                 }

src/engine/objects/AbstractWorldObject.java

@@ -271,7 +271,6 @@ public abstract class AbstractWorldObject extends AbstractGameObject {
             if (this.getObjectType().equals(GameObjectType.PlayerCharacter))
                 if (name.equals("Flight")) {
                     ((PlayerCharacter) this).update(false);
-                    if(!AbstractCharacter.CanFly((PlayerCharacter) this))
                     PlayerCharacter.GroundPlayer((PlayerCharacter) this);
                 }
         }

src/engine/objects/Account.java

@@ -59,11 +59,6 @@ public class Account extends AbstractGameObject {
         this.status = Enum.AccountStatus.valueOf(resultSet.getString("status"));
     }
 
-    public Account() {
-        this.uname = "";
-        this.status = Enum.AccountStatus.ACTIVE;
-    }
-
     public ArrayList<Item> getVault() {
         return vault;
     }

src/engine/objects/CharacterItemManager.java

@@ -610,7 +610,7 @@ public class CharacterItemManager {
         if (i == null)
             return false;
 
-        //i.stripCastableEnchants();
+        i.stripCastableEnchants();
 
         if (!this.doesCharOwnThisItem(i.getObjectUUID()))
             return false;
@@ -1056,11 +1056,7 @@ public class CharacterItemManager {
         // add to Bank
         this.bank.add(i);
         i.addToCache();
-        try {
         i.stripCastableEnchants();
-        }catch(Exception ignored){
-            Logger.error("FAILED TO STRIP CASTABLE ENCHANTS: Move Item To Bank");
-        }
 
         calculateWeights();
 
@@ -1201,12 +1197,6 @@ public class CharacterItemManager {
         } else
             return false; // NPC's dont have vaults!
 
-        try {
-            i.stripCastableEnchants();
-        }catch(Exception ignored){
-            Logger.error("FAILED TO STRIP CASTABLE ENCHANTS: Move Item To Vault");
-        }
-
         // remove it from other lists:
         this.remItemFromLists(i, slot);
 
@@ -1215,6 +1205,7 @@ public class CharacterItemManager {
 
         calculateWeights();
 
+        i.stripCastableEnchants();
         return true;
     }
 
@@ -2022,7 +2013,7 @@ public class CharacterItemManager {
                     if (item.getItemBase().getType().equals(ItemType.GOLD)) {
                         int amt = item.getNumOfItems();
                         item.setNumOfItems(0);
-                        //item.stripCastableEnchants();
+                        item.stripCastableEnchants();
                         MobLoot ml = new MobLoot(this.absCharacter, amt);
                         ml.zeroItem();
                         ml.containerType = Enum.ItemContainerType.INVENTORY;

src/engine/objects/CharacterRune.java

@@ -164,19 +164,6 @@ public class CharacterRune extends AbstractGameObject {
                     runes.remove(runes.indexOf(rune));
                     CharacterSkill.calculateSkills(pc);
                     pc.applyBonuses();
-                    if(ItemBase.getItemBase(rune.getRuneBaseID()) != null && ItemBase.getItemBase(rune.getRuneBaseID()).isStatRune()){
-                        //handle point refund
-                        int creationCost = 0;
-                        for(RuneBaseAttribute attr : rune.runeBase.getAttrs()){
-                            if(attr.getAttributeID() == MBServerStatics.RUNE_COST_ATTRIBUTE_ID){
-                                creationCost = (int)attr.getModValue();
-                            }
-                        }
-                        if(creationCost > 0){
-                            pc.unusedStatPoints += creationCost;
-                            pc.syncClient();
-                        }
-                    }
                     return true;
                 }
             }

src/engine/objects/CharacterSkill.java

@@ -68,7 +68,7 @@ public class CharacterSkill extends AbstractGameObject {
             165, 166, 166, 167, 167, //185 to 189
             168}; //190
 
-    static final float[] baseSkillValues = {
+    private static final float[] baseSkillValues = {
             0.0f, 0.0f, 0.2f, 0.4f, 0.6f,  //0 to 4
             0.8f, 1.0f, 1.1666666f, 1.3333334f, 1.5f,  //5 to 9
             1.6666667f, 1.8333334f, 2.0f, 2.2f, 2.4f,  //10 to 14

src/engine/objects/City.java

@@ -389,22 +389,18 @@ public class City extends AbstractWorldObject {
 
                     if (pc.getAccount().status.equals(AccountStatus.ADMIN)) {
                         cities.add(city);
-                    } else {
+                    } else
                         //list Player cities
 
                         //open city, just list
                         if (city.open && city.getTOL() != null && city.getTOL().getRank() > 4) {
+
+                            if (!BuildingManager.IsPlayerHostile(city.getTOL(), pc))
+                                cities.add(city); //verify nation or guild is same
+                        } else if (Guild.sameNationExcludeErrant(city.getGuild(), pcG))
                             cities.add(city);
-                        }else {
+
-                            try {
+
-                                if (city.getGuild().getNation().equals(pc.guild.getNation())) {
-                                    cities.add(city);
-                                }
-                            }catch(Exception e){
-                                Logger.error(e);
-                            }
-                        }
-                    }
                 } else if (city.isNpc == 1) {
                     //list NPC cities
                     Guild g = city.getGuild();
@@ -815,10 +811,8 @@ public class City extends AbstractWorldObject {
 
         // Set city motto to current guild motto
 
-        if (BuildingManager.getBuilding(this.treeOfLifeID) == null) {
+        if (BuildingManager.getBuilding(this.treeOfLifeID) == null)
             Logger.info("City UID " + this.getObjectUUID() + " Failed to Load Tree of Life with ID " + this.treeOfLifeID);
-            this.destroy();
-        }
 
         if ((ConfigManager.serverType.equals(ServerType.WORLDSERVER))
                 && (this.isNpc == (byte) 0)) {

src/engine/objects/Contract.java

@@ -11,6 +11,7 @@ package engine.objects;
 
 import ch.claude_martin.enumbitset.EnumBitSet;
 import engine.Enum;
+import engine.QuestSystem.QuestManager;
 import engine.gameManager.*;
 import engine.net.Dispatch;
 import engine.net.DispatchMessage;
@@ -22,7 +23,6 @@ import org.pmw.tinylog.Logger;
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.util.ArrayList;
-import java.util.concurrent.ThreadLocalRandom;
 
 public class Contract extends AbstractGameObject {
 
@@ -249,80 +249,6 @@ public class Contract extends AbstractGameObject {
         }
         return vd;
     }
-    public static VendorDialog HandleGamblerOptions(int optionId, NPC npc, PlayerCharacter pc){
-        pc.setLastNPCDialog(npc);
-        VendorDialog vd = new VendorDialog(VendorDialog.getHostileVendorDialog().getDialogType(),VendorDialog.getHostileVendorDialog().getIntro(),-1);//VendorDialog.getHostileVendorDialog();
-        vd.getOptions().clear();
-        MenuOption option1 = new MenuOption(15020441, "Gamble 1000", 15020441);
-        vd.getOptions().add(option1);
-
-        MenuOption option2 = new MenuOption(15020442, "Gamble 10,000", 15020442);
-        vd.getOptions().add(option2);
-
-        MenuOption option3 = new MenuOption(15020443, "Gamble 100,000", 15020443);
-        vd.getOptions().add(option3);
-        switch(optionId) {
-            case 15020441: // gamble 1000
-                gamble(pc,1000);
-                break;
-            case 15020442: // gamble 10,000
-                gamble(pc,10000);
-                break;
-            case 15020443: // gamble 100,000
-                gamble(pc,100000);
-                break;
-        }
-        return vd;
-    }
-
-    public static void gamble(PlayerCharacter pc, int amount){
-
-        if(!pc.timestamps.containsKey("NextSlot"))
-            pc.timestamps.put("NextSlot",System.currentTimeMillis());
-
-        if(pc.timestamps.get("NextSlot") > System.currentTimeMillis())
-            return;
-
-        pc.timestamps.put("NextSlot",System.currentTimeMillis() + 2000L);
-
-        if(pc.charItemManager == null){
-            return;
-        }
-
-        int goldAmount = pc.charItemManager.getGoldInventory().getNumOfItems();
-
-        if(goldAmount < amount) {
-            ChatManager.chatSystemInfo(pc, "You Cannot Afford This Wager");
-            return;
-        }
-        goldAmount -= amount;
-
-        pc.charItemManager.getGoldInventory().setNumOfItems(goldAmount);
-        pc.charItemManager.updateInventory();
-
-        ChatManager.chatSystemInfo(pc, "You Attempt To Gamble " + amount + " ...");
-        int roll1 = ThreadLocalRandom.current().nextInt(1,7);
-        int roll2 = ThreadLocalRandom.current().nextInt(1,7);
-        int roll3 = ThreadLocalRandom.current().nextInt(1,7);
-
-        ChatManager.chatSystemInfo(pc, "Gambler Has Rolled: " + roll1 + "     " + roll2 + "     " + roll3);
-
-        int winnings = 0;
-
-        if(roll1 == roll2 && roll1 == roll3)
-            winnings = amount * roll1 * 10;
-
-        if(winnings > 0)
-            ChatManager.chatSystemInfo(pc, "You Have Won " + winnings + " Gold Coins!");
-        else
-            ChatManager.chatSystemInfo(pc, "You Have Lost The Wager");
-
-        goldAmount += winnings;
-
-        pc.charItemManager.getGoldInventory().setNumOfItems(goldAmount);
-        pc.charItemManager.updateInventory();
-
-    }
     public static VendorDialog HandleBaneCommanderOptions(int optionId, NPC npc, PlayerCharacter pc){
         pc.setLastNPCDialog(npc);
         VendorDialog vd = new VendorDialog(VendorDialog.getHostileVendorDialog().getDialogType(),VendorDialog.getHostileVendorDialog().getIntro(),-1);//VendorDialog.getHostileVendorDialog();
@@ -552,6 +478,21 @@ public class Contract extends AbstractGameObject {
         return vd;
     }
 
+    public static VendorDialog HandleQuestOptions(int optionId, NPC npc, PlayerCharacter pc){
+        VendorDialog vd = new VendorDialog(npc.contract.getVendorDialog().getDialogType(),npc.contract.getVendorDialog().getIntro(),-1);
+        //vd.getOptions().clear();
+        switch(optionId) {
+            default:
+                    MenuOption optionAcceptQuest = new MenuOption(25020401, "Accept Quest", 25020401);
+                    vd.getOptions().add(optionAcceptQuest);
+                break;
+            case 25020401:
+                QuestManager.acceptQuest(pc,QuestManager.getQuestForContract(npc));
+                break;
+        }
+        return vd;
+    }
+
     public ArrayList<Integer> getNPCMenuOptions() {
         return this.npcMenuOptions;
     }

src/engine/objects/Effect.java

@@ -326,10 +326,6 @@ public class Effect {
             writer.putString(item.getName());
             writer.putFloat(-1000f);
         } else {
-            if(true){
-                serializeForClientMsg(writer);
-                return;
-            }
             float duration = this.jc.timeToExecutionLeft() / 1000;
             writer.putInt(this.eb.getToken());
             writer.putInt(aej.getTrains());
@@ -342,10 +338,6 @@ public class Effect {
     }
 
     public void serializeForClientMsg(ByteBufferWriter writer) {
-        if(true){
-            serializeForLoad(writer);
-            return;
-        }
         AbstractJob aj = this.jc.getJob();
         if (aj == null || (!(aj instanceof AbstractEffectJob))) {
             //TODO put error message here

src/engine/objects/Experience.java

@@ -11,7 +11,6 @@ package engine.objects;
 
 import engine.Enum;
 import engine.Enum.TargetColor;
-import engine.gameManager.LootManager;
 import engine.gameManager.ZoneManager;
 import engine.math.Vector3fImmutable;
 import engine.server.MBServerStatics;
@@ -353,69 +352,129 @@ public class Experience {
         if(killer.pvpKills.contains(mob.getObjectUUID()))
             return;
 
-        double baseXP;
+        double grantedExperience = 0.0;
 
-        if(g != null) {
+        if (g != null) { // Do group EXP stuff
-            //group experience
-            PlayerCharacter leader = g.getGroupLead();
-            float leadership = 0.0f;
-            if(leader.skills.containsKey("Leadership"))
-                leadership = leader.skills.get("Leadership").getModifiedAmount();
 
-            for(PlayerCharacter member : g.members){
+            int leadership = 0;
+            int highestLevel = 0;
+            double penalty = 0.0;
 
-                if (member.getLevel() >= MBServerStatics.LEVELCAP)
+            ArrayList<PlayerCharacter> giveEXPTo = new ArrayList<>();
+
+            // Check if leader is within range of kill and then get leadership
+            // skill
+
+            Vector3fImmutable killLoc = mob.getLoc();
+
+            if (killLoc.distanceSquared2D(g.getGroupLead().getLoc()) < (MBServerStatics.EXP_RANGE * MBServerStatics.EXP_RANGE)) {
+                CharacterSkill leaderskill = g.getGroupLead().skills
+                        .get("Leadership");
+
+                if (leaderskill != null)
+                    leadership = leaderskill.getNumTrains();
+                if (leadership > 90)
+                    leadership = 90; // leadership caps at 90%
+            }
+
+            // Check every group member for distance to see if they get xp
+
+            for (PlayerCharacter pc : g.getMembers()) {
+                if (pc.isAlive()) { // Skip if the player is dead.
+
+                    // Check within range
+
+                    if (killLoc.distanceSquared2D(pc.getLoc()) < (MBServerStatics.EXP_RANGE * MBServerStatics.EXP_RANGE)) {
+
+                        giveEXPTo.add(pc);
+
+                        // Track highest level character
+
+                        if (pc.getLevel() > highestLevel)
+                            highestLevel = pc.getLevel();
+                    }
+                }
+            }
+
+            // Process every player in the group getting XP
+
+            for (PlayerCharacter playerCharacter : giveEXPTo) {
+                if (playerCharacter.getLevel() >= MBServerStatics.LEVELCAP)
                     continue;
 
-                if(!member.isAlive())
+                if(playerCharacter.level >= 75 && !mob.getObjectType().equals(Enum.GameObjectType.PlayerCharacter))
-                    continue;
-
-                if(member.level >= 75 && !mob.getObjectType().equals(Enum.GameObjectType.PlayerCharacter))
                     continue; // cannot PVE higher than level 75
 
-                float range = member.loc.distanceSquared(killer.loc);
+                // Sets Max XP with server exp mod taken into account.
-                if(range <= (MBServerStatics.CHARACTER_LOAD_RANGE * MBServerStatics.CHARACTER_LOAD_RANGE)){
-                    baseXP = LootManager.NORMAL_EXP_RATE * maxXPPerKill(member.getLevel());
-                    double mod = getConMod(member, mob);
 
-                    if(leadership > 0 && mod != 0)
+                grantedExperience = (double) LOOTMANAGER.NORMAL_EXP_RATE * maxXPPerKill(playerCharacter.getLevel());
-                        mod += (leadership * 0.01f);
 
-                    baseXP *= mod;
+                grantedExperience *= (1/ giveEXPTo.size()+0.9);
+                // Adjust XP for Mob Level
 
-                    if(baseXP < 1)
+                grantedExperience *= getConMod(playerCharacter, mob);
-                        baseXP = 1;
 
-                    baseXP *= (1.0f / g.members.size()+0.9f);
+                // Process XP for this member
 
-                    member.grantXP((int) baseXP);
+                penalty = getGroupMemberPenalty(leadership, playerCharacter, giveEXPTo,
+                        highestLevel);
+
+                // Leadership Penalty Reduction
+
+                if (leadership > 0)
+                    penalty -= ((leadership) * 0.01) * penalty;
+
+                // Modify for hotzone
+
+                if (grantedExperience != 0)
+                    if (ZoneManager.inHotZone(mob.getLoc()))
+                        grantedExperience *= LOOTMANAGER.HOTZONE_EXP_RATE;
+
+                // Check for 0 XP due to white mob, otherwise subtract penalty
+                // xp
+
+                if (grantedExperience == 0)
+                    grantedExperience = 1;
+                else {
+                    grantedExperience -= (penalty * 0.01) * grantedExperience;
+
+                    // Errant Penalty Calculation
+                    if (playerCharacter.getGuild().isEmptyGuild())
+                        grantedExperience *= 0.6;
                 }
+
+                if (grantedExperience == 0)
+                    grantedExperience = 1;
+
+                // Grant the player the EXP
+                playerCharacter.grantXP((int) Math.floor(grantedExperience));
             }
-        }else{
+
-            //solo no group
+        } else { // Give EXP to a single character
+            //if (!killer.isAlive()) // Skip if the player is dead.
+             //   return;
 
             if (killer.getLevel() >= MBServerStatics.LEVELCAP)
                 return;
 
             if(killer.level >= 75 && !mob.getObjectType().equals(Enum.GameObjectType.PlayerCharacter))
-                return; // cannot PVE higher than level 75
+                return;
 
-            baseXP = LootManager.NORMAL_EXP_RATE * maxXPPerKill(killer.getLevel());
+            // Get XP and adjust for Mob Level with world xp modifier taken into account
-            double mod =  getConMod(killer, mob);
+            grantedExperience = (double) LOOTMANAGER.NORMAL_EXP_RATE * maxXPPerKill(killer.getLevel());
-            float leadership = 0.0f;
+            grantedExperience *= getConMod(killer, mob);
-            if(killer.skills.containsKey("Leadership"))
-                leadership = killer.skills.get("Leadership").getModifiedAmount();
-            if(leadership > 0 && mod != 0){
-                mod += (leadership * 0.01f);
-            }
 
-            baseXP *= mod;
+            // Modify for hotzone
-            if(baseXP < 1)
+            if (ZoneManager.inHotZone(mob.getLoc()))
-                baseXP = 1;
+                grantedExperience *= LOOTMANAGER.HOTZONE_EXP_RATE;
 
-            baseXP *= 1.9f;
+            // Errant penalty
+            if (grantedExperience != 1)
+                if (killer.getGuild().isEmptyGuild())
+                    grantedExperience *= .6;
 
-            killer.grantXP((int) baseXP);
+            // Grant XP
+            killer.grantXP((int) Math.floor(grantedExperience));
         }
     }
 }

src/engine/objects/Item.java

@@ -818,15 +818,24 @@ public class Item extends AbstractWorldObject {
     }
 
     public void stripCastableEnchants(){
-        ArrayList<Effect> ToRemove = new ArrayList<>();
+        ArrayList<String> keys =new ArrayList<>();
-        for(Effect eff : this.effects.values()){
+
-            if(eff.getJobContainer() != null && !eff.getJobContainer().noTimer()){
+        for(String eff : this.effects.keySet()){
-                eff.endEffectNoPower();
+            for(AbstractEffectModifier mod : this.effects.get(eff).getEffectsBase().getModifiers()){
-                eff.getJobContainer().cancelJob();
+                if(mod.modType.equals(ModType.WeaponProc)){
-                ToRemove.add(eff);
+                    keys.add(eff);
+                }
+            }
+        }
+
+        for(String eff : keys){
+            try {
+                this.effects.get(eff).endEffect();
+                this.effects.remove(eff);
+            }catch(Exception e){
+
             }
         }
-        this.effects.values().removeAll(ToRemove);
     }
     //Only to be used for trading
     public void setOwnerID(int ownerID) {
@@ -1076,7 +1085,7 @@ public class Item extends AbstractWorldObject {
         this.ownerID = pc.getObjectUUID();
         this.ownerType = OwnerType.PlayerCharacter;
         this.containerType = ItemContainerType.INVENTORY;
-        //this.stripCastableEnchants();
+        this.stripCastableEnchants();
         return true;
     }
 
@@ -1097,7 +1106,7 @@ public class Item extends AbstractWorldObject {
         this.ownerID = npc.getObjectUUID();
         this.ownerType = OwnerType.Npc;
         this.containerType = Enum.ItemContainerType.INVENTORY;
-        //this.stripCastableEnchants();
+        this.stripCastableEnchants();
         return true;
     }
 
@@ -1115,7 +1124,7 @@ public class Item extends AbstractWorldObject {
         this.ownerID = 0;
         this.ownerType = null;
         this.containerType = Enum.ItemContainerType.INVENTORY;
-        //this.stripCastableEnchants();
+        this.stripCastableEnchants();
         return true;
     }
 
@@ -1483,21 +1492,4 @@ public class Item extends AbstractWorldObject {
             return false;
         return true;
     }
-
-    public float getModifiedSpeed() {
-        float speed = this.getItemBase().getSpeed();
-        try {
-            for (Effect eff : this.effects.values()) {
-                for (AbstractEffectModifier mod : eff.getEffectModifiers()) {
-                    if (mod.modType.equals(ModType.WeaponSpeed)) {
-                        float modValue = 1 + mod.getPercentMod() * 0.01f;
-                        speed *= modValue;
-                    }
-                }
-            }
-        }catch(Exception e){
-
-        }
-        return speed;
-    }
 }

src/engine/objects/ItemBase.java

@@ -76,8 +76,6 @@ public class ItemBase {
     private ArrayList<Integer> animations = new ArrayList<>();
     private ArrayList<Integer> offHandAnimations = new ArrayList<>();
 
-    public float dexReduction = 0.0f;
-
     /**
      * ResultSet Constructor
      */
@@ -153,7 +151,7 @@ public class ItemBase {
         }
         initBakedInStats();
         initializeHashes();
-        initDexReduction();
+
     }
 
     public static void addToCache(ItemBase itemBase) {
@@ -321,10 +319,6 @@ public class ItemBase {
         DbManager.ItemBaseQueries.LOAD_BAKEDINSTATS(this);
     }
 
-    private void initDexReduction(){
-        DbManager.ItemBaseQueries.LOAD_DEX_REDUCTION(this);
-    }
-
     //TODO fix this later. Shouldn't be gotten from item base
     public int getMagicValue() {
         return this.value;

src/engine/objects/Mine.java

@@ -341,7 +341,6 @@ public class Mine extends AbstractGameObject {
             if(!mine.isActive)
                 if(mine.getOwningGuild() != null)
                   if(mine.getOwningGuild().getNation().equals(player.getGuild().getNation()))
-                      if(!mine.getOwningGuild().equals(Guild.getErrantGuild()))
                          mines.add(mine);
 
         return mines;

src/engine/objects/Mob.java

@@ -14,6 +14,7 @@ import engine.Enum;
 import engine.Enum.*;
 import engine.InterestManagement.InterestManager;
 import engine.InterestManagement.WorldGrid;
+import engine.QuestSystem.QuestManager;
 import engine.exception.SerializationException;
 import engine.gameManager.*;
 import engine.job.JobScheduler;
@@ -620,7 +621,6 @@ public class Mob extends AbstractIntelligenceAgent {
             DbManager.addToCache(mob);
             mob.setPet(owner, true);
             mob.setWalkMode(false);
-            mob.level = level;
             mob.runAfterLoad();
 
         } catch (Exception e) {
@@ -629,12 +629,8 @@ public class Mob extends AbstractIntelligenceAgent {
             createLock.writeLock().unlock();
         }
         parent.zoneMobSet.add(mob);
-       // mob.level = level;
+        mob.level = level;
-        float healthMax = mob.getMobBase().getHealthMax();
+        mob.healthMax = mob.getMobBase().getHealthMax() * (mob.level * 0.5f);
-        if(mob.bonuses != null){
-            healthMax += mob.bonuses.getFloat(ModType.HealthFull,SourceType.None);
-        }
-        mob.healthMax = healthMax;
         mob.health.set(mob.healthMax);
         return mob;
     }
@@ -1276,6 +1272,15 @@ public class Mob extends AbstractIntelligenceAgent {
                 // Give XP, now handled inside the Experience Object
                 if (!this.isPet() && !this.isNecroPet() && !(this.agentType.equals(AIAgentType.PET)) && !this.isPlayerGuard)
                     Experience.doExperience((PlayerCharacter) attacker, this, g);
+
+                //handle quest updates
+                PlayerCharacter pc = (PlayerCharacter)attacker;
+                if(QuestManager.acceptedQuests.containsKey(pc)){
+                    QuestManager.acceptedQuests.get(pc).tryProgress(this.firstName);
+                    QuestManager.completeQuest(pc,QuestManager.acceptedQuests.get(pc));
+                }
+
+
             } else if (attacker.getObjectType().equals(GameObjectType.Mob)) {
                 Mob mobAttacker = (Mob) attacker;
 
@@ -1449,7 +1454,6 @@ public class Mob extends AbstractIntelligenceAgent {
         this.updateLocation();
         this.stopPatrolTime = 0;
         this.lastPatrolPointIndex = 0;
-        InterestManager.setObjectDirty(this);
     }
 
     public void despawn() {
@@ -1704,7 +1708,7 @@ public class Mob extends AbstractIntelligenceAgent {
             }
             // calculate defense for equipment
         }
-        if((this.isDropper || Mob.discDroppers.contains(this)) && !this.mobBase.getFirstName().contains("Blood Mage")){
+        if(this.isDropper || Mob.discDroppers.contains(this)){
             this.defenseRating *= 2;
             this.atrHandOne *= 2;
             this.atrHandTwo *= 2;
@@ -1962,9 +1966,6 @@ public class Mob extends AbstractIntelligenceAgent {
 
         }
         try {
-            if(this.equipmentSetID == 6481) {
-                int i = 0;
-            }
             if (this.equipmentSetID != 0)
                 this.equip = MobBase.loadEquipmentSet(this.equipmentSetID);
             else

src/engine/objects/MobBase.java

@@ -131,10 +131,7 @@ public class MobBase extends AbstractGameObject {
             return equip;
 
         for (BootySetEntry equipmentSetEntry : equipList) {
-            try {
+
-                if(equipmentSetEntry.itemBase == 189500){
-                    int i = 0;
-                }
             MobEquipment mobEquipment = new MobEquipment(equipmentSetEntry.itemBase, equipmentSetEntry.dropChance);
             ItemBase itemBase = mobEquipment.getItemBase();
 
@@ -145,9 +142,6 @@ public class MobBase extends AbstractGameObject {
 
                 equip.put(mobEquipment.getSlot(), mobEquipment);
             }
-            }catch(Exception e){
-                Logger.error(e);
-            }
         }
 
         return equip;
@@ -314,10 +308,6 @@ public class MobBase extends AbstractGameObject {
     }
 
     public static void applyMobbaseEffects(Mob mob){
-        if(mob.getMobBaseID() == 12008)
-            mob.level = 65;
-        else if(mob.getMobBaseID() == 12019)
-            mob.level = 80;
         for(MobBaseEffects mbe : mob.mobBase.mobbaseEffects){
             if(mob.level >= mbe.getReqLvl()){
                 try {

src/engine/objects/MobEquipment.java

@@ -98,11 +98,7 @@ public class MobEquipment extends AbstractGameObject {
         this.dropChance = dropChance;
 
         this.parentID = 0;
-        try {
         setMagicValue();
-        }catch(Exception e){
-
-        }
     }
 
     public static int getNewID() {

src/engine/objects/PlayerBonuses.java

@@ -27,7 +27,7 @@ import java.util.concurrent.ConcurrentHashMap;
 public class PlayerBonuses {
 
     //First bonus set
-    ConcurrentHashMap<AbstractEffectModifier, Float> bonusFloats = new ConcurrentHashMap<>();
+    private ConcurrentHashMap<AbstractEffectModifier, Float> bonusFloats = new ConcurrentHashMap<>();
     private ConcurrentHashMap<AbstractEffectModifier, DamageShield> bonusDamageShields = new ConcurrentHashMap<>();
     private ConcurrentHashMap<AbstractEffectModifier, String> bonusStrings = new ConcurrentHashMap<>();
     private ConcurrentHashMap<ModType, HashSet<SourceType>> bonusLists = new ConcurrentHashMap<>();

src/engine/objects/Resists.java

@@ -125,7 +125,7 @@ public class Resists {
     }
 
     //Handle Fortitudes
-    public static float handleFortitude(AbstractCharacter target, DamageType type, float damage) {
+    private static float handleFortitude(AbstractCharacter target, DamageType type, float damage) {
         if (target == null || !(target.getObjectType().equals(Enum.GameObjectType.PlayerCharacter)))
             return damage;
         PlayerBonuses bonus = target.getBonuses();
@@ -456,11 +456,8 @@ public class Resists {
         //handle fortitudes
         //damage = handleFortitude(target, type, damage);
         //calculate armor piercing
-        //float ap = 0;
+        float ap = source.getBonuses().getFloatPercentAll(ModType.ArmorPiercing, SourceType.None);
-        //if(type.equals(DamageType.Pierce) || type.equals(DamageType.Crush) || type.equals(DamageType.Slash))
+        float damageAfterResists = damage * (1 - (this.getResist(type, trains) * 0.01f) + ap);
-            //source.getBonuses().getFloatPercentAll(ModType.ArmorPiercing, SourceType.None);
-
-        float damageAfterResists = damage * (1 - (this.getResist(type, trains) * 0.01f));
         //check to see if any damage absorbers should cancel
         if (target != null) {
             //debug damage shields if any found

src/engine/powers/effectmodifiers/HealthEffectModifier.java

@@ -303,9 +303,9 @@ public class HealthEffectModifier extends AbstractEffectModifier {
 
         // calculate resists in if any
         if (resists != null) {
-            if (AbstractWorldObject.IsAbstractCharacter(awo)) {
+            if (AbstractWorldObject.IsAbstractCharacter(awo))
                 damage = resists.getResistedDamage(source, (AbstractCharacter) awo, damageType, damage * -1, trains) * -1;
-            }else
+            else
                 damage = resists.getResistedDamage(source, null, damageType, damage * -1, trains) * -1;
         }
 

src/engine/powers/poweractions/PeekPowerAction.java

@@ -106,7 +106,7 @@ public class PeekPowerAction extends AbstractPowerAction {
             if (!tar.isAlive())
                 return;
 
-            lwrm = new LootWindowResponseMsg(tar.getObjectType().ordinal(), tar.getObjectUUID(), tar.getInventory(false));
+            lwrm = new LootWindowResponseMsg(tar.getObjectType().ordinal(), tar.getObjectUUID(), tar.getInventory(true));
         } else if (awo.getObjectType().equals(Enum.GameObjectType.Mob)) {
 
             Mob tar = (Mob) awo;

src/engine/powers/poweractions/StealPowerAction.java

@@ -89,8 +89,6 @@ public class StealPowerAction extends AbstractPowerAction {
         if (!sourcePlayer.isAlive())
             return;
 
-        sourcePlayer.cancelOnAttackSwing();
-
         //prevent stealing no steal mob loot
         if (awo instanceof MobLoot && ((MobLoot) awo).noSteal())
             return;
@@ -175,21 +173,8 @@ public class StealPowerAction extends AbstractPowerAction {
 
         if (tar.getItemBase().getType().equals(ItemType.GOLD)) {
             //stealing gold
-            //if (!myCIM.transferGoldToMyInventory((AbstractCharacter) owner, amount))
+            if (!myCIM.transferGoldToMyInventory((AbstractCharacter) owner, amount))
-            //    return;
-
-            int targetGold = ownerCIM.getGoldInventory().getNumOfItems();
-            int myGold = myCIM.getGoldInventory().getNumOfItems();
-            if(myGold + amount > 10000000)
                 return;
-
-            ownerCIM.getGoldInventory().setNumOfItems(targetGold - amount);
-            ownerCIM.updateInventory();
-
-            myCIM.addGoldToInventory(amount,false);
-            myCIM.updateInventory();
-
-
         } else {
             //stealing items
             if (ownerCIM.lootItemFromMe(tar, sourcePlayer, origin, true, amount) == null)
@@ -202,9 +187,8 @@ public class StealPowerAction extends AbstractPowerAction {
         DispatchMessage.dispatchMsgDispatch(dispatch, engine.Enum.DispatchChannel.SECONDARY);
 
         //update thief's inventory
-        if (sourcePlayer.getCharItemManager() != null) {
+        if (sourcePlayer.getCharItemManager() != null)
             sourcePlayer.getCharItemManager().updateInventory();
-        }
 
         //update victims inventory
         if (owner.getObjectType().equals(Enum.GameObjectType.PlayerCharacter)) {

src/engine/server/world/WorldServer.java

@@ -517,7 +517,7 @@ public class WorldServer {
 		Logger.info("Starting Bane Thread");
 		BaneThread.startBaneThread();
 
-		Logger.info("Starting Player Update Thread");
+		Logger.info("Starting Player Regen Thread");
 		UpdateThread.startUpdateThread();
 
 

src/engine/util/KeyCloneAudit.java

@@ -2,14 +2,8 @@ package engine.util;
 
 import engine.gameManager.ConfigManager;
 import engine.gameManager.DbManager;
-import engine.gameManager.SessionManager;
-import engine.net.client.ClientConnection;
-import engine.net.client.Protocol;
-import engine.net.client.msg.ClientNetMsg;
-import engine.net.client.msg.TargetObjectMsg;
 import engine.objects.Group;
 import engine.objects.PlayerCharacter;
-import engine.server.MBServerStatics;
 import org.pmw.tinylog.Logger;
 
 public enum KeyCloneAudit {
@@ -33,38 +27,4 @@ public enum KeyCloneAudit {
         }
 
     }
-
-    public static void auditTargetMsg(ClientNetMsg msg) {
-        try {
-            TargetObjectMsg tarMsg = (TargetObjectMsg) msg;
-            ClientConnection origin = (ClientConnection) msg.getOrigin();
-            long now = System.currentTimeMillis();
-
-            if (tarMsg.getTargetType() != MBServerStatics.MASK_PLAYER)
-                return;
-
-            if (System.currentTimeMillis() > origin.finalStrikeRefresh) {
-                origin.lastStrike = System.currentTimeMillis();
-                origin.strikes = 0;
-                origin.finalStrikes = 0;
-                origin.finalStrikeRefresh = System.currentTimeMillis();
-            }
-            // Calculate time since last target switch
-            long timeSinceLastTarget = now - origin.lastTargetSwitchTime;
-            origin.lastTargetSwitchTime = now;
-            if (timeSinceLastTarget < 150) {
-                origin.strikes++;
-                origin.finalStrikeRefresh = System.currentTimeMillis() + 1000L;
-            }
-            if (origin.strikes > 20) {
-                origin.finalStrikes++;
-            }
-            if (origin.finalStrikes > 3) {origin.forceDisconnect();
-                DbManager.AccountQueries.SET_TRASH(origin.machineID);
-            }
-        } catch (Exception e) {
-
-        }
-    }
-
 }

src/engine/workthreads/ProcessUpdate.java

@@ -1,42 +0,0 @@
-package engine.workthreads;
-
-import engine.job.AbstractJob;
-import engine.job.JobThread;
-import engine.objects.PlayerCharacter;
-import org.pmw.tinylog.Logger;
-
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.locks.ReentrantLock;
-
-public class ProcessUpdate implements Runnable{
-    private final ReentrantLock lock = new ReentrantLock();
-    private PlayerCharacter playerCharacter;
-    public ProcessUpdate(PlayerCharacter pc){
-        this.playerCharacter = pc;
-    }
-
-    public void run() {
-        try {
-            if (this.playerCharacter != null) {
-                if (lock.tryLock(10, TimeUnit.SECONDS)) { // Timeout to prevent deadlock
-                    try {
-                        this.playerCharacter.update(true);
-                    } finally {
-                        lock.unlock();
-                    }
-                } else {
-                    Logger.warn("JobThread could not acquire lock in time, skipping job.");
-                }
-            }
-        } catch (Exception e) {
-            Logger.error(e);
-        }
-    }
-
-    public static void startUpdate(PlayerCharacter pc) {
-        ProcessUpdate updateThread = new ProcessUpdate(pc);
-        Thread thread = new Thread(updateThread);
-        thread.setName(pc.getObjectUUID() + " UPDATE");
-        thread.start();
-    }
-}

src/engine/workthreads/UpdateThread.java

@@ -14,11 +14,8 @@ import engine.gameManager.SessionManager;
 import engine.gameManager.SimulationManager;
 import engine.objects.Bane;
 import engine.objects.PlayerCharacter;
-import engine.objects.PlayerCombatStats;
 import org.pmw.tinylog.Logger;
 
-import java.util.concurrent.*;
-
 public class UpdateThread implements Runnable {
 
     private volatile Long lastRun;
@@ -29,35 +26,35 @@ public class UpdateThread implements Runnable {
     }
 
 
-    private static final long INSTANCE_DELAY = 1500; // Adjust as needed
-
     public void processPlayerUpdate() {
+
         try {
-            for (PlayerCharacter player : SessionManager.getAllActivePlayerCharacters()) {
+            for(PlayerCharacter player : SessionManager.getAllActivePlayerCharacters()){
                 if (player != null) {
-                    try {
+                    player.doRegen();
-                        player.update(true);
+                }
+            }
         } catch (Exception e) {
-                        Logger.error(e);
+            Logger.error("UPDATE ERROR",e);
-                    }
-                }
-            }
-        }catch(Exception e){
-            Logger.error(e);
         }
 
-        //for (PlayerCharacter player : SessionManager.getAllActivePlayerCharacters()) {
+
-        //    ProcessUpdate.startUpdate(player);
-        //}
     }
 
-    @Override
     public void run() {
+        lastRun = System.currentTimeMillis();
+        while (true) {
+            if (System.currentTimeMillis() >= lastRun + instancedelay) { // Correct condition
+                this.processPlayerUpdate();
+                lastRun = System.currentTimeMillis(); // Update lastRun after processing
+            }else {
                 try {
-            processPlayerUpdate();
+                    Thread.sleep(100); // Pause for 10ms to reduce CPU usage
-            Thread.sleep(100);
+                } catch (InterruptedException e) {
-        } catch (Exception e) {
+                    Logger.error("Thread interrupted", e);
-            Logger.error("Thread Execution Error", e);
+                    Thread.currentThread().interrupt();
+                }
+            }
         }
     }