Merge remote-tracking branch 'refs/remotes/origin/weekend-fixings' into feature-config-parsing2

src/engine/gameManager/BuildingManager.java

@@ -798,7 +798,7 @@ public enum BuildingManager {
         // Attempt to write to database or delete the building
         // if we are destroying it.
 
-        if (rank == -1)
+        if (rank < 0)
             success = DbManager.BuildingQueries.DELETE_FROM_DATABASE(building);
         else
             success = DbManager.BuildingQueries.updateBuildingRank(building, rank);

src/engine/gameManager/ConfigManager.java

@@ -12,6 +12,7 @@ import engine.mbEnums;
 import engine.server.login.LoginServer;
 import engine.server.world.WorldServer;
 import engine.wpak.EffectsParser;
+import engine.wpak.PowerActionParser;
 import engine.wpak.PowersParser;
 import org.pmw.tinylog.Logger;
 
@@ -169,10 +170,9 @@ public enum ConfigManager {
 
         Logger.info("Loading WPAK data");
 
-
+        //EffectsParser.parseWpakFile();
-        EffectsParser.parseWpakFile();
+        //PowersParser.parseWpakFile();
-        PowersParser.parseWpakFile();
+        //PowerActionParser.parseWpakFile();
-
 
         return true;
     }

src/engine/gameManager/PowersManager.java

@@ -31,6 +31,10 @@ import engine.objects.*;
 import engine.powers.*;
 import engine.powers.poweractions.AbstractPowerAction;
 import engine.server.MBServerStatics;
+import engine.wpak.EffectsParser;
+import engine.wpak.PowerActionParser;
+import engine.wpak.PowersParser;
+import engine.wpak.data.Effect;
 import org.pmw.tinylog.Logger;
 
 import java.util.ArrayList;
@@ -112,10 +116,30 @@ public enum PowersManager {
         return powerEntries;
     }
 
+    public static void InitializeEffects(){
+        // Add EffectsBase
+        ArrayList<EffectsBase> effectList = new ArrayList<>();
+
+        for (Effect entry : EffectsParser.effect_data.values()) {
+            EffectsBase effectBase = new EffectsBase(entry);
+            effectList.add(effectBase);
+            PowersManager.effectsBaseByToken.put(effectBase.getToken(), effectBase);
+            PowersManager.effectsBaseByIDString.put(effectBase.getIDString(), effectBase);
+        }
+
+        // Add Fail Conditions
+        EffectsBase.getFailConditions(PowersManager.effectsBaseByIDString);
+    }
+
     // This pre-loads all powers and effects
     public static void InitializePowers() {
 
-        // Add EffectsBase
+        EffectsParser.parseWpakFile();
+        PowersParser.parseWpakFile();
+        PowerActionParser.parseWpakFile();
+
+        //InitializeEffects();
+
         ArrayList<EffectsBase> ebList = dbEffectsBaseHandler.getAllEffectsBase();
 
         for (EffectsBase eb : ebList) {
@@ -957,7 +981,7 @@ public enum PowersManager {
                 //				if (!stackType.equals("IgnoreStack")) {
                 if (target.getEffects().containsKey(stackType)) {
                     // remove any existing power that overrides
-                    Effect ef = target.getEffects().get(stackType);
+                    engine.objects.Effect ef = target.getEffects().get(stackType);
                     AbstractEffectJob effect = null;
                     if (ef != null) {
                         JobContainer jc = ef.getJobContainer();
@@ -1129,7 +1153,7 @@ public enum PowersManager {
                 //				if (!stackType.equals("IgnoreStack")) {
                 if (target.getEffects().containsKey(stackType)) {
                     // remove any existing power that overrides
-                    Effect ef = target.getEffects().get(stackType);
+                    engine.objects.Effect ef = target.getEffects().get(stackType);
                     AbstractEffectJob effect = null;
                     if (ef != null) {
                         JobContainer jc = ef.getJobContainer();
@@ -1443,7 +1467,7 @@ public enum PowersManager {
             stackType = (stackType.equals("IgnoreStack")) ? Integer.toString(ab.getUUID()) : stackType;
             if (target.getEffects().containsKey(stackType)) {
                 // remove any existing power that overrides
-                Effect ef = target.getEffects().get(stackType);
+                engine.objects.Effect ef = target.getEffects().get(stackType);
                 AbstractEffectJob effect = null;
                 if (ef != null) {
                     JobContainer jc = ef.getJobContainer();
@@ -1890,7 +1914,7 @@ public enum PowersManager {
         stackType = (stackType.equals("IgnoreStack")) ? Integer
                 .toString(toRemove.getUUID()) : stackType;
         if (fromChant) {
-            Effect eff = awo.getEffects().get(stackType);
+            engine.objects.Effect eff = awo.getEffects().get(stackType);
             if (eff != null)
                 eff.cancelJob(true);
         } else

src/engine/mbEnums.java

@@ -2732,7 +2732,7 @@ public class mbEnums {
         DIAMOND(1580010, 1540225085, -1730704107, 2000, 20),
         GALVOR(1580017, -1683992404, -1596311545, 2000, 5),
         IRON(1580002, -1673518119, 2504297, 2000, 20),
-        LUMBER(1580004, 1628412684, -1603256692, 10000, 100),
+        LUMBER(1580004, -1628412684, -1603256692, 10000, 100),
         MANDRAKE(1580007, 1519910613, 1191391799, 1000, 10),
         MITHRIL(1580021, 626743397, -1761257186, 500, 5),
         OAK(1580005, -1653034775, 74767, 3000, 30),

src/engine/objects/Building.java

@@ -561,7 +561,7 @@ public class Building extends AbstractWorldObject {
                 BuildingManager.setRank(barracksBuilding, -1);
         }
 
-        // If the tree is R8 and deranking, we need to update it's
+        // If the tree is R8 and deranking, we need to update the
         // mesh along with buildings losing their health bonus
 
         if (this.rank == 8) {

src/engine/objects/City.java

@@ -41,6 +41,7 @@ import java.util.HashSet;
 import java.util.Iterator;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.locks.ReentrantReadWriteLock;
 
 public class City extends AbstractWorldObject {
@@ -80,6 +81,7 @@ public class City extends AbstractWorldObject {
     private String hash;
     public Warehouse warehouse;
     public Realm realm;
+    public AtomicBoolean isDestroyed = new AtomicBoolean(false);
 
     /**
      * ResultSet Constructor
@@ -306,6 +308,21 @@ public class City extends AbstractWorldObject {
             if (city.parentZone == null)
                 continue;
 
+            // Can't teleport to something without a tree
+
+            if (city.getTOL() == null)
+                continue;
+
+            // No abandoned cities
+
+            if (city.getTOL().getGuild().isEmptyGuild())
+                continue;
+
+            // No destroyed cities
+
+            if (city.getTOL().getRank() == -1)
+                continue;
+
             //can't repledge to a guild you're already part of
 
             if (repledge && city.getGuild().equals(playerCharacter.guild))
@@ -1102,17 +1119,21 @@ public class City extends AbstractWorldObject {
 
     public final void destroy() {
 
-        Thread destroyCityThread = new Thread(new DestroyCityThread(this));
+        if (this.isDestroyed.compareAndSet(false, true)) {
 
-        destroyCityThread.setName("destroyCity:" + this.getName());
+            Thread destroyCityThread = new Thread(new DestroyCityThread(this));
-        destroyCityThread.start();
+
+            destroyCityThread.setName("destroyCity:" + this.getParent().zoneName);
+            destroyCityThread.start();
+        } else
+            Logger.error("Attempt to destroy destroyed city");
     }
 
     public final void transfer(AbstractCharacter newOwner) {
 
         Thread transferCityThread = new Thread(new TransferCityThread(this, newOwner));
 
-        transferCityThread.setName("TransferCity:" + this.getName());
+        transferCityThread.setName("TransferCity:" + this.getParent().zoneName);
         transferCityThread.start();
     }
 

src/engine/objects/Mine.java

@@ -220,8 +220,7 @@ public class Mine extends AbstractGameObject {
         // Only inactive mines are returned.
 
         for (Mine mine : Mine.mineMap.keySet()) {
-            if (mine.owningGuild.getObjectUUID() == guildID &&
+            if (mine.owningGuild.getObjectUUID() == guildID)
-                    mine.isActive == false)
                 mineList.add(mine);
         }
         return mineList;

src/engine/powers/EffectsBase.java

@@ -26,10 +26,11 @@ import engine.net.client.ClientConnection;
 import engine.net.client.msg.ApplyEffectMsg;
 import engine.objects.AbstractCharacter;
 import engine.objects.AbstractWorldObject;
-import engine.objects.Effect;
 import engine.objects.PlayerCharacter;
 import engine.powers.effectmodifiers.AbstractEffectModifier;
 import engine.server.MBServerStatics;
+import engine.util.Hasher;
+import engine.wpak.data.Effect;
 import org.pmw.tinylog.Logger;
 
 import java.sql.Connection;
@@ -62,7 +63,7 @@ public class EffectsBase {
     // flags
     private boolean isItemEffect;
     private boolean isSpireEffect;
-    private boolean ignoreMod;
+    private boolean ignoreNoMod;
     private boolean dontSave;
     private boolean cancelOnAttack = false;
     private boolean cancelOnAttackSwing = false;
@@ -91,6 +92,33 @@ public class EffectsBase {
 
     }
 
+    //EffectEntry constructor
+    public EffectsBase(Effect entry) {
+        this.IDString = entry.effect_id;
+        this.name = entry.effect_name;
+        this.token = Hasher.SBStringHash(entry.effect_name);
+
+        //override tokens for some effects like Safemode that use the Action Token instead of the effect Token,
+        switch (this.IDString) {
+            case "INVIS-D":
+                this.token = -1661751254;
+                break;
+            case "SafeMode":
+                this.token = -1661750486;
+                break;
+
+        }
+        this.isItemEffect = entry.isItemEffect;
+        this.isSpireEffect = entry.isSpireEffect;
+        this.ignoreNoMod = entry.ignoreNoMod;
+        this.dontSave = entry.dontSave;
+
+        if (this.IDString.startsWith("PRE-"))
+            this.isPrefix = true;
+        else if (this.IDString.startsWith("SUF-"))
+            this.isSuffix = true;
+    }
+
     public EffectsBase(EffectsBase copyEffect, int newToken, String IDString) {
 
         UUID = NewID++;
@@ -102,7 +130,7 @@ public class EffectsBase {
             int flags = 0;
             this.isItemEffect = ((flags & 1) != 0) ? true : false;
             this.isSpireEffect = ((flags & 2) != 0) ? true : false;
-            this.ignoreMod = ((flags & 4) != 0) ? true : false;
+            this.ignoreNoMod = ((flags & 4) != 0) ? true : false;
             this.dontSave = ((flags & 8) != 0) ? true : false;
 
             if (this.IDString.startsWith("PRE-"))
@@ -117,7 +145,7 @@ public class EffectsBase {
         this.amountRamp = copyEffect.amountRamp;
         this.isItemEffect = copyEffect.isItemEffect;
         this.isSpireEffect = copyEffect.isSpireEffect;
-        this.ignoreMod = copyEffect.ignoreMod;
+        this.ignoreNoMod = copyEffect.ignoreNoMod;
         this.dontSave = copyEffect.dontSave;
         this.cancelOnAttack = copyEffect.cancelOnAttack;
         this.cancelOnAttackSwing = copyEffect.cancelOnAttackSwing;
@@ -163,7 +191,7 @@ public class EffectsBase {
         int flags = rs.getInt("flags");
         this.isItemEffect = ((flags & 1) != 0) ? true : false;
         this.isSpireEffect = ((flags & 2) != 0) ? true : false;
-        this.ignoreMod = ((flags & 4) != 0) ? true : false;
+        this.ignoreNoMod = ((flags & 4) != 0) ? true : false;
         this.dontSave = ((flags & 8) != 0) ? true : false;
 
         if (this.IDString.startsWith("PRE-"))
@@ -351,7 +379,7 @@ public class EffectsBase {
     }
 
     public boolean ignoreMod() {
-        return this.ignoreMod;
+        return this.ignoreNoMod;
     }
 
     public boolean dontSave() {
@@ -404,7 +432,7 @@ public class EffectsBase {
                 float duration = ab.getDurationInSeconds(trains);
                 if (pb.getToken() == 1672601862) {
 
-                    Effect eff = awo.getEffects().get("DeathShroud");
+                    engine.objects.Effect eff = awo.getEffects().get("DeathShroud");
 
 
                     if (eff != null) {

src/engine/workthreads/DestroyCityThread.java

@@ -53,123 +53,117 @@ public class DestroyCityThread implements Runnable {
 
         // Member variable assignment
 
-        cityZone = city.getParent();
+        try {
-        newParent = cityZone.parent;
+            cityZone = city.getParent();
-        formerGuild = city.getTOL().getGuild();
+            newParent = cityZone.parent;
+            formerGuild = city.getTOL().getGuild();
 
-        // Former guild loses it's tree!
+            Logger.info("Destroy city thread started for: " + cityZone.zoneName);
 
-        if (DbManager.GuildQueries.SET_GUILD_OWNED_CITY(formerGuild.getObjectUUID(), 0)) {
+            // Former guild loses tree!
 
-            //Successful Update of guild
+            if (DbManager.GuildQueries.SET_GUILD_OWNED_CITY(formerGuild.getObjectUUID(), 0)) {
 
-            formerGuild.setGuildState(mbEnums.GuildState.Errant);
+                //Successful Update of guild
-            formerGuild.setNation(null);
-            formerGuild.setCityUUID(0);
-            GuildManager.updateAllGuildTags(formerGuild);
-            GuildManager.updateAllGuildBinds(formerGuild, null);
-        }
 
-        // By losing the tree, the former owners lose all of their subguilds.
+                formerGuild.setGuildState(mbEnums.GuildState.Errant);
-
+                formerGuild.setNation(null);
-        if (!formerGuild.getSubGuildList().isEmpty()) {
+                formerGuild.setCityUUID(0);
-
+                GuildManager.updateAllGuildTags(formerGuild);
-            subGuildList = new ArrayList<>();
+                GuildManager.updateAllGuildBinds(formerGuild, null);
-
-            subGuildList.addAll(formerGuild.getSubGuildList());
-
-            for (Guild subGuild : subGuildList) {
-                formerGuild.removeSubGuild(subGuild);
-            }
-        }
-
-        Building tol = null;
-
-        // Build list of buildings within this parent zone
-
-        for (Building cityBuilding : cityZone.zoneBuildingSet) {
-
-            // Sanity Check in case player deletes the building
-            // before this thread can get to it
-
-            if (cityBuilding == null)
-                continue;
-
-            // Do nothing with the banestone.  It will be removed elsewhere
-
-            if (cityBuilding.getBlueprint().getBuildingGroup().equals(mbEnums.BuildingGroup.BANESTONE))
-                continue;
-
-            // TOL is processed after all other structures in the city zone
-
-            if (cityBuilding.getBlueprint().getBuildingGroup().equals(mbEnums.BuildingGroup.TOL)) {
-                tol = cityBuilding;
-                continue;
             }
 
-            // All buildings are moved to a location relative
+            // By losing the tree, the former owners lose all of their subguilds.
-            // to their new parent zone
 
-            localCoords = ZoneManager.worldToLocal(cityBuilding.getLoc(), newParent);
+            if (!formerGuild.getSubGuildList().isEmpty()) {
 
-            DbManager.BuildingQueries.MOVE_BUILDING(cityBuilding.getObjectUUID(), newParent.getObjectUUID(), localCoords.x, localCoords.y, localCoords.z);
+                subGuildList = new ArrayList<>();
 
-            // All buildings are re-parented to a zone one node
+                subGuildList.addAll(formerGuild.getSubGuildList());
-            // higher in the tree (continent) as we will be
-            // deleting the city zone very shortly.
 
-            if (cityBuilding.getParentZoneID() != newParent.getParentZoneID())
+                for (Guild subGuild : subGuildList) {
-                cityBuilding.setParentZone(newParent);
+                    formerGuild.removeSubGuild(subGuild);
-
+                }
-            // No longer a tree, no longer any protection contract!
-
-            cityBuilding.setProtectionState(mbEnums.ProtectionState.NONE);
-
-            // Remove warehouse entry if one exists.
-
-            if (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.WAREHOUSE) {
-                DbManager.WarehouseQueries.DELETE_WAREHOUSE(city.warehouse);
-                city.warehouse = null;
             }
 
-            // Destroy all remaining city assets
+            // Build list of buildings within this parent zone
 
-            if ((cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.BARRACK)
+            ArrayList<Building> destroySet = new ArrayList<>();
-                    || (cityBuilding.getBlueprint().isWallPiece())
-                    || (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.SHRINE)
-                    || (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.TOL)
-                    || (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.SPIRE)
-                    || (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.WAREHOUSE)) {
 
-                if (cityBuilding.getRank() != -1)
+            for (Building cityBuilding : cityZone.zoneBuildingSet) {
-                    BuildingManager.setRank(cityBuilding, -1);
+
+                // Sanity Check in case player deletes the building
+                // before this thread can get to it
+
+                if (cityBuilding == null)
+                    continue;
+
+                // Do nothing with the banestone.  It will be removed elsewhere
+
+                if (cityBuilding.getBlueprint().getBuildingGroup().equals(mbEnums.BuildingGroup.BANESTONE))
+                    continue;
+
+                // All buildings are moved to a location relative
+                // to their new parent zone
+
+                localCoords = ZoneManager.worldToLocal(cityBuilding.getLoc(), newParent);
+
+                DbManager.BuildingQueries.MOVE_BUILDING(cityBuilding.getObjectUUID(), newParent.getObjectUUID(), localCoords.x, localCoords.y, localCoords.z);
+
+                // All buildings are re-parented to a zone one node
+                // higher in the tree (continent) as we will be
+                // deleting the city zone very shortly.
+
+                if (cityBuilding.getParentZoneID() != newParent.getParentZoneID())
+                    cityBuilding.setParentZone(newParent);
+
+                // No longer a tree, no longer any protection contract!
+
+                cityBuilding.setProtectionState(mbEnums.ProtectionState.NONE);
+
+                // Remove warehouse entry if one exists.
+
+                if (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.WAREHOUSE) {
+                    DbManager.WarehouseQueries.DELETE_WAREHOUSE(city.warehouse);
+                    city.warehouse = null;
+                }
+
+                // Mark all auto protected buildings for destruction
+
+                if ((cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.BARRACK) || (cityBuilding.getBlueprint().isWallPiece()) || (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.SHRINE) || (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.TOL) || (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.SPIRE) || (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.WAREHOUSE))
+                    destroySet.add(cityBuilding);
             }
+
+            // Destroy set of auto-protected buildings
+
+            for (Building building : destroySet)
+                if (building.getRank() != -1)
+                    BuildingManager.setRank(building, -1);
+
+            if (city.realm != null) {
+                city.realm.removeCity(city.getObjectUUID());
+                city.realm = null;
+            }
+
+            // It's now safe to delete the city zone from the database
+            // which will cause a cascade delete of everything else
+
+            if (!DbManager.ZoneQueries.DELETE_ZONE(cityZone)) {
+                Logger.error("DestroyCityThread", "Database error when deleting city zone: " + cityZone.getObjectUUID());
+                return;
+            }
+
+            // Refresh the city for map requests
+
+            City.lastCityUpdate = System.currentTimeMillis();
+
+        } catch (Exception e) {
+            Logger.error(e);
         }
 
-        // Destroy the tol
-
-        if (tol != null)
-            BuildingManager.setRank(tol, -1);
-
-        if (city.realm != null)
-            city.realm.removeCity(city.getObjectUUID());
-
-        // It's now safe to delete the city zone from the database
-        // which will cause a cascade delete of everything else
-
-
-        if (DbManager.ZoneQueries.DELETE_ZONE(cityZone) == false) {
-            Logger.error("DestroyCityThread", "Database error when deleting city zone: " + cityZone.getObjectUUID());
-            return;
-        }
-
-        // Refresh the city for map requests
-
-        City.lastCityUpdate = System.currentTimeMillis();
-
         // Zone and city should vanish upon next reboot
         // if the codebase reaches here.
 
-        Logger.info(city.getParent().zoneName + " uuid:" + city.getObjectUUID() + "has been destroyed!");
+        Logger.info(city.getParent().zoneName + " uuid: " + city.getObjectUUID() + " has been destroyed!");
     }
 }

src/engine/wpak/EffectsParser.java

@@ -10,22 +10,22 @@ package engine.wpak;
 
 import engine.gameManager.ConfigManager;
 import engine.mbEnums;
-import engine.wpak.data.EffectEntry;
+import engine.wpak.data.ConditionEntry;
-import engine.wpak.data.EffectModifier;
+import engine.wpak.data.Effect;
+import engine.wpak.data.ModifierEntry;
 import org.pmw.tinylog.Logger;
 
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Paths;
-import java.util.ArrayList;
+import java.util.*;
-import java.util.HashMap;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
 public class EffectsParser {
 
     public static String effectsPath = ConfigManager.DEFAULT_DATA_DIR + "wpak/Effects.cfg";
-    public static HashMap<String, EffectEntry> effect_data = new HashMap<>();
+    public static HashMap<String, Effect> effect_data = new HashMap<>();
     private static final Pattern EFFECT_REGEX = Pattern.compile("(?<=EFFECTBEGIN)(.+?)(?=EFFECTEND)", Pattern.DOTALL);
     private static final Pattern SOURCE_REGEX = Pattern.compile("(?<=SOURCEBEGIN)(.+?)(?=SOURCEEND)", Pattern.DOTALL);
     private static final Pattern MODS_REGEX = Pattern.compile("(?<=MODSBEGIN)(.+?)(?=MODSEND)", Pattern.DOTALL);
@@ -36,13 +36,14 @@ public class EffectsParser {
 
         // Read .wpak file from disk
 
-        byte[] fileData = null;
+        byte[] fileData;
 
         try {
             fileData = Files.readAllBytes(Paths.get(effectsPath));
         } catch (IOException e) {
             throw new RuntimeException(e);
         }
+
         String fileContents = new String(fileData);
 
         // Iterate over effect entries from .wpak data
@@ -50,14 +51,21 @@ public class EffectsParser {
         Matcher matcher = EFFECT_REGEX.matcher(fileContents);
 
         while (matcher.find()) {
-            EffectEntry effectEntry = parseEffectEntry(matcher.group());
+            Effect effect = parseEffectEntry(matcher.group());
-            effect_data.put(effectEntry.effect_id, effectEntry);
+            effect_data.put(effect.effect_id, effect);
         }
     }
 
-    private static EffectEntry parseEffectEntry(String effectData) {
+    private static Effect parseEffectEntry(String effectData) {
-        
+
-        EffectEntry effectEntry = new EffectEntry();
+        Effect effect = new Effect();
+
+        // Parse fields that lie outside the other tags
+
+        effect.isItemEffect = effectData.contains("IsItemEffect");
+        effect.isSpireEffect = effectData.contains("IsSpireEffect");
+        effect.ignoreNoMod = effectData.contains("IgnoreNoMod");
+        effect.dontSave = effectData.contains("DontSave");
 
         // Remove all lines that contain a # and leading/trailing blank lines
 
@@ -82,24 +90,24 @@ public class EffectsParser {
         while (matcher.find())
             effectHeader.add(matcher.group().trim());
 
-        effectEntry.effect_id = effectHeader.get(0);
+        effect.effect_id = effectHeader.get(0);
-        effectEntry.effect_name = effectHeader.get(1);
+        effect.effect_name = effectHeader.get(1);
-        effectEntry.effect_name = effectEntry.effect_name.replaceAll("\"", "");
+        effect.effect_name = effect.effect_name.replaceAll("\"", "");
 
         // Some effect mods have no icon
         // (SEEINVIS-SHADE "See Invis")
 
         if (effectHeader.size() == 3)
-            effectEntry.icon = Integer.parseInt(effectHeader.get(2));
+            effect.icon = Integer.parseInt(effectHeader.get(2));
         else
-            effectEntry.icon = 0;
+            effect.icon = 0;
 
         // Parse source entries
 
         matcher = SOURCE_REGEX.matcher(effectData);
 
         while (matcher.find())
-            effectEntry.sources.add(matcher.group().trim());
+            effect.sources.add(matcher.group().trim());
 
         // Parse modifier entries
 
@@ -108,8 +116,8 @@ public class EffectsParser {
         // Iterate effect entries from .wpak config data
 
         while (matcher.find()) {
-            EffectModifier effectModifier = parseModEntry(matcher.group());
+            ModifierEntry modifierEntry = parseModEntry(matcher.group());
-            effectEntry.mods.add(effectModifier);
+            effect.mods.add(modifierEntry);
         }
 
         // Parse Conditions
@@ -120,17 +128,29 @@ public class EffectsParser {
             String[] conditions = matcher.group().trim().split("\n");
 
             for (String condition : conditions) {
-                String[] parameters = condition.trim().split("\\s+");
+                List<String> parameters = Arrays.asList(condition.trim().split("\\s+"));
-                effectEntry.conditions.put(parameters[0], Float.parseFloat(parameters[1]));
+                Iterator<String> iterator = parameters.iterator();
+
+                ConditionEntry conditionEntry = new ConditionEntry();
+                conditionEntry.condition = iterator.next();
+                conditionEntry.arg = Integer.parseInt(iterator.next());
+
+                if (iterator.hasNext())
+                    conditionEntry.curveType = mbEnums.CompoundCurveType.valueOf(iterator.next());
+
+                while (iterator.hasNext())
+                    conditionEntry.damageTypes.add(mbEnums.DamageType.valueOf(iterator.next().toUpperCase()));
+
+                effect.conditions.add(conditionEntry);
             }
         }
 
-        return effectEntry;
+        return effect;
     }
 
-    private static EffectModifier parseModEntry(String modData) {
+    private static ModifierEntry parseModEntry(String modData) {
 
-        EffectModifier effectModifier = new EffectModifier();
+        ModifierEntry modifierEntry = new ModifierEntry();
 
         String[] modEntries = modData.trim().split("\n");
 
@@ -142,40 +162,22 @@ public class EffectsParser {
             while (matcher.find())
                 modValues.add(matcher.group().trim());
 
-            effectModifier.type = mbEnums.ModType.valueOf(modValues.get(0).trim());
+            modifierEntry.type = mbEnums.ModType.valueOf(modValues.get(0).trim());
 
-            switch (effectModifier.type) {
+            switch (modifierEntry.type) {
-                case BladeTrails:  // No parm modifiers
-                case ImmuneToAttack:
-                case ImmuneToPowers:
-                case Ambidexterity:
-                case Silenced:
-                case IgnorePassiveDefense:
-                case Stunned:
-                case PowerCostHealth:
-                case Charmed:
-                case Fly:
-                case CannotMove:
-                case CannotTrack:
-                case CannotAttack:
-                case CannotCast:
-                case SpireBlock:
-                case Invisible:
-                case SeeInvisible:
-                    break;
                 case AnimOverride:
-                    effectModifier.min = Float.parseFloat(modValues.get(1).trim());
+                    modifierEntry.min = Float.parseFloat(modValues.get(1).trim());
-                    effectModifier.max = Float.parseFloat(modValues.get(2).trim());
+                    modifierEntry.max = Float.parseFloat(modValues.get(2).trim());
                     break;
                 case Health:
                 case Mana:
                 case Stamina:
-                    effectModifier.min = Float.parseFloat(modValues.get(1).trim());
+                    modifierEntry.min = Float.parseFloat(modValues.get(1).trim());
-                    effectModifier.max = Float.parseFloat(modValues.get(2).trim());
+                    modifierEntry.max = Float.parseFloat(modValues.get(2).trim());
-                    effectModifier.scale = Float.parseFloat(modValues.get(3).trim());
+                    modifierEntry.value = Float.parseFloat(modValues.get(3).trim());
                     // Parameter 4 is always 0.
-                    effectModifier.compoundCurveType = mbEnums.CompoundCurveType.valueOf(modValues.get(5).trim());
+                    modifierEntry.compoundCurveType = mbEnums.CompoundCurveType.valueOf(modValues.get(5).trim());
-                    effectModifier.arg1 = modValues.get(6).trim();
+                    modifierEntry.arg1 = modValues.get(6).trim();
                     break;
                 case Attr:
                 case Resistance:
@@ -190,12 +192,12 @@ public class EffectsParser {
                 case Slay:
                 case Fade:
                 case Durability:
-                    effectModifier.min = Float.parseFloat(modValues.get(1).trim());
+                    modifierEntry.min = Float.parseFloat(modValues.get(1).trim());
-                    effectModifier.scale = Float.parseFloat(modValues.get(2).trim());
+                    modifierEntry.max = Float.parseFloat(modValues.get(2).trim());
-                    effectModifier.compoundCurveType = mbEnums.CompoundCurveType.valueOf(modValues.get(3).trim());
+                    modifierEntry.compoundCurveType = mbEnums.CompoundCurveType.valueOf(modValues.get(3).trim());
 
                     if (modValues.size() > 4)
-                        effectModifier.arg1 = modValues.get(4).trim();   // Some HeathFull entries do not have an argument
+                        modifierEntry.arg1 = modValues.get(4).trim();   // Some HeathFull entries do not have an argument
                     break;
                 case MeleeDamageModifier:
                 case OCV:
@@ -216,44 +218,62 @@ public class EffectsParser {
                 case Block:
                 case Parry:
                 case Dodge:
+                case WeaponRange:
                 case ScanRange:
                 case ScaleHeight:
                 case ScaleWidth:
-                case WeaponRange:
+                    modifierEntry.min = Float.parseFloat(modValues.get(1).trim());
-                    effectModifier.min = Float.parseFloat(modValues.get(1).trim());
+                    modifierEntry.max = Float.parseFloat(modValues.get(2).trim());
-                    effectModifier.scale = Float.parseFloat(modValues.get(2).trim());
+                    modifierEntry.compoundCurveType = mbEnums.CompoundCurveType.valueOf(modValues.get(3).trim());
-                    effectModifier.compoundCurveType = mbEnums.CompoundCurveType.valueOf(modValues.get(3).trim());
                     break;
                 case ItemName:
                 case BlockedPowerType:
                 case ImmuneTo:
                 case BlackMantle:
-                    effectModifier.arg1 = modValues.get(1).trim();
+                    modifierEntry.arg1 = modValues.get(1).trim();
 
                     // Some BlockedPowerType entries have only one argument
 
                     if (modValues.size() > 2)
-                        effectModifier.arg2 = modValues.get(2).trim();
+                        modifierEntry.arg2 = modValues.get(2).trim();
                     break;
                 case NoMod:
                 case ConstrainedAmbidexterity:
                 case ProtectionFrom:
                 case ExclusiveDamageCap:
                 case IgnoreDamageCap:
-                    effectModifier.arg1 = modValues.get(1).trim();
+                    modifierEntry.arg1 = modValues.get(1).trim();
                     break;
                 case WeaponProc:
-                    effectModifier.min = Float.parseFloat(modValues.get(1).trim());
+                    modifierEntry.min = Float.parseFloat(modValues.get(1).trim());
-                    effectModifier.arg1 = modValues.get(2).trim();
+                    modifierEntry.arg1 = modValues.get(2).trim();
-                    effectModifier.scale = Float.parseFloat(modValues.get(3).trim());
+                    modifierEntry.max = Float.parseFloat(modValues.get(3).trim());
+                    break;
+                case BladeTrails:  // These tags have no parms or are not parsed
+                case ImmuneToAttack:
+                case ImmuneToPowers:
+                case Ambidexterity:
+                case Silenced:
+                case IgnorePassiveDefense:
+                case Stunned:
+                case PowerCostHealth:
+                case Charmed:
+                case Fly:
+                case CannotMove:
+                case CannotTrack:
+                case CannotAttack:
+                case CannotCast:
+                case SpireBlock:
+                case Invisible:
+                case SeeInvisible:
                     break;
                 default:
-                    Logger.error("Unhandled type: " + effectModifier.type);
+                    Logger.error("Unhandled type: " + modifierEntry.type);
                     break;
             }
         }
 
-        return effectModifier;
+        return modifierEntry;
     }
 
 }

src/engine/wpak/PowerActionParser.java

@@ -9,11 +9,20 @@
 package engine.wpak;
 
 import engine.gameManager.ConfigManager;
-import engine.wpak.data.PowerActionEntry;
+import engine.mbEnums;
+import engine.wpak.data.Effect;
+import engine.wpak.data.PowerAction;
+import engine.wpak.data.StatTransfer;
+import engine.wpak.data.TrackEntry;
+import org.pmw.tinylog.Logger;
 
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Iterator;
+import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
@@ -30,8 +39,7 @@ public class PowerActionParser {
 
         try {
             fileData = Files.readAllBytes(Paths.get(powerActionPath));
-        } catch (
+        } catch (IOException e) {
-                IOException e) {
             throw new RuntimeException(e);
         }
 
@@ -43,15 +51,255 @@ public class PowerActionParser {
 
         while (matcher.find()) {
 
-            PowerActionEntry powerActionEntry = parsePowerActionEntry(matcher.group().trim());
+            PowerAction powerAction = parsePowerActionEntry(matcher.group().trim());
 
         }
     }
 
-    private static PowerActionEntry parsePowerActionEntry(String powerActionData) {
+    private static PowerAction parsePowerActionEntry(String powerActionData) {
 
-        PowerActionEntry powerActionEntry = new PowerActionEntry();
+        PowerAction powerAction = new PowerAction();
+        Effect effect;
+        StatTransfer statTransfer;
+        TrackEntry trackEntry;
 
-        return powerActionEntry;
+        // Remove all lines that contain a # and leading/trailing blank lines
+
+        powerActionData = powerActionData.replaceAll("(?m)^(\\s*#.*|\\s*)\r?\n?", "").trim();
+
+        List<String> lineData = Arrays.asList(powerActionData.split("\n"));
+
+        // Parse effect entry header
+
+        Iterator<String> entryIterator = lineData.iterator();
+        String headerLine = entryIterator.next();
+        List<String> headerData = new ArrayList<>();
+
+        Matcher matcher = STRSPLIT_REGEX.matcher(headerLine.trim());
+
+        while (matcher.find())
+            headerData.add(matcher.group().trim());
+
+        Iterator<String> headerIterator = headerData.iterator();
+        powerAction.action_id = headerIterator.next();
+        powerAction.action_type = headerIterator.next();
+
+        switch (powerAction.action_type) {
+            case "RemoveEffect":
+                effect = new Effect();
+                effect.effect_id = headerIterator.next();
+                powerAction.effects.add(effect);
+                break;
+            case "CreateMob":
+                powerAction.petLevel = Integer.parseInt(headerIterator.next());
+                powerAction.petRace = Integer.parseInt(headerIterator.next());
+                break;
+            case "DamageOverTime":
+                effect = new Effect();
+                effect.effect_id = headerIterator.next();
+                effect.cycleDuration = Integer.parseInt(headerIterator.next());
+                effect.cycleDelay = Integer.parseInt(headerIterator.next());
+                powerAction.effects.add(effect);
+                break;
+            case "ApplyEffects":
+                int level = Integer.parseInt(headerIterator.next());
+
+                while (headerIterator.hasNext()) {
+                    effect = new Effect();
+                    effect.level = level;
+                    effect.effect_id = headerIterator.next();
+                    powerAction.effects.add(effect);
+                }
+                break;
+            case "Transform":
+            case "Invis":
+            case "ApplyEffect":
+            case "DeferredPower":
+            case "DirectDamage":
+            case "SpireDisable":
+                while (headerIterator.hasNext()) {
+                    effect = new Effect();
+                    effect.effect_id = headerIterator.next();
+
+                    // Some applyEffect entries are naked withot a level
+
+                    if (headerData.size() > 3)
+                        effect.level = Integer.parseInt(headerIterator.next());
+
+                    powerAction.effects.add(effect);
+                }
+                break;
+            case "TransferStat":
+                statTransfer = new StatTransfer();
+                statTransfer.fromStat = mbEnums.CostType.valueOf(headerIterator.next());
+                statTransfer.toStat = mbEnums.CostType.valueOf(headerIterator.next());
+                statTransfer.fromStatValue = Float.parseFloat(headerIterator.next());
+                statTransfer.fromCurve = mbEnums.CompoundCurveType.valueOf(headerIterator.next());
+                statTransfer.toStatValue = Float.parseFloat(headerIterator.next());
+                statTransfer.toCurve = mbEnums.CompoundCurveType.valueOf(headerIterator.next());
+                statTransfer.fromStatBool = Boolean.parseBoolean(headerIterator.next());
+                statTransfer.toStatBool = Boolean.parseBoolean(headerIterator.next());
+                powerAction.statTransfer = statTransfer;
+                break;
+            case "TransferStatOT":
+                statTransfer = new StatTransfer();
+                statTransfer.fromStat = mbEnums.CostType.valueOf(headerIterator.next());
+                statTransfer.toStat = mbEnums.CostType.valueOf(headerIterator.next());
+                statTransfer.fromStatValue = Float.parseFloat(headerIterator.next());
+                statTransfer.fromCurve = mbEnums.CompoundCurveType.valueOf(headerIterator.next());
+                statTransfer.toStatValue = Float.parseFloat(headerIterator.next());
+                statTransfer.toCurve = mbEnums.CompoundCurveType.valueOf(headerIterator.next());
+                statTransfer.fromStatBool = Boolean.parseBoolean(headerIterator.next());
+                statTransfer.toStatBool = Boolean.parseBoolean(headerIterator.next());
+                statTransfer.transfer_action = headerIterator.next();
+                statTransfer.transfer_ticks = Integer.parseInt(headerIterator.next());
+                powerAction.statTransfer = statTransfer;
+                break;
+            case "Charm":
+                effect = new Effect();
+                effect.effect_id = headerIterator.next();
+                effect.level = Integer.parseInt(headerIterator.next());
+                effect.type = headerIterator.next();
+                powerAction.effects.add(effect);
+                break;
+            case "Block":
+                effect = new Effect();
+                effect.effect_id = headerIterator.next();
+                effect.level = Integer.parseInt(headerIterator.next());
+                powerAction.effects.add(effect);
+                break;
+            case "Resurrect":
+                powerAction.levelCap = Integer.parseInt(headerIterator.next());
+                break;
+            case "SetItemFlag":
+                powerAction.itemFlag = mbEnums.ItemFlags.valueOf(headerIterator.next());
+                break;
+            case "Track":
+                trackEntry = new TrackEntry();
+                trackEntry.action_id = headerIterator.next();
+                trackEntry.unknown1 = Boolean.parseBoolean(headerIterator.next());
+                trackEntry.unknown2 = Boolean.parseBoolean(headerIterator.next());
+                trackEntry.type = headerIterator.next();
+                trackEntry.min = Integer.parseInt(headerIterator.next());
+                trackEntry.max = Integer.parseInt(headerIterator.next());
+                powerAction.trackEntry = trackEntry;
+                break;
+            case "Recall": // No arguments for these tags or not parsed
+            case "Summon":
+            case "Teleport":
+            case "TreeChoke":
+            case "SimpleDamage":
+            case "MobRecall": // One argument always zero
+            case "ClearAggro":
+            case "ClearNearbyAggro":
+            case "Peek":
+            case "ClaimMine":
+            case "RunegateTeleport":
+            case "Steal":
+                break;
+            default:
+                Logger.error("Unhandled type " + powerAction.action_type + " for Pow4erAction: " + powerAction.action_id);
+                break;
+        }
+
+        // Process key value pairs after header
+
+        while (entryIterator.hasNext()) {
+            String lineValue = entryIterator.next();
+            List<String> lineValues = Arrays.asList(lineValue.split("="));
+            String key = lineValues.get(0).trim();
+            List<String> arguments;
+
+            switch (key) {
+                case "BODYPARTS":
+                    arguments = Arrays.asList(lineValues.get(1).trim().split("\\s+"));
+
+                    for (String bodyPart : arguments)
+                        powerAction.bodyparts.add(Integer.parseInt(bodyPart));
+                    break;
+                case "FEMALEBODYPARTS":
+                    arguments = Arrays.asList(lineValues.get(1).trim().split("\\s+"));
+
+                    for (String bodyPart : arguments)
+                        powerAction.femaleBodyParts.add(Integer.parseInt(bodyPart));
+                    break;
+                case "SCALEFACTOR":
+                    arguments = Arrays.asList(lineValues.get(1).trim().split("\\s+"));
+
+                    for (String scaleFactor : arguments)
+                        powerAction.scaleFactor.add(Float.parseFloat(scaleFactor));
+                    break;
+                case "ISRESISTABLE":
+                    powerAction.isResistible = Boolean.parseBoolean(lineValues.get(1).trim());
+                    break;
+                case "ISAGGRESSIVE":
+                    powerAction.isAggressive = Boolean.parseBoolean(lineValues.get(1).trim());
+                    break;
+                case "BLADETRAILS":
+                    powerAction.bladeTrails = Boolean.parseBoolean(lineValues.get(1).trim());
+                    break;
+                case "SHOULDSHOWWEAPONS":
+                    powerAction.shouldShowWeapons = Boolean.parseBoolean(lineValues.get(1).trim());
+                    break;
+                case "SHOULDSHOWARMOR":
+                    powerAction.shouldShowArmor = Boolean.parseBoolean(lineValues.get(1).trim());
+                    break;
+                case "APPLYEFFECTBLANK":
+                    powerAction.applyEffectBlank = Boolean.parseBoolean(lineValues.get(1).trim());
+                    break;
+                case "WEAROFFEFFECTBLANK":
+                    powerAction.wearOffEffectBlank = Boolean.parseBoolean(lineValues.get(1).trim());
+                    break;
+                case "ATTACKANIMS":
+                    arguments = Arrays.asList(lineValues.get(1).trim().split("\\s+"));
+
+                    for (String animation : arguments)
+                        powerAction.attackAnimations.add(Integer.parseInt(animation));
+                    break;
+                case "REMOVEALL":
+                    powerAction.removeAll = Boolean.parseBoolean(lineValues.get(1).trim());
+                    break;
+                case "EFFECTID":
+                    effect = new Effect();
+                    effect.effect_id = lineValues.get(1).trim();
+                    powerAction.effects.add(effect);
+                    break;
+                case "LEVELCAP":
+                    arguments = Arrays.asList(lineValues.get(1).trim().split("\\s+"));
+                    powerAction.levelCap = Integer.parseInt(arguments.get(0));
+
+                    if (arguments.size() > 1)  // Not all level caps have a curve
+                        powerAction.levelCurve = mbEnums.CompoundCurveType.valueOf(arguments.get(1));
+                    break;
+                case "CLEARAGGRO":
+                    powerAction.clearAggro = Boolean.parseBoolean(lineValues.get(1).trim());
+                    break;
+                case "TARGETBECOMESPET":
+                    powerAction.targetBecomesPet = Boolean.parseBoolean(lineValues.get(1).trim());
+                    break;
+                case "DESTROYOLDPET":
+                    powerAction.destroyOldPet = Boolean.parseBoolean(lineValues.get(1).trim());
+                    break;
+                case "DAMAGETYPE":
+                    powerAction.damageType = mbEnums.DamageType.valueOf(lineValues.get(1).trim().toUpperCase());
+                    break;
+                case "ROOTFSMID":
+                    powerAction.rootFsmID = mbEnums.MobBehaviourType.valueOf(lineValues.get(1).trim());
+                    break;
+                case "SPLASHDAMAGE":
+                    arguments = Arrays.asList(lineValues.get(1).trim().split("\\s+"));
+                    powerAction.splashDamageMin = Integer.parseInt(arguments.get(0));
+                    powerAction.splashDamageMax = Integer.parseInt(arguments.get(1));
+                    break;
+                case "APPLYEFFECTOTHER":
+                case "APPLYEFFECTSELF":
+                case "WEAROFFEFFECTOTHER": // Keys not parsed go here.
+                case "WEAROFFEFFECTSELF":
+                    break;
+                default:
+                    Logger.error("Unhandled variable type:" + key + " for powerAction: " + powerAction.action_id);
+            }
+        }
+        return powerAction;
     }
 }

src/engine/wpak/PowersParser.java

@@ -18,6 +18,7 @@ import java.nio.file.Files;
 import java.nio.file.Paths;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
@@ -48,267 +49,264 @@ public class PowersParser {
 
         while (matcher.find()) {
 
-            PowerEntry powerEntry = parsePowerEntry(matcher.group().trim());
+            Power power = parsePowerEntry(matcher.group().trim());
 
         }
     }
 
-    private static PowerEntry parsePowerEntry(String powerData) {
+    private static Power parsePowerEntry(String powerData) {
 
-        PowerEntry powerEntry = new PowerEntry();
+        Power powerEntry = new Power();
+        StringBuilder conditionBuilder = new StringBuilder();
+        StringBuilder powerBuilder = new StringBuilder();
+        String conditionString;
+        String powerString;
+        java.util.Iterator<String> iterator;
+        java.util.Iterator<String> argumentIterator;
+        int endPos = 0;
 
-        try {
+        // Separate out any conditions from the power data
 
-            StringBuilder conditionString = new StringBuilder();
+        Matcher matcher = CONDITION_REGEX.matcher(powerData);
-            StringBuilder powerString = new StringBuilder();
 
-            int endPos = 0;
+        while (matcher.find()) {
+            conditionBuilder.append(matcher.group().trim());
+            powerBuilder.append(powerData, endPos, matcher.start());
+            endPos = matcher.end();
+        }
 
-            // Separate out any conditions from the power data
+        powerBuilder.append(powerData.substring(endPos));
 
-            Matcher matcher = CONDITION_REGEX.matcher(powerData);
+        // Cleanup dangling tags and lines that contain a # and leading/trailing blank lines
 
-            while (matcher.find()) {
+        powerString = powerBuilder.toString().replaceAll("CONDITIONBEGINCONDITIONEND", "")
-                conditionString.append(matcher.group().trim());
+                .replaceAll("(?m)^(\\s*#.*|\\s*)\r?\n?", "");
-                powerString.append(powerData, endPos, matcher.start());
+        conditionString = conditionBuilder.toString().replaceAll("(?m)^(\\s*#.*|\\s*)\r?\n?", "");
-                endPos = matcher.end();
-            }
 
-            powerString.append(powerData.substring(endPos));
+        // Parse header line in power data
 
-            // Cleanup dangling tags and lines that contain a # and leading/trailing blank lines
+        List<String> lineData = Arrays.asList(powerString.trim().split("\n"));
+        List<String> powerHeader = new ArrayList<>();
 
-            powerString = new StringBuilder(powerString.toString().replaceAll("CONDITIONBEGINCONDITIONEND", ""));
+        String headerString = lineData.get(0);
-            powerString = new StringBuilder(powerString.toString().replaceAll("(?m)^(\\s*#.*|\\s*)\r?\n?", ""));
+        headerString = headerString.replace("\n", " ");
 
-            conditionString = new StringBuilder(conditionString.toString().replaceAll("(?m)^(\\s*#.*|\\s*)\r?\n?", ""));
+        matcher = STRSPLIT_REGEX.matcher(headerString);
 
-            // Parse header line in power data
+        while (matcher.find())
+            powerHeader.add(matcher.group().trim());
 
-            String[] lineData = powerString.toString().trim().split("\n");
+        iterator = powerHeader.iterator();
-            ArrayList<String> powerHeader = new ArrayList<>();
 
-            String headerString = lineData[0];
+        powerEntry.power_id = iterator.next();
-            headerString = headerString.replace("\n", " ");
+        powerEntry.power = iterator.next().replaceAll("\"", "");
 
-            matcher = STRSPLIT_REGEX.matcher(headerString);
+        PowerEntry power = new PowerEntry();
+        power.power_type = mbEnums.PowerType.valueOf(iterator.next());
+        power.icon = Integer.parseInt(iterator.next());
+        power.powerBase = iterator.next().replaceAll("\"", "");
+        powerEntry.powers.add(power);
 
-            while (matcher.find())
+        String nextValue = iterator.next();
-                powerHeader.add(matcher.group().trim());
 
-            java.util.Iterator<String> iterator = powerHeader.iterator();
+        // Account for second definition
 
-            powerEntry.power_id = iterator.next();
+        if (nextValue.equals("SPELL") || nextValue.equals("SKILL")) {
-            powerEntry.power = iterator.next().replaceAll("\"", "");
+            power = new PowerEntry();
-
+            power.power_type = mbEnums.PowerType.valueOf(nextValue);
-            PowerData power = new PowerData();
-            power.power_type = mbEnums.PowerType.valueOf(iterator.next());
             power.icon = Integer.parseInt(iterator.next());
             power.powerBase = iterator.next().replaceAll("\"", "");
             powerEntry.powers.add(power);
+            powerEntry.target_type = mbEnums.PowerTargetType.valueOf(iterator.next());
+        } else
+            powerEntry.target_type = mbEnums.PowerTargetType.valueOf(nextValue);
 
-            String nextValue = iterator.next();
+        powerEntry.range = Integer.parseInt(iterator.next());
+        powerEntry.areaType = mbEnums.AreaType.valueOf(iterator.next());
+        powerEntry.areaRange = Integer.parseInt(iterator.next());
+        powerEntry.excludeType = mbEnums.ExcludeType.valueOf(iterator.next());
+        powerEntry.costType = mbEnums.CostType.valueOf(iterator.next());
+        powerEntry.cost = Float.parseFloat(iterator.next());
+        powerEntry.difficulty = Float.parseFloat(iterator.next());
+        powerEntry.precision = Float.parseFloat(iterator.next());
+        // Cleanup init_time in client data which is 0.35.1 or some such
+        powerEntry.init_time = Float.parseFloat(iterator.next().replaceAll("(\\.0)+$", ""));
+        powerEntry.release_time = Float.parseFloat(iterator.next());
+        powerEntry.recycle_time = Float.parseFloat(iterator.next());
+        powerEntry.hitRollYN = Integer.parseInt(iterator.next());
+        powerEntry.castingMode = mbEnums.CastingModeType.valueOf(iterator.next());
+        powerEntry.initAmin = Integer.parseInt(iterator.next());
+        powerEntry.releaseAnim = Integer.parseInt(iterator.next());
+        powerEntry.targetSelect = mbEnums.TargetSelectType.valueOf(iterator.next());
 
-            // Account for second definition
+        // Process key value pairs after header
 
-            if (nextValue.equals("SPELL") || nextValue.equals("SKILL")) {
+        iterator = lineData.iterator();
-                power = new PowerData();
+        iterator.next(); // Ignore header
-                power.power_type = mbEnums.PowerType.valueOf(nextValue);
-                power.icon = Integer.parseInt(iterator.next());
-                power.powerBase = iterator.next().replaceAll("\"", "");
-                powerEntry.powers.add(power);
-                powerEntry.target_type = mbEnums.PowerTargetType.valueOf(iterator.next());
-            } else
-                powerEntry.target_type = mbEnums.PowerTargetType.valueOf(nextValue);
 
-            powerEntry.range = Integer.parseInt(iterator.next());
+        while (iterator.hasNext()) {
-            powerEntry.areaType = mbEnums.AreaType.valueOf(iterator.next());
-            powerEntry.areaRange = Integer.parseInt(iterator.next());
-            powerEntry.excludeType = mbEnums.ExcludeType.valueOf(iterator.next());
-            powerEntry.costType = mbEnums.CostType.valueOf(iterator.next());
-            powerEntry.cost = Float.parseFloat(iterator.next());
-            powerEntry.difficulty = Float.parseFloat(iterator.next());
-            powerEntry.precision = Float.parseFloat(iterator.next());
-            powerEntry.init_time = Float.parseFloat(iterator.next().replaceAll("(\\.0)+$", ""));
-            powerEntry.release_time = Float.parseFloat(iterator.next());
-            powerEntry.recycle_time = Float.parseFloat(iterator.next());
-            powerEntry.hitRollYN = Integer.parseInt(iterator.next());
-            powerEntry.castingMode = mbEnums.CastingModeType.valueOf(iterator.next());
-            powerEntry.initAmin = Integer.parseInt(iterator.next());
-            powerEntry.releaseAnim = Integer.parseInt(iterator.next());
-            powerEntry.targetSelect = mbEnums.TargetSelectType.valueOf(iterator.next());
 
-            // Process key value pairs after header
+            String lineValue = iterator.next();
+            List<String> lineValues = Arrays.asList(lineValue.split("="));
+            String key = lineValues.get(0).trim();
+            ActionEntry actionEntry;
+            List<String> arguments;
+            Matcher argumentMatcher;
 
-            iterator = Arrays.stream(lineData).iterator();
+            switch (key) {
-            iterator.next(); // Ignore header
+                case "ACTION":
+                    actionEntry = new ActionEntry();
+                    arguments = Arrays.asList(lineValues.get(1).trim().split("\\s+"));
+                    actionEntry.effect_id = arguments.get(0);
+                    actionEntry.minTrains = Integer.parseInt(arguments.get(1));
+                    actionEntry.maxTrains = Integer.parseInt(arguments.get(2));
+                    actionEntry.duration = Float.parseFloat(arguments.get(3));
+                    actionEntry.curve = mbEnums.CompoundCurveType.valueOf(arguments.get(4));
+                    actionEntry.stackingCategory = arguments.get(5);
+                    actionEntry.stackingPriority = Integer.parseInt(arguments.get(6));
+                    actionEntry.categoryToPower = mbEnums.CategoryToPowerType.valueOf(arguments.get(7));
+                    powerEntry.actionEntries.add(actionEntry);
+                    break;
+                case "MaxLevel":
+                    powerEntry.maxLevel = Integer.parseInt(lineValues.get(1).trim());
+                    break;
+                case "HateValue":
+                    arguments = Arrays.asList(lineValues.get(1).trim().split("\\s+"));
+                    powerEntry.hateValue = Integer.parseInt(arguments.get(0));
 
-            while (iterator.hasNext()) {
+                    // Not all entries have a curve.  Defaults to DefaultFlat;
 
-                String lineValue = iterator.next();
+                    if (arguments.size() > 1)
-                String[] lineValues = lineValue.split("=");
+                        powerEntry.hateCurve = mbEnums.CompoundCurveType.valueOf(arguments.get(1));
-                String key = lineValues[0].trim();
+                    break;
-                ActionEntry actionEntry;
+                case "LOOPANIMID":
-                String[] arguments;
+                    powerEntry.loopAnimID = Integer.parseInt(lineValues.get(1).trim());
-                Matcher matcher1;
+                    break;
-                ArrayList<String> args;
+                case "GRANTOVERRIDEVAR":
+                    powerEntry.grantOverrideVar = lineValues.get(1).trim();
+                    break;
+                case "DESCRIPTION":
+                    powerEntry.description.add(lineValues.get(1).trim());
+                    break;
+                case "CATEGORY":
+                    powerEntry.category = lineValues.get(1).trim();
+                    break;
+                case "CURVE":
+                    arguments = Arrays.asList(lineValues.get(1).trim().split("\\s+"));
+                    powerEntry.curves.put(arguments.get(0), mbEnums.CompoundCurveType.valueOf(arguments.get(1)));
+                    break;
+                case "EQPREREQ":
+                    argumentMatcher = STRSPLIT_REGEX.matcher(lineValues.get(1).trim());
+                    arguments = new ArrayList<>();
 
-                switch (key) {
+                    while (argumentMatcher.find())
-                    case "ACTION":
+                        arguments.add(argumentMatcher.group().trim());
-                        actionEntry = new ActionEntry();
-                        arguments = lineValues[1].trim().split("\\s+");
 
-                        if (powerEntry.power_id.equals("HNT-050"))
+                    argumentIterator = arguments.iterator();
-                            Logger.error("debug");
 
-                        actionEntry.effect_id = arguments[0];
+                    while (argumentIterator.hasNext()) {
-                        actionEntry.minTrains = Integer.parseInt(arguments[1]);
-                        actionEntry.maxTrains = Integer.parseInt(arguments[2]);
-                        actionEntry.duration = Float.parseFloat(arguments[3]);
-                        actionEntry.curve = mbEnums.CompoundCurveType.valueOf(arguments[4]);
-                        actionEntry.stackingCategory = arguments[5];
-                        actionEntry.stackingPriority = Integer.parseInt(arguments[6]);
-                        actionEntry.categoryToPower = mbEnums.CategoryToPowerType.valueOf(arguments[7]);
-                        powerEntry.actionEntries.add(actionEntry);
-                        break;
-                    case "MaxLevel":
-                        powerEntry.maxLevel = Integer.parseInt(lineValues[1].trim());
-                        break;
-                    case "HateValue":
-                        arguments = lineValues[1].trim().split("\\s+");
-                        powerEntry.hateValue = Integer.parseInt(arguments[0]);
-
-                        // Not all entries have a curve.  Defaults to DefaultFlat;
-
-                        if (arguments.length > 1)
-                            powerEntry.hateCurve = mbEnums.CompoundCurveType.valueOf(arguments[1]);
-                        break;
-                    case "LOOPANIMID":
-                        powerEntry.loopAnimID = Integer.parseInt(lineValues[1].trim());
-                        break;
-                    case "GRANTOVERRIDEVAR":
-                        powerEntry.grantOverrideVar = lineValues[1].trim();
-                        break;
-                    case "DESCRIPTION":
-                        powerEntry.description.add(lineValues[1].trim());
-                        break;
-                    case "CATEGORY":
-                        powerEntry.category = lineValues[1].trim();
-                        break;
-                    case "CURVE":
-                        arguments = lineValues[1].trim().split("\\s+");
-                        powerEntry.curves.put(arguments[0], mbEnums.CompoundCurveType.valueOf(arguments[1]));
-                        break;
-                    case "EQPREREQ":
                         EquipmentPreReq equipmentPreReq = new EquipmentPreReq();
-                        matcher1 = STRSPLIT_REGEX.matcher(lineValues[1].trim());
+                        equipmentPreReq.slot = mbEnums.EquipSlotType.valueOf(arguments.get(0));
-                        args = new ArrayList<>();
+                        equipmentPreReq.skill = arguments.get(1).replaceAll("\"", "");
+                        equipmentPreReq.required = Integer.parseInt(arguments.get(2));
+                        powerEntry.equipmentPreReq.add(equipmentPreReq);
+                    }
+                    break;
+                case "CANCASTWHILEMOVING":
+                    powerEntry.canCastWhileMoving = Boolean.parseBoolean(lineValues.get(1).trim());
+                    break;
+                case "CANCASTWHILEFLYING":
+                    powerEntry.canCastWhileFlying = Boolean.parseBoolean(lineValues.get(1).trim());
+                    break;
+                case "BLADETRAILS":
+                    powerEntry.bladeTrails = Boolean.parseBoolean(lineValues.get(1).trim());
+                    break;
+                case "EFFECTPREREQ":
+                    Effect effectPreReq = new Effect();
+                    arguments = Arrays.asList(lineValues.get(1).trim().split("\\s+"));
+                    effectPreReq.effect_id = arguments.get(9);
+                    effectPreReq.level = Integer.parseInt(arguments.get(1));
+                    effectPreReq.message = arguments.get(2);
+                    powerEntry.effectPreReqs.add(effectPreReq);
+                    break;
+                case "MONSTERTYPERESTRICTS":
+                    arguments = Arrays.asList(lineValues.get(1).trim().split("\\s+"));
 
-                        while (matcher1.find())
+                    for (String restriction : arguments)
-                            args.add(matcher1.group().trim());
+                        powerEntry.monsterRestricts.add(mbEnums.MonsterType.valueOf(restriction.trim()));
+                    break;
+                case "MONSTERTYPEPREREQS":
+                    arguments = Arrays.asList(lineValues.get(1).trim().split("\\s+"));
 
-                        equipmentPreReq.slot = mbEnums.EquipSlotType.valueOf(args.get(0));
+                    for (String restriction : arguments)
-                        equipmentPreReq.skill = args.get(1).replaceAll("\"", "");
+                        powerEntry.monsterPrereqs.add(mbEnums.MonsterType.valueOf(restriction.trim()));
-                        equipmentPreReq.level = Integer.parseInt(args.get(2));
+                    break;
-                        powerEntry.equipmentPreReq = equipmentPreReq;
+                case "SHOULDCHECKPATH":
-                        break;
+                    powerEntry.shouldCheckPath = Boolean.parseBoolean(lineValues.get(1).trim());
-                    case "CANCASTWHILEMOVING":
+                    break;
-                        powerEntry.canCastWhileMoving = Boolean.parseBoolean(lineValues[1].trim());
+                case "STICKY":
-                        break;
+                    powerEntry.sticky = Boolean.parseBoolean(lineValues.get(1).trim());
-                    case "CANCASTWHILEFLYING":
+                    break;
-                        powerEntry.canCastWhileFlying = Boolean.parseBoolean(lineValues[1].trim());
+                case "PULSEINFO":
-                        break;
+                    arguments = Arrays.asList(lineValues.get(1).trim().split("\\s+"));
-                    case "BLADETRAILS":
+                    powerEntry.pulseCycle = Integer.parseInt(arguments.get(0));
-                        powerEntry.bladeTrails = Boolean.parseBoolean(lineValues[1].trim());
+                    powerEntry.pulseDuration = Integer.parseInt(arguments.get(1));
-                        break;
+                    break;
-                    case "EFFECTPREREQ":
+                case "MAXNUMMOBTARGETS":
-                        EffectDescription effectPreReq = new EffectDescription();
+                    powerEntry.maxMobTargets = Integer.parseInt(lineValues.get(1).trim());
-                        arguments = lineValues[1].trim().split("\\s+");
+                    break;
-                        effectPreReq.effect_id = arguments[9];
+                case "MAXNUMPLAYERTARGETS":
-                        effectPreReq.level = Integer.parseInt(arguments[1]);
+                    powerEntry.maxPlayerTargets = Integer.parseInt(lineValues.get(1).trim());
-                        effectPreReq.message = arguments[2];
+                    break;
-                        powerEntry.effectPreReqs.add(effectPreReq);
+                case "ISADMINPOWER":
-                        break;
+                    powerEntry.isAdminPower = Boolean.parseBoolean(lineValues.get(1).trim());
-                    case "MONSTERTYPERESTRICTS":
+                    break;
-                        arguments = lineValues[1].trim().split("\\s+");
+                case "ISPROJECTILE":
-                        for (String restriction : arguments)
+                    powerEntry.isProjectile = Boolean.parseBoolean(lineValues.get(1).trim());
-                            powerEntry.monsterRestricts.add(mbEnums.MonsterType.valueOf(restriction.trim()));
+                    break;
-                        break;
+                case "CASTERSPULSEPARTICLE":
-                    case "MONSTERTYPEPREREQS":
+                    powerEntry.casterPulseParticle = Integer.parseInt(lineValues.get(1).trim());
-                        arguments = lineValues[1].trim().split("\\s+");
+                    break;
-                        for (String restriction : arguments)
+                case "TARGETEFFECTPREREQS_ORED":
-                            powerEntry.monsterPrereqs.add(mbEnums.MonsterType.valueOf(restriction.trim()));
+                    Effect preReq = new Effect();
-                        break;
+                    arguments = Arrays.asList(lineValues.get(1).trim().split("\\s+"));
-                    case "SHOULDCHECKPATH":
+                    preReq.effect_id = arguments.get(0);
-                        powerEntry.shouldCheckPath = Boolean.parseBoolean(lineValues[1].trim());
+                    preReq.level = Integer.parseInt(arguments.get(1));
-                        break;
+                    powerEntry.targetEffectPrereqs.add(preReq);
-                    case "STICKY":
+                    break;
-                        powerEntry.sticky = Boolean.parseBoolean(lineValues[1].trim());
+                case "SOUNDS":   // Values not parsed
-                        break;
+                case "APPLYDAMAGESELF":
-                    case "PULSEINFO":
+                case "APPLYDAMAGECASTER":
-                        arguments = lineValues[1].trim().split("\\s+");
+                case "APPLYDAMAGEOTHER":
-                        powerEntry.pulseCycle = Integer.parseInt(arguments[0]);
+                case "APPLYDAMAGETARGET":
-                        powerEntry.pulseDuration = Integer.parseInt(arguments[1]);
+                case "APPLYEFFECTSELF":
-                        break;
+                case "APPLYEFFECTOTHER":
-                    case "MAXNUMMOBTARGETS":
+                case "APPLYEFFECTCASTER":
-                        powerEntry.maxMobTargets = Integer.parseInt(lineValues[1].trim());
+                case "APPLYEFFECTTARGET":
-                        break;
+                case "FIZZLEOTHER":
-                    case "MAXNUMPLAYERTARGETS":
+                case "FIZZLESELF":
-                        powerEntry.maxPlayerTargets = Integer.parseInt(lineValues[1].trim());
+                case "INITSTRING":
-                        break;
+                case "SUCCESSOTHER":
-                    case "ISADMINPOWER":
+                case "SUCCESSSELF":
-                        powerEntry.isAdminPower = Boolean.parseBoolean(lineValues[1].trim());
+                case "WEAROFFEFFECTOTHER":
-                        break;
+                case "WEAROFFEFFECTSELF":
-                    case "ISPROJECTILE":
+                    break;
-                        powerEntry.isProjectile = Boolean.parseBoolean(lineValues[1].trim());
+                default:
-                        break;
+                    Logger.error("Unhandled variable type:" + key + " for power: " + powerEntry.power_id);
-                    case "CASTERSPULSEPARTICLE":
-                        powerEntry.casterPulseParticle = Integer.parseInt(lineValues[1].trim());
-                        break;
-                    case "TARGETEFFECTPREREQS_ORED":
-                        EffectDescription preReq = new EffectDescription();
-                        arguments = lineValues[1].trim().split("\\s+");
-                        preReq.effect_id = arguments[0];
-                        preReq.level = Integer.parseInt(arguments[1]);
-                        powerEntry.targetEffectPrereqs.add(preReq);
-                        break;
-                    case "SOUNDS":   // Values not parsed
-                    case "APPLYDAMAGESELF":
-                    case "APPLYDAMAGECASTER":
-                    case "APPLYDAMAGEOTHER":
-                    case "APPLYDAMAGETARGET":
-                    case "APPLYEFFECTSELF":
-                    case "APPLYEFFECTOTHER":
-                    case "APPLYEFFECTCASTER":
-                    case "APPLYEFFECTTARGET":
-                    case "FIZZLEOTHER":
-                    case "FIZZLESELF":
-                    case "INITSTRING":
-                    case "SUCCESSOTHER":
-                    case "SUCCESSSELF":
-                    case "WEAROFFEFFECTOTHER":
-                    case "WEAROFFEFFECTSELF":
-                        break;
-                    default:
-                        Logger.error("Unhandled variable type:" + key + " for power: " + powerEntry.power_id);
-                }
             }
-
-            // Parse power conditions
-
-            if (conditionString.toString().isEmpty() == false) {
-                String[] conditions = conditionString.toString().split("\n");
-
-                for (String condition : conditions) {
-                    String[] parameters = condition.trim().split("\\s+");
-                    powerEntry.conditions.put(parameters[0], Float.parseFloat(parameters[1]));
-                }
-            }
-
-        } catch (Exception e) {
-            Logger.error(powerEntry.power_id + " " + e);
         }
 
+        // Parse power conditions
+
+        if (conditionString.isEmpty() == false) {
+
+            List<String> conditions = Arrays.asList(conditionString.split("\n"));
+
+            for (String condition : conditions) {
+                List<String> parameters = Arrays.asList(condition.trim().split("\\s+"));
+                powerEntry.conditions.put(parameters.get(0), Float.parseFloat(parameters.get(1)));
+            }
+        }
         return powerEntry;
     }
 

src/engine/wpak/data/ConditionEntry.java

@@ -5,13 +5,17 @@
 // ▀▀  █▪▀▀▀ ▀  ▀ ·▀▀▀▀ ▀▀▀·▀▀▀ ·▀▀▀▀  ▀  ▀ ▀▀  █▪ ▀▀▀
 //      Magicbane Emulator Project © 2013 - 2024
 //                www.magicbane.com
-
+//
 package engine.wpak.data;
 
 import engine.mbEnums;
 
-public class PowerData {
+import java.util.EnumSet;
-    public mbEnums.PowerType power_type;
+
-    public int icon;
+public class ConditionEntry {
-    public String powerBase;
+    public String condition;
+    public int arg;
+    public mbEnums.CompoundCurveType curveType;
+    public EnumSet<mbEnums.DamageType> damageTypes = EnumSet.noneOf(mbEnums.DamageType.class);
+
 }

src/engine/wpak/data/Effect.java

@@ -9,14 +9,27 @@
 package engine.wpak.data;
 
 import java.util.ArrayList;
-import java.util.HashMap;
 import java.util.HashSet;
 
-public class EffectEntry {
+public class Effect {
     public String effect_id;
     public String effect_name;
     public int icon;
     public HashSet<String> sources = new HashSet<>();
-    public ArrayList<EffectModifier> mods = new ArrayList<>();
+    public ArrayList<ModifierEntry> mods = new ArrayList<>();
-    public HashMap<String, Float> conditions = new HashMap<>();
+    public ArrayList<ConditionEntry> conditions = new ArrayList<>();
+
+    // Additional variables outside of tags or parsed
+    // elsewhere from Effects.cfg
+
+    public boolean isItemEffect;
+    public boolean isSpireEffect;
+    public boolean ignoreNoMod;
+    public boolean dontSave;
+
+    public String type;
+    public int level;
+    public String message;
+    public int cycleDuration;
+    public int cycleDelay;
 }

src/engine/wpak/data/EffectDescription.java

@@ -1,15 +0,0 @@
-// • ▌ ▄ ·.  ▄▄▄·  ▄▄ • ▪   ▄▄· ▄▄▄▄·  ▄▄▄·  ▐▄▄▄  ▄▄▄ .
-// ·██ ▐███▪▐█ ▀█ ▐█ ▀ ▪██ ▐█ ▌▪▐█ ▀█▪▐█ ▀█ •█▌ ▐█▐▌·
-// ▐█ ▌▐▌▐█·▄█▀▀█ ▄█ ▀█▄▐█·██ ▄▄▐█▀▀█▄▄█▀▀█ ▐█▐ ▐▌▐▀▀▀
-// ██ ██▌▐█▌▐█ ▪▐▌▐█▄▪▐█▐█▌▐███▌██▄▪▐█▐█ ▪▐▌██▐ █▌▐█▄▄▌
-// ▀▀  █▪▀▀▀ ▀  ▀ ·▀▀▀▀ ▀▀▀·▀▀▀ ·▀▀▀▀  ▀  ▀ ▀▀  █▪ ▀▀▀
-//      Magicbane Emulator Project © 2013 - 2024
-//                www.magicbane.com
-
-package engine.wpak.data;
-
-public class EffectDescription {
-    public String effect_id;
-    public int level;
-    public String message;
-}

src/engine/wpak/data/EquipmentPreReq.java

@@ -14,6 +14,6 @@ public class EquipmentPreReq {
 
     public mbEnums.EquipSlotType slot;
     public String skill;
-    public int level;
+    public int required;
 
 }

src/engine/wpak/data/ModifierEntry.java

@@ -10,11 +10,11 @@ package engine.wpak.data;
 
 import engine.mbEnums;
 
-public class EffectModifier {
+public class ModifierEntry {
     public mbEnums.ModType type;
     public float min;
     public float max;
-    public float scale;
+    public float value;
     public mbEnums.CompoundCurveType compoundCurveType;
     public String arg1; // ItemName "Masterwork" ""
     public String arg2; // ItemName "" "of the Defender"

src/engine/wpak/data/Power.java

@@ -0,0 +1,69 @@
+// • ▌ ▄ ·.  ▄▄▄·  ▄▄ • ▪   ▄▄· ▄▄▄▄·  ▄▄▄·  ▐▄▄▄  ▄▄▄ .
+// ·██ ▐███▪▐█ ▀█ ▐█ ▀ ▪██ ▐█ ▌▪▐█ ▀█▪▐█ ▀█ •█▌ ▐█▐▌·
+// ▐█ ▌▐▌▐█·▄█▀▀█ ▄█ ▀█▄▐█·██ ▄▄▐█▀▀█▄▄█▀▀█ ▐█▐ ▐▌▐▀▀▀
+// ██ ██▌▐█▌▐█ ▪▐▌▐█▄▪▐█▐█▌▐███▌██▄▪▐█▐█ ▪▐▌██▐ █▌▐█▄▄▌
+// ▀▀  █▪▀▀▀ ▀  ▀ ·▀▀▀▀ ▀▀▀·▀▀▀ ·▀▀▀▀  ▀  ▀ ▀▀  █▪ ▀▀▀
+//      Magicbane Emulator Project © 2013 - 2024
+//                www.magicbane.com
+
+package engine.wpak.data;
+
+import engine.mbEnums;
+
+import java.util.ArrayList;
+import java.util.EnumSet;
+import java.util.HashMap;
+
+public class Power {
+    public String power_id;
+    public String power;
+    public ArrayList<PowerEntry> powers = new ArrayList<>();
+    public mbEnums.PowerTargetType target_type;
+    public int range;
+    public mbEnums.AreaType areaType;
+    public int areaRange;
+    public mbEnums.ExcludeType excludeType;
+    public mbEnums.CostType costType;
+    public float cost;
+    public float difficulty;
+    public float precision;
+    public float init_time;
+    public float release_time;
+    public float recycle_time;
+    public int hitRollYN;
+    public mbEnums.CastingModeType castingMode;
+    public int initAmin;
+    public int releaseAnim;
+    public mbEnums.TargetSelectType targetSelect;
+
+    // Additional key/value type power entries
+
+    public ArrayList<ActionEntry> actionEntries = new ArrayList<>();
+    public int maxLevel;
+    public int hateValue;
+    public mbEnums.CompoundCurveType hateCurve = mbEnums.CompoundCurveType.DefaultFlat;
+    public int loopAnimID;
+    public String grantOverrideVar;
+    public ArrayList<String> description = new ArrayList<>();
+    public HashMap<String, mbEnums.CompoundCurveType> curves = new HashMap<>();
+    public String category;
+    public boolean canCastWhileMoving = false;
+    public boolean bladeTrails = false;
+    public ArrayList<Effect> effectPreReqs = new ArrayList<>();
+    public ArrayList<EquipmentPreReq> equipmentPreReq = new ArrayList<>();
+    public EnumSet<mbEnums.MonsterType> monsterRestricts = EnumSet.noneOf(mbEnums.MonsterType.class);
+    public EnumSet<mbEnums.MonsterType> monsterPrereqs = EnumSet.noneOf(mbEnums.MonsterType.class);
+    public boolean shouldCheckPath = false;
+    public boolean sticky = false;
+    public int pulseCycle;
+    public int pulseDuration;
+    public int maxMobTargets;
+    public int maxPlayerTargets;
+    public boolean isAdminPower = false;
+    public int casterPulseParticle;
+    public ArrayList<Effect> targetEffectPrereqs = new ArrayList<>();
+    public boolean canCastWhileFlying = false;
+    public boolean isProjectile = false;
+    public HashMap<String, Float> conditions = new HashMap<>();
+
+}

src/engine/wpak/data/PowerAction.java

@@ -0,0 +1,53 @@
+// • ▌ ▄ ·.  ▄▄▄·  ▄▄ • ▪   ▄▄· ▄▄▄▄·  ▄▄▄·  ▐▄▄▄  ▄▄▄ .
+// ·██ ▐███▪▐█ ▀█ ▐█ ▀ ▪██ ▐█ ▌▪▐█ ▀█▪▐█ ▀█ •█▌ ▐█▐▌·
+// ▐█ ▌▐▌▐█·▄█▀▀█ ▄█ ▀█▄▐█·██ ▄▄▐█▀▀█▄▄█▀▀█ ▐█▐ ▐▌▐▀▀▀
+// ██ ██▌▐█▌▐█ ▪▐▌▐█▄▪▐█▐█▌▐███▌██▄▪▐█▐█ ▪▐▌██▐ █▌▐█▄▄▌
+// ▀▀  █▪▀▀▀ ▀  ▀ ·▀▀▀▀ ▀▀▀·▀▀▀ ·▀▀▀▀  ▀  ▀ ▀▀  █▪ ▀▀▀
+//      Magicbane Emulator Project © 2013 - 2024
+//                www.magicbane.com
+
+package engine.wpak.data;
+
+import engine.mbEnums;
+
+import java.util.ArrayList;
+
+public class PowerAction {
+
+    // Header values
+
+    public String action_id;
+    public String action_type;
+    public ArrayList<Effect> effects = new ArrayList<>();
+    public int petLevel;
+    public int petRace;
+    public StatTransfer statTransfer;
+    public int levelCap;
+    public mbEnums.CompoundCurveType levelCurve;
+    public TrackEntry trackEntry;
+
+    // Additional variables after header go here.
+
+    public ArrayList<Integer> bodyparts = new ArrayList<>();
+    public ArrayList<Integer> femaleBodyParts = new ArrayList<>();
+    public boolean shouldShowWeapons = false;
+    public boolean shouldShowArmor = false;
+    public boolean bladeTrails = false;
+    public boolean isResistible = false;
+    public ArrayList<Float> scaleFactor = new ArrayList<>();
+    public ArrayList<Integer> attackAnimations = new ArrayList<>();
+    public boolean isAggressive;
+    public mbEnums.DamageType damageType;
+    public boolean applyEffectBlank = false;
+    public boolean wearOffEffectBlank = false;
+    public boolean removeAll = false;
+    public boolean clearAggro = false;
+    public boolean targetBecomesPet = false;
+    public boolean destroyOldPet = false;
+    public mbEnums.ItemFlags itemFlag;
+    public mbEnums.MobBehaviourType rootFsmID;
+    public int splashDamageMin;
+    public int splashDamageMax;
+
+
+}

src/engine/wpak/data/PowerEntry.java

@@ -10,60 +10,8 @@ package engine.wpak.data;
 
 import engine.mbEnums;
 
-import java.util.ArrayList;
-import java.util.EnumSet;
-import java.util.HashMap;
-
 public class PowerEntry {
-    public String power_id;
+    public mbEnums.PowerType power_type;
-    public String power;
+    public int icon;
-    public ArrayList<PowerData> powers = new ArrayList<>();
+    public String powerBase;
-    public mbEnums.PowerTargetType target_type;
-    public int range;
-    public mbEnums.AreaType areaType;
-    public int areaRange;
-    public mbEnums.ExcludeType excludeType;
-    public mbEnums.CostType costType;
-    public float cost;
-    public float difficulty;
-    public float precision;
-    public float init_time;
-    public float release_time;
-    public float recycle_time;
-    public int hitRollYN;
-    public mbEnums.CastingModeType castingMode;
-    public int initAmin;
-    public int releaseAnim;
-    public mbEnums.TargetSelectType targetSelect;
-
-    // Additional key/value type power entries
-
-    public ArrayList<ActionEntry> actionEntries = new ArrayList<>();
-    public int maxLevel;
-    public int hateValue;
-    public mbEnums.CompoundCurveType hateCurve = mbEnums.CompoundCurveType.DefaultFlat;
-    public int loopAnimID;
-    public String grantOverrideVar;
-    public ArrayList<String> description = new ArrayList<>();
-    public HashMap<String, mbEnums.CompoundCurveType> curves = new HashMap<>();
-    public String category;
-    public boolean canCastWhileMoving = false;
-    public boolean bladeTrails = false;
-    public ArrayList<EffectDescription> effectPreReqs = new ArrayList<>();
-    public EquipmentPreReq equipmentPreReq;
-    public EnumSet<mbEnums.MonsterType> monsterRestricts = EnumSet.noneOf(mbEnums.MonsterType.class);
-    public EnumSet<mbEnums.MonsterType> monsterPrereqs = EnumSet.noneOf(mbEnums.MonsterType.class);
-    public boolean shouldCheckPath = false;
-    public boolean sticky = false;
-    public int pulseCycle;
-    public int pulseDuration;
-    public int maxMobTargets;
-    public int maxPlayerTargets;
-    public boolean isAdminPower = false;
-    public int casterPulseParticle;
-    public ArrayList<EffectDescription> targetEffectPrereqs = new ArrayList<>();
-    public boolean canCastWhileFlying = false;
-    public boolean isProjectile = false;
-    public HashMap<String, Float> conditions = new HashMap<>();
-
 }

src/engine/wpak/data/StatTransfer.java

@@ -0,0 +1,24 @@
+// • ▌ ▄ ·.  ▄▄▄·  ▄▄ • ▪   ▄▄· ▄▄▄▄·  ▄▄▄·  ▐▄▄▄  ▄▄▄ .
+// ·██ ▐███▪▐█ ▀█ ▐█ ▀ ▪██ ▐█ ▌▪▐█ ▀█▪▐█ ▀█ •█▌ ▐█▐▌·
+// ▐█ ▌▐▌▐█·▄█▀▀█ ▄█ ▀█▄▐█·██ ▄▄▐█▀▀█▄▄█▀▀█ ▐█▐ ▐▌▐▀▀▀
+// ██ ██▌▐█▌▐█ ▪▐▌▐█▄▪▐█▐█▌▐███▌██▄▪▐█▐█ ▪▐▌██▐ █▌▐█▄▄▌
+// ▀▀  █▪▀▀▀ ▀  ▀ ·▀▀▀▀ ▀▀▀·▀▀▀ ·▀▀▀▀  ▀  ▀ ▀▀  █▪ ▀▀▀
+//      Magicbane Emulator Project © 2013 - 2024
+//                www.magicbane.com
+
+package engine.wpak.data;
+
+import engine.mbEnums;
+
+public class StatTransfer {
+    public mbEnums.CostType fromStat;
+    public float fromStatValue;
+    public mbEnums.CompoundCurveType fromCurve;
+    public mbEnums.CostType toStat;
+    public float toStatValue;
+    public mbEnums.CompoundCurveType toCurve;
+    public boolean fromStatBool;
+    public boolean toStatBool;
+    public String transfer_action;
+    public int transfer_ticks;
+}

src/engine/wpak/data/TrackEntry.java

@@ -3,16 +3,17 @@
 // ▐█ ▌▐▌▐█·▄█▀▀█ ▄█ ▀█▄▐█·██ ▄▄▐█▀▀█▄▄█▀▀█ ▐█▐ ▐▌▐▀▀▀
 // ██ ██▌▐█▌▐█ ▪▐▌▐█▄▪▐█▐█▌▐███▌██▄▪▐█▐█ ▪▐▌██▐ █▌▐█▄▄▌
 // ▀▀  █▪▀▀▀ ▀  ▀ ·▀▀▀▀ ▀▀▀·▀▀▀ ·▀▀▀▀  ▀  ▀ ▀▀  █▪ ▀▀▀
-//      Magicbane Emulator Project © 2013 - 2024
+//      Magicbane Emulator Project © 2013 - 2022
 //                www.magicbane.com
 
 package engine.wpak.data;
 
-import java.util.ArrayList;
+public class TrackEntry {
-
-public class PowerActionEntry {
 
     public String action_id;
-    public String action_type;
+    public Boolean unknown1;
-    public ArrayList<EffectDescription> effects;
+    public Boolean unknown2;
+    public String type;
+    public int min;
+    public int max;
 }