Fixes for /mob, /npc, and /equipset commands.

src/engine/db/handlers/dbNPCHandler.java

@@ -243,8 +243,12 @@ public class dbNPCHandler extends dbHandlerBase {
 
     public boolean UPDATE_EQUIPSET(NPC npc, int equipSetID) {
 
+        // Column name must match what NPC/Mob loaders read ("equipmentSet").
+        // Using the wrong column here causes the update to fail silently and
+        // dev command to report "Unable to find Equipset" despite a valid ID.
+
         try (Connection connection = DbManager.getConnection();
-             PreparedStatement preparedStatement = connection.prepareStatement("UPDATE `obj_npc` SET `equipsetID`=? WHERE `UID`=?")) {
+             PreparedStatement preparedStatement = connection.prepareStatement("UPDATE `obj_npc` SET `equipmentSet`=? WHERE `UID`=?")) {
 
             preparedStatement.setInt(1, equipSetID);
             preparedStatement.setLong(2, npc.getObjectUUID());

src/engine/net/client/handlers/AcceptSubInviteHandler.java

@@ -15,7 +15,6 @@ import engine.Enum.GuildState;
 import engine.exception.MsgSendException;
 import engine.gameManager.ChatManager;
 import engine.gameManager.DbManager;
-import engine.gameManager.GuildManager;
 import engine.gameManager.SessionManager;
 import engine.net.Dispatch;
 import engine.net.DispatchMessage;
@@ -27,6 +26,8 @@ import engine.objects.Guild;
 import engine.objects.GuildStatusController;
 import engine.objects.PlayerCharacter;
 
+import java.util.ArrayList;
+
 public class AcceptSubInviteHandler extends AbstractClientMsgHandler {
 
     public AcceptSubInviteHandler() {
@@ -37,76 +38,69 @@ public class AcceptSubInviteHandler extends AbstractClientMsgHandler {
     protected boolean _handleNetMsg(ClientNetMsg baseMsg, ClientConnection origin) throws MsgSendException {
 
         AcceptSubInviteMsg msg = (AcceptSubInviteMsg) baseMsg;
-        PlayerCharacter playerCharacter;
+        PlayerCharacter sourcePlayer;
-        Guild protectorate;
+        Guild sourceGuild;
-        Guild nation;
+        Guild targetGuild;
         Dispatch dispatch;
 
         // get PlayerCharacter of person sending sub invite
 
-        playerCharacter = SessionManager.getPlayerCharacter(origin);
+        sourcePlayer = SessionManager.getPlayerCharacter(origin);
 
-        if (playerCharacter == null)
+        if (sourcePlayer == null)
             return true;
 
-        protectorate = playerCharacter.getGuild();
+        sourceGuild = sourcePlayer.getGuild();
-        nation = (Guild) DbManager.getObject(GameObjectType.Guild, msg.guildUUID());
+        targetGuild = (Guild) DbManager.getObject(GameObjectType.Guild, msg.guildUUID());
 
         //must be source guild to sub to
 
-        if (nation == null) {
+        if (targetGuild == null) {
-            ErrorPopupMsg.sendErrorPopup(playerCharacter, 45); // Failure to swear guild
+            ErrorPopupMsg.sendErrorPopup(sourcePlayer, 45); // Failure to swear guild
             return true;
         }
-        if (protectorate == null) {
+        if (sourceGuild == null) {
-            ErrorPopupMsg.sendErrorPopup(playerCharacter, 45); // Failure to swear guild
+            ErrorPopupMsg.sendErrorPopup(sourcePlayer, 45); // Failure to swear guild
             return true;
         }
 
-        if (protectorate.equals(nation))
+        if (sourceGuild.equals(targetGuild))
             return true;
 
-        if (GuildStatusController.isGuildLeader(playerCharacter.getGuildStatus()) == false) {
+        if (GuildStatusController.isGuildLeader(sourcePlayer.getGuildStatus()) == false) {
-            ErrorPopupMsg.sendErrorMsg(playerCharacter, "Only a guild leader can accept fealty!");
+            ErrorPopupMsg.sendErrorMsg(sourcePlayer, "Only a guild leader can accept fealty!");
             return true;
         }
 
         //source guild is limited to 7 subs
         //TODO this should be based on TOL rank
 
-        if (!nation.canSubAGuild(protectorate)) {
+        if (!targetGuild.canSubAGuild(sourceGuild)) {
-            ErrorPopupMsg.sendErrorPopup(playerCharacter, 45); // Failure to swear guild
+            ErrorPopupMsg.sendErrorPopup(sourcePlayer, 45); // Failure to swear guild
             return true;
         }
 
         //all tests passed, let's Handle code
+        //Update Target Guild State.
 
-        // Update database
+        sourceGuild.upgradeGuildState(false);
 
-        if (!DbManager.GuildQueries.UPDATE_PARENT(protectorate.getObjectUUID(), nation.getObjectUUID())) {
+        //Add sub so GuildMaster can Swear in.
-            ErrorPopupMsg.sendErrorMsg(playerCharacter, "A Serious error has occured. Please post details for to ensure transaction integrity");
-            return true;
-        }
 
-        //update Guild states.
+        ArrayList<Guild> subs = targetGuild.getSubGuildList();
+        subs.add(sourceGuild);
 
-        protectorate.setNation(nation);
+        targetGuild.setGuildState(GuildState.Nation);
-        GuildManager.updateAllGuildTags(protectorate);
-        protectorate.upgradeGuildState(false);
 
-        if (nation.getGuildState() == GuildState.Sovereign)
-            nation.upgradeGuildState(true);
-
-        nation.getSubGuildList().add(protectorate);
 
         //Let's send the message back.
 
         msg.setUnknown02(1);
-        msg.setResponse("Your guild is now a " + protectorate.getGuildState().name() + '.');
+        msg.setResponse("Your guild is now a " + sourceGuild.getGuildState().name() + '.');
-        dispatch = Dispatch.borrow(playerCharacter, msg);
+        dispatch = Dispatch.borrow(sourcePlayer, msg);
         DispatchMessage.dispatchMsgDispatch(dispatch, Enum.DispatchChannel.SECONDARY);
 
-        ChatManager.chatSystemInfo(playerCharacter, "Your guild is now a " + protectorate.getGuildState().name() + '.');
+        ChatManager.chatSystemInfo(sourcePlayer, "Your guild is now a " + sourceGuild.getGuildState().name() + '.');
         return true;
     }
 }

src/engine/net/client/handlers/BreakFealtyHandler.java

@@ -26,7 +26,6 @@ import engine.net.client.msg.guild.SendGuildEntryMsg;
 import engine.objects.*;
 import engine.server.world.WorldServer;
 import engine.session.Session;
-import org.pmw.tinylog.Logger;
 
 import java.util.ArrayList;
 
@@ -41,8 +40,8 @@ public class BreakFealtyHandler extends AbstractClientMsgHandler {
 
         BreakFealtyMsg bfm;
         PlayerCharacter player;
-        Guild nation;
+        Guild toBreak;
-        Guild protectorate;
+        Guild guild;
         Dispatch dispatch;
 
         bfm = (BreakFealtyMsg) baseMsg;
@@ -55,50 +54,46 @@ public class BreakFealtyHandler extends AbstractClientMsgHandler {
         if (player == null)
             return true;
 
-        nation = (Guild) DbManager.getObject(GameObjectType.Guild, bfm.getGuildUUID());
+        toBreak = (Guild) DbManager.getObject(GameObjectType.Guild, bfm.getGuildUUID());
 
-        if (nation == null) {
+        if (toBreak == null) {
             ErrorPopupMsg.sendErrorMsg(player, "A Serious error has occured. Please post details for to ensure transaction integrity");
             return true;
         }
 
-        protectorate = player.getGuild();
+        guild = player.getGuild();
 
-        if (protectorate == null) {
+        if (guild == null) {
             ErrorPopupMsg.sendErrorMsg(player, "You do not belong to a guild!");
             return true;
         }
 
-        if (nation.isNPCGuild()) {
+        if (toBreak.isNPCGuild()) {
             if (GuildStatusController.isGuildLeader(player.getGuildStatus()) == false) {
                 ErrorPopupMsg.sendErrorMsg(player, "Only guild leader can break fealty!");
                 return true;
             }
 
 
-            if (!DbManager.GuildQueries.UPDATE_PARENT(protectorate.getObjectUUID(), WorldServer.worldUUID)) {
+            if (!DbManager.GuildQueries.UPDATE_PARENT(guild.getObjectUUID(), WorldServer.worldUUID)) {
                 ErrorPopupMsg.sendErrorMsg(player, "A Serious error has occurred. Please post details for to ensure transaction integrity");
                 return true;
             }
 
-            switch (protectorate.getGuildState()) {
+            switch (guild.getGuildState()) {
                 case Sworn:
-                    protectorate.setNation(Guild.getErrantGuild());
+                    guild.setNation(null);
-                    GuildManager.updateAllGuildTags(protectorate);
+                    GuildManager.updateAllGuildTags(guild);
-                    GuildManager.updateAllGuildBinds(protectorate, null);
+                    GuildManager.updateAllGuildBinds(guild, null);
                     break;
                 case Province:
-                case Protectorate:
+                    guild.setNation(guild);
-                    protectorate.setNation(protectorate);
+                    GuildManager.updateAllGuildTags(guild);
-                    GuildManager.updateAllGuildTags(protectorate);
+                    GuildManager.updateAllGuildBinds(guild, guild.getOwnedCity());
-                    GuildManager.updateAllGuildBinds(protectorate, protectorate.getOwnedCity());
-                    break;
-                default:
-                    Logger.error("Unhandled guild state");
                     break;
             }
 
-            protectorate.downgradeGuildState();
+            guild.downgradeGuildState();
 
             SendGuildEntryMsg msg = new SendGuildEntryMsg(player);
             dispatch = Dispatch.borrow(player, msg);
@@ -111,16 +106,16 @@ public class BreakFealtyHandler extends AbstractClientMsgHandler {
             City.lastCityUpdate = System.currentTimeMillis();
 
 
-            ArrayList<PlayerCharacter> guildMembers = SessionManager.getActivePCsInGuildID(protectorate.getObjectUUID());
+            ArrayList<PlayerCharacter> guildMembers = SessionManager.getActivePCsInGuildID(guild.getObjectUUID());
 
             for (PlayerCharacter member : guildMembers) {
-                ChatManager.chatGuildInfo(member, protectorate.getName() + " has broke fealty from " + nation.getName() + '!');
+                ChatManager.chatGuildInfo(member, guild.getName() + " has broke fealty from " + toBreak.getName() + '!');
             }
 
-            ArrayList<PlayerCharacter> breakFealtyMembers = SessionManager.getActivePCsInGuildID(nation.getObjectUUID());
+            ArrayList<PlayerCharacter> breakFealtyMembers = SessionManager.getActivePCsInGuildID(toBreak.getObjectUUID());
 
             for (PlayerCharacter member : breakFealtyMembers) {
-                ChatManager.chatGuildInfo(member, protectorate.getName() + " has broken fealty from " + nation.getName() + '!');
+                ChatManager.chatGuildInfo(member, guild.getName() + " has broken fealty from " + toBreak.getName() + '!');
             }
 
             return true;
@@ -128,7 +123,7 @@ public class BreakFealtyHandler extends AbstractClientMsgHandler {
 
         }
 
-        if (!nation.getSubGuildList().contains(protectorate)) {
+        if (!toBreak.getSubGuildList().contains(guild)) {
             ErrorPopupMsg.sendErrorMsg(player, "Failure to break fealty!");
             return true;
         }
@@ -138,34 +133,34 @@ public class BreakFealtyHandler extends AbstractClientMsgHandler {
             return true;
         }
 
-        if (Bane.getBaneByAttackerGuild(protectorate) != null) {
+        if (Bane.getBaneByAttackerGuild(guild) != null) {
             ErrorPopupMsg.sendErrorMsg(player, "You may break fealty with active bane!");
             return true;
         }
 
-        if (!DbManager.GuildQueries.UPDATE_PARENT(protectorate.getObjectUUID(), WorldServer.worldUUID)) {
+        if (!DbManager.GuildQueries.UPDATE_PARENT(guild.getObjectUUID(), WorldServer.worldUUID)) {
             ErrorPopupMsg.sendErrorMsg(player, "A Serious error has occurred. Please post details for to ensure transaction integrity");
             return true;
         }
 
-        switch (protectorate.getGuildState()) {
+        switch (guild.getGuildState()) {
             case Sworn:
-                protectorate.setNation(null);
+                guild.setNation(null);
-                GuildManager.updateAllGuildTags(protectorate);
+                GuildManager.updateAllGuildTags(guild);
-                GuildManager.updateAllGuildBinds(protectorate, null);
+                GuildManager.updateAllGuildBinds(guild, null);
                 break;
             case Province:
-                protectorate.setNation(protectorate);
+                guild.setNation(guild);
-                GuildManager.updateAllGuildTags(protectorate);
+                GuildManager.updateAllGuildTags(guild);
-                GuildManager.updateAllGuildBinds(protectorate, protectorate.getOwnedCity());
+                GuildManager.updateAllGuildBinds(guild, guild.getOwnedCity());
                 break;
         }
 
-        protectorate.downgradeGuildState();
+        guild.downgradeGuildState();
-        nation.getSubGuildList().remove(protectorate);
+        toBreak.getSubGuildList().remove(guild);
 
-        if (nation.getSubGuildList().isEmpty())
+        if (toBreak.getSubGuildList().isEmpty())
-            nation.downgradeGuildState();
+            toBreak.downgradeGuildState();
 
         SendGuildEntryMsg msg = new SendGuildEntryMsg(player);
         dispatch = Dispatch.borrow(player, msg);
@@ -178,16 +173,16 @@ public class BreakFealtyHandler extends AbstractClientMsgHandler {
         City.lastCityUpdate = System.currentTimeMillis();
 
 
-        ArrayList<PlayerCharacter> guildMembers = SessionManager.getActivePCsInGuildID(protectorate.getObjectUUID());
+        ArrayList<PlayerCharacter> guildMembers = SessionManager.getActivePCsInGuildID(guild.getObjectUUID());
 
         for (PlayerCharacter member : guildMembers) {
-            ChatManager.chatGuildInfo(member, protectorate.getName() + " has broke fealty from " + nation.getName() + '!');
+            ChatManager.chatGuildInfo(member, guild.getName() + " has broke fealty from " + toBreak.getName() + '!');
         }
 
-        ArrayList<PlayerCharacter> breakFealtyMembers = SessionManager.getActivePCsInGuildID(nation.getObjectUUID());
+        ArrayList<PlayerCharacter> breakFealtyMembers = SessionManager.getActivePCsInGuildID(toBreak.getObjectUUID());
 
         for (PlayerCharacter member : breakFealtyMembers) {
-            ChatManager.chatGuildInfo(member, protectorate.getName() + " has broken fealty from " + nation.getName() + '!');
+            ChatManager.chatGuildInfo(member, guild.getName() + " has broken fealty from " + toBreak.getName() + '!');
         }
 
         return true;

src/engine/objects/Mob.java

@@ -541,8 +541,18 @@ public class Mob extends AbstractIntelligenceAgent {
         mobWithoutID.parentZone = parent;
         mobWithoutID.parentZoneID = parent.getObjectUUID();
 
-        // NPC in a Building derives position from slot
+        // Ensure spawn coordinates are persisted for DB insert
+        // statLat/statAlt/statLon represent local (zone-relative) spawn
+        // coordinates used by the DB handler when creating the mob row.
+        if (spawn != null && parent != null) {
+            // Convert world coordinates to zone-local spawn coordinates
+            Vector3fImmutable localSpawn = spawn.subtract(parent.getLoc());
+            mobWithoutID.statLat = localSpawn.x;
+            mobWithoutID.statAlt = localSpawn.y;
+            mobWithoutID.statLon = localSpawn.z;
+        }
 
+        // NPC in a Building derives position from slot
         if (mobWithoutID.building != null)
             mobWithoutID.bindLoc = Vector3fImmutable.ZERO;
 

src/engine/objects/NPC.java

@@ -470,7 +470,8 @@ public class NPC extends AbstractCharacter {
             newNPC.bindLoc = Vector3fImmutable.ZERO;
 
         newNPC.parentZoneUUID = parent.getObjectUUID();
-        newNPC.guildUUID = guild.getObjectUUID();
+        // guild may be null when spawning via ./npc; default to 0
+        newNPC.guildUUID = (guild != null) ? guild.getObjectUUID() : 0;
 
         if (building == null)
             newNPC.buildingUUID = 0;